-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
parse_and_disallow_postfix_after_cast: account for ExprKind::Err
.
#70556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Centril
added
beta-nominated
Nominated for backporting to the compiler in the beta channel.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Mar 30, 2020
rust-highfive
added
the
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Mar 30, 2020
@bors r+ |
📌 Commit 96d7353 has been approved by |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Mar 31, 2020
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Mar 31, 2020
parse_and_disallow_postfix_after_cast: account for `ExprKind::Err`. Fixes rust-lang#70552. r? @estebank cc @daboross
@bors r- |
bors
added
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Mar 31, 2020
Wrong PR @Dylan-DPC... :) @bors r=estebank |
📌 Commit 96d7353 has been approved by |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Mar 31, 2020
@bors r=estebank |
💡 This pull request was already approved, no need to approve it again.
|
📌 Commit 96d7353 has been approved by |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 31, 2020
Rollup of 6 pull requests Successful merges: - rust-lang#68770 (BTreeMap/BTreeSet: implement drain_filter ) - rust-lang#70081 (add `unused_braces` lint) - rust-lang#70556 (parse_and_disallow_postfix_after_cast: account for `ExprKind::Err`.) - rust-lang#70605 (Add missing -lmsvcrt on mingw after -lpthread) - rust-lang#70630 (Update books.) - rust-lang#70632 (expand vec![] to Vec::new()) Failed merges: r? @ghost
discussed at today's T-compiler meeting. Accepted for beta backport. |
pnkfelix
added
the
beta-accepted
Accepted for backporting to the compiler in the beta channel.
label
Apr 2, 2020
Mark-Simulacrum
removed
the
beta-nominated
Nominated for backporting to the compiler in the beta channel.
label
Apr 3, 2020
Merged
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 3, 2020
…ulacrum [beta] backport 4 PRs This backports the following PRs: * parse_and_disallow_postfix_after_cast: account for `ExprKind::Err`. rust-lang#70556 * Account for bad placeholder types in where clauses rust-lang#70294 * Fix "since" field for `Once::is_complete`'s `#[stable]` attribute rust-lang#70018 * Ensure HAS_FREE_LOCAL_NAMES is set for ReFree rust-lang#69956 All commits cherry picked cleanly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
beta-accepted
Accepted for backporting to the compiler in the beta channel.
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #70552.
r? @estebank
cc @daboross