Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unnecessary relocation check in const_prop #70614

Merged
merged 1 commit into from
Mar 31, 2020

Conversation

RalfJung
Copy link
Member

Unnecessary as per #70356 (comment)

Fixes #70356
r? @oli-obk Cc @wesleywiser

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 31, 2020
@wesleywiser
Copy link
Member

r? @wesleywiser

@bors r+

@bors
Copy link
Contributor

bors commented Mar 31, 2020

📌 Commit afe1ffb has been approved by wesleywiser

@rust-highfive rust-highfive assigned wesleywiser and unassigned oli-obk Mar 31, 2020
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 31, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 31, 2020
Rollup of 7 pull requests

Successful merges:

 - rust-lang#69425 (add fn make_contiguous to VecDeque)
 - rust-lang#69458 (improve folder name for persistent doc tests)
 - rust-lang#70268 (Document ThreadSanitizer in unstable-book)
 - rust-lang#70600 (Ensure there are versions of test code for aarch64 windows)
 - rust-lang#70606 (Clean up E0466 explanation)
 - rust-lang#70614 (remove unnecessary relocation check in const_prop)
 - rust-lang#70623 (Fix broken link in README)

Failed merges:

r? @ghost
@bors bors merged commit 59809bc into rust-lang:master Mar 31, 2020
@RalfJung RalfJung deleted the cons-prop-reloc branch April 2, 2020 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why does const-prop refuse to read from statics that contain pointers?
5 participants