Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

submodules: update clippy from 326b2204 to 7907abea #70809

Merged
merged 1 commit into from
Apr 5, 2020
Merged

submodules: update clippy from 326b2204 to 7907abea #70809

merged 1 commit into from
Apr 5, 2020

Conversation

matthiaskrgr
Copy link
Member

Changes:

Rustup to rust-lang/rust#70634
Update clippy_lints/src/types.rs
Update types.rs
Update types.rs
Improve docs for option_option
useless Rc<Rc<T>>, Rc<Box<T>>, Rc<&T>, Box<&T>
Allow let_underscore
Update option_option ui test
Test for ignoring let_underscore_must_use
Downgrade option_option to pedantic

Fixes #70709

@matthiaskrgr
submodules: update clippy from 326b220 to 7907abe
04a38e7 
Changes:
````
Rustup to rust-lang#70634
Update clippy_lints/src/types.rs
Update types.rs
Update types.rs
Improve docs for option_option
useless Rc<Rc<T>>, Rc<Box<T>>, Rc<&T>, Box<&T>
Allow let_underscore
Update option_option ui test
Test for ignoring let_underscore_must_use
Downgrade option_option to pedantic
````

Fixes rust-lang#70709
@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 5, 2020
@matthiaskrgr
Copy link
Member Author

r? @Dylan-DPC

@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Apr 5, 2020

📌 Commit 04a38e7 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 5, 2020
@Dylan-DPC-zz
Copy link

was waiting for CI to pass just in case xD

@Dylan-DPC-zz
Copy link

@bors p=1 rollup=never

@bors
Copy link
Contributor

bors commented Apr 5, 2020

⌛ Testing commit 04a38e7 with merge 6387b09...

@bors
Copy link
Contributor

bors commented Apr 5, 2020

☀️ Test successful - checks-azure
Approved by: Mark-Simulacrum
Pushing 6387b09 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 5, 2020
@bors bors merged commit 6387b09 into rust-lang:master Apr 5, 2020
@rust-highfive
Copy link
Collaborator

📣 Toolstate changed by #70809!

Tested on commit 6387b09.
Direct link to PR: #70809

🎉 clippy-driver on windows: build-fail → test-pass (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq).
🎉 clippy-driver on linux: build-fail → test-pass (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Apr 5, 2020
@rust-highfive
📣 Toolstate changed by rust-lang/rust#70809!
76bd797 
Tested on commit rust-lang/rust@6387b09.
Direct link to PR: <rust-lang/rust#70809>

🎉 clippy-driver on windows: build-fail → test-pass (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq).
🎉 clippy-driver on linux: build-fail → test-pass (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq).
@bors bors mentioned this pull request Apr 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

clippy-driver no longer builds after rust-lang/rust#70692
6 participants
@matthiaskrgr @rust-highfive @Mark-Simulacrum @bors @Dylan-DPC-zz @nikomatsakis