Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump Miri #70897

Merged
merged 1 commit into from
Apr 9, 2020
Merged

bump Miri #70897

merged 1 commit into from
Apr 9, 2020

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Apr 7, 2020 •
edited
Loading

r? @ghost Cc @rust-lang/miri

Fixes #70894

@RalfJung
Copy link
Member Author

RalfJung commented Apr 7, 2020

Toolstate fix
@bors r+ p=1

@bors
Copy link
Contributor

bors commented Apr 7, 2020

📌 Commit 203accc has been approved by RalfJung

@bors
Copy link
Contributor

bors commented Apr 7, 2020

🌲 The tree is currently closed for pull requests below priority 1000, this pull request will be tested once the tree is reopened

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Apr 7, 2020
@pietroalbini
Copy link
Member

@bors p=1001

Let's try again.

@bors
Copy link
Contributor

bors commented Apr 7, 2020

⌛ Testing commit 203accc with merge 48fdfe634e486a5abf20577a18467d5657c6174c...

@bors
Copy link
Contributor

bors commented Apr 7, 2020

💔 Test failed - checks-azure

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 7, 2020
@RalfJung RalfJung mentioned this pull request Apr 7, 2020
Closed
@RalfJung
Copy link
Member Author

RalfJung commented Apr 7, 2020

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 7, 2020
@bors
Copy link
Contributor

bors commented Apr 7, 2020

⌛ Testing commit 203accc with merge dc4541ab6869591f8d426525791fa936bb15bf9a...

@bors
Copy link
Contributor

bors commented Apr 7, 2020

💔 Test failed - checks-azure

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 7, 2020
@pietroalbini
Copy link
Member

@bors p=1

@RalfJung
Copy link
Member Author

RalfJung commented Apr 7, 2020

@bors retry
(to get it in the queue again)

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 7, 2020
@RalfJung RalfJung mentioned this pull request Apr 7, 2020
Merged
@bors
Copy link
Contributor

bors commented Apr 8, 2020

⌛ Testing commit 203accc with merge fe8f44254e8a9872b07e5effc8aa250c6910be6c...

@Dylan-DPC-zz
Copy link

@bors retry yield

@bors
Copy link
Contributor

bors commented Apr 9, 2020

⌛ Testing commit 203accc with merge 434f470c1d323de31a2890bf960bf2ee99d28bee...

@Centril
Copy link
Contributor

Centril commented Apr 9, 2020

@bors retry yield

@RalfJung
Copy link
Member Author

RalfJung commented Apr 9, 2020

With all this yielding going on, it looks like we no longer actually prioritize toolstate fixes after all? When can we expect this to land?

@Centril
Copy link
Contributor

Centril commented Apr 9, 2020

(I yielded this because my rollup spuriously failed; that's always something I do with any rollup. I do not think we should have 3 toolstate fixes in a row overtake rollups.)

@RalfJung
Copy link
Member Author

RalfJung commented Apr 9, 2020 •
edited
Loading

It's more like rollups overtaking toolstate fixes, given the priorities of the underlying PRs. (To be clear, I am not generally opposed to that, but it also never took >48h to land a toolstate fix.)

@bors
Copy link
Contributor

bors commented Apr 9, 2020

⌛ Testing commit 203accc with merge 841e441b0a9755cd346999001021ec4d26a04d9b...

@bors
Copy link
Contributor

bors commented Apr 9, 2020

💔 Test failed - checks-azure

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 9, 2020
@Centril
Copy link
Contributor

Centril commented Apr 9, 2020

@bors retry spurious

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 9, 2020
@bors
Copy link
Contributor

bors commented Apr 9, 2020

⌛ Testing commit 203accc with merge 151b2013e668308bf9950977eb172644f91e7e48...

Centril added a commit to Centril/rust that referenced this pull request Apr 9, 2020
@Centril
Rollup merge of rust-lang#70897 - RalfJung:miri, r=RalfJung
32658b3 
bump Miri

r? @ghost Cc @rust-lang/miri

Fixes rust-lang#70894
@Centril Centril mentioned this pull request Apr 9, 2020
Closed
@Centril
Copy link
Contributor

Centril commented Apr 9, 2020

@bors retry included in a r0llup

@RalfJung
Copy link
Member Author

RalfJung commented Apr 9, 2020

Thanks. :)

@Centril Centril mentioned this pull request Apr 9, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 9, 2020
@bors
Auto merge of rust-lang#70960 - Centril:rollup-9vmokvw, r=Centril
94d3463 
Rollup of 5 pull requests

Successful merges:

 - rust-lang#70897 (bump Miri)
 - rust-lang#70900 (Update cargo)
 - rust-lang#70902 (Update Clippy)
 - rust-lang#70939 (Add two const generics regression tests)
 - rust-lang#70958 (Disable try_reserve tests on Android)

Failed merges:

r? @ghost
@bors bors merged commit eecfd19 into rust-lang:master Apr 9, 2020
jonhoo added a commit to jonhoo/flurry that referenced this pull request Apr 10, 2020
@jonhoo
Stop ignoring miri leaks
65ed212 
Now that rust-lang/miri#940 has been fixed,
and has landed in nightly
(rust-lang/rust#70897), we should be able to run
miri with leak check enabled again!
@jonhoo jonhoo mentioned this pull request Apr 10, 2020
Merged
bors bot added a commit to matklad/once_cell that referenced this pull request Apr 10, 2020
@bors @RalfJung
Merge #99
4f974ef 
99: miri: enable leakcheck r=matklad a=RalfJung

rust-lang/miri#940 is fixed, so we should be able to enable the leak checker now. :)

(However, we'll have to wait until rust-lang/rust#70897 lands so that this is available via rustup.)

Co-authored-by: Ralf Jung <post@ralfj.de>
@RalfJung RalfJung deleted the miri branch April 11, 2020 09:33
jonhoo added a commit to jonhoo/flurry that referenced this pull request May 6, 2020
@jonhoo
Stop ignoring miri leaks
0abc0bc 
Now that rust-lang/miri#940 has been fixed,
and has landed in nightly
(rust-lang/rust#70897), we should be able to run
miri with leak check enabled again!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

miri no longer builds after rust-lang/rust#70884
5 participants
@RalfJung @bors @pietroalbini @Dylan-DPC-zz @Centril