Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump rustfmt and rls #71159

Merged
merged 1 commit into from
Apr 16, 2020
Merged

Bump rustfmt and rls #71159

merged 1 commit into from
Apr 16, 2020

Conversation

topecongiro
Copy link
Contributor

Close #71076. Close #71077.

r? @Xanewok

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 15, 2020
@ehuss
Copy link
Contributor

ehuss commented Apr 15, 2020

It looks like maybe you ran cargo update? When updating, you should only update the specific packages that are needed (like cargo update -p rustfmt-nightly -p rls).

@topecongiro
Copy link
Contributor Author

@ehuss Thanks, I have removed unnecessary diffs from Cargo.lock.

@Dylan-DPC-zz
Copy link

@bors r+

@bors
Copy link
Contributor

bors commented Apr 15, 2020

📌 Commit 84c4514 has been approved by Dylan-DPC

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 15, 2020
Centril added a commit to Centril/rust that referenced this pull request Apr 15, 2020
@Centril
Rollup merge of rust-lang#71159 - topecongiro:rustfmt-1.4.14, r=Dylan…
128d622 
…-DPC

Bump rustfmt and rls

Close rust-lang#71076. Close rust-lang#71077.

r? @Xanewok
@Centril Centril mentioned this pull request Apr 15, 2020
Closed
@Dylan-DPC-zz
Copy link

@bors p=1

@bors
Copy link
Contributor

bors commented Apr 15, 2020

⌛ Testing commit 84c4514 with merge 9e6ae1402607ef0dfdd197ca0f23ba2147366ff7...

Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Apr 15, 2020
@Dylan-DPC
Rollup merge of rust-lang#71159 - topecongiro:rustfmt-1.4.14, r=Dylan…
2be7b4d 
…-DPC

Bump rustfmt and rls

Close rust-lang#71076. Close rust-lang#71077.

r? @Xanewok
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Apr 15, 2020
Closed
@Dylan-DPC-zz
Copy link

Dylan-DPC-zz commented Apr 15, 2020 •
edited
Loading

@bors retry (yield to rollup which includes this)

@bors
Copy link
Contributor

bors commented Apr 15, 2020

⌛ Testing commit 84c4514 with merge e276380ccc8e3a246caaca153f51f5c094653afb...

@pietroalbini
Copy link
Member

@bors treeclosed=1000

@bors
Copy link
Contributor

bors commented Apr 15, 2020

💔 Test failed - checks-azure

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 15, 2020
@pietroalbini
Copy link
Member

@bors retry

@bors bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 15, 2020
@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Apr 15, 2020
@Dylan-DPC-zz
Copy link

@bors p=5

@bors
Copy link
Contributor

bors commented Apr 16, 2020

⌛ Testing commit 84c4514 with merge be895b2...

@bors
Copy link
Contributor

bors commented Apr 16, 2020

☀️ Test successful - checks-azure
Approved by: Dylan-DPC
Pushing be895b2 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 16, 2020
@bors bors merged commit be895b2 into rust-lang:master Apr 16, 2020
@rust-highfive
Copy link
Collaborator

📣 Toolstate changed by #71159!

Tested on commit be895b2.
Direct link to PR: #71159

🎉 rls on windows: build-fail → test-pass (cc @Xanewok).
🎉 rls on linux: build-fail → test-pass (cc @Xanewok).
🎉 rustfmt on windows: build-fail → test-pass (cc @topecongiro).
🎉 rustfmt on linux: build-fail → test-pass (cc @topecongiro).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Apr 16, 2020
@rust-highfive
📣 Toolstate changed by rust-lang/rust#71159!
bfe9e3e 
Tested on commit rust-lang/rust@be895b2.
Direct link to PR: <rust-lang/rust#71159>

🎉 rls on windows: build-fail → test-pass (cc @Xanewok).
🎉 rls on linux: build-fail → test-pass (cc @Xanewok).
🎉 rustfmt on windows: build-fail → test-pass (cc @topecongiro).
🎉 rustfmt on linux: build-fail → test-pass (cc @topecongiro).
@RalfJung RalfJung mentioned this pull request Apr 16, 2020
Closed
@senden9 senden9 mentioned this pull request Apr 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xanewok Xanewok Xanewok approved these changes

Assignees

@Xanewok Xanewok

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rustfmt no longer builds after rust-lang/rust#71059 rls no longer builds after rust-lang/rust#71059
7 participants
@topecongiro @rust-highfive @ehuss @Dylan-DPC-zz @bors @pietroalbini @Xanewok