Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kind-check closure freevars against destination builtin bounds. #7119

Closed
wants to merge 2 commits into from
Closed

Kind-check closure freevars against destination builtin bounds. #7119

wants to merge 2 commits into from

Conversation

bblum
Copy link
Contributor

@bblum bblum commented Jun 13, 2013

r? @nikomatsakis

Things this doesn't check for:

  • doesn't treat stack closure freevars as implicit borrows
  • doesn't add more capabilities at closure usage sites
  • doesn't restrict capabilities at same (i.e., still can copy stack closures that capture &mut)
  • doesn't do trait bounds

@nikomatsakis
Copy link
Contributor

General nit: Please add a comment at the top of each test saying the purpose of the test. Sorry about the test cast nits, but I've kind of got an unwritten Best Practice going on with respect to type-checker tests. Really helps with maintaining them over time.

Anyway, the basic changes look good, so after correcting nits, feel free to give r=nmatsakis yourself.

@bblum bblum closed this Jun 14, 2013
flip1995 pushed a commit to flip1995/rust that referenced this pull request Apr 22, 2021
@bors
Auto merge of rust-lang#7119 - flip1995:rustup, r=flip1995
98e2b9f 
Rustup

r? `@ghost`

changelog: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bblum @nikomatsakis