remove build warnings #71303
Merged
remove build warnings #71303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code blocks that are not annotated are assumed to be Rust
|
r? @varkor (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
It sounds like there's an underlying bug here as well, as we should always be running with warnings denied in CI. Can you say which command you're running that's printing warnings? |
|
It probably was |
|
Hm. Odd. Anyway, @bors r+ rollup for now, but would be good to track that down. |
|
📌 Commit fcbefae has been approved by |
bors
added
S-waiting-on-bors
|
@Mark-Simulacrum I was actually surprised by the warnings, given there's no |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 18, 2020
Rollup of 5 pull requests Successful merges: - rust-lang#71271 (Move `MapInPlace` to rustc_data_structures) - rust-lang#71276 (miri-unleashed: test that we detect heap allocations) - rust-lang#71283 (Minor improvements to -Zprofile) - rust-lang#71287 (Explain why we shouldn't add inline attr to into_vec) - rust-lang#71303 (remove build warnings) Failed merges: r? @ghost
Actually I think I saw those warnings because I was running |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code blocks that are not annotated are assumed to be Rust