Check code blocks tags #71408

GuillaumeGomez · 2020-04-21T23:01:54Z

Explanations here: I realized recently that it was a common issue to confuse/misspell tags on code blocks. This is actually quite a big issue since it generally ends up in a code blocks being ignored since it's not being considered as a rust one. With this new warning, users will at least be notified about it.

PS: some improvements can be done on the error rendering but considering how big the PR already is, I think it's better to do it afterwards.

r? @ollie27

cc @rust-lang/rustdoc

rust-highfive · 2020-04-22T00:31:11Z

The job x86_64-gnu-llvm-8 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2020-04-21T23:02:43.7248472Z ========================== Starting Command Output ===========================
2020-04-21T23:02:43.7251314Z [command]/bin/bash --noprofile --norc /home/vsts/work/_temp/fdbb9dcd-46a0-4f3b-b0a2-45d1319a273e.sh
2020-04-21T23:02:43.7251599Z 
2020-04-21T23:02:43.7255895Z ##[section]Finishing: Disable git automatic line ending conversion
2020-04-21T23:02:43.7279118Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/71408/merge to s
2020-04-21T23:02:43.7283541Z Task         : Get sources
2020-04-21T23:02:43.7283825Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-04-21T23:02:43.7284099Z Version      : 1.0.0
2020-04-21T23:02:43.7284301Z Author       : Microsoft
---
2020-04-21T23:02:44.7461506Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-04-21T23:02:44.7468393Z ##[command]git config gc.auto 0
2020-04-21T23:02:44.7471848Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-04-21T23:02:44.7476224Z ##[command]git config --get-all http.proxy
2020-04-21T23:02:44.7483597Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/71408/merge:refs/remotes/pull/71408/merge
---
2020-04-21T23:04:42.9488950Z  ---> 318032b5f0e2
2020-04-21T23:04:42.9489705Z Step 5/8 : ENV RUST_CONFIGURE_ARGS       --build=x86_64-unknown-linux-gnu       --llvm-root=/usr/lib/llvm-8       --enable-llvm-link-shared       --set rust.thin-lto-import-instr-limit=10
2020-04-21T23:04:42.9490280Z  ---> Using cache
2020-04-21T23:04:42.9490613Z  ---> d44a858fd1ce
2020-04-21T23:04:42.9491520Z Step 6/8 : ENV SCRIPT python2.7 ../x.py test --exclude src/tools/tidy &&            python2.7 ../x.py test src/test/mir-opt --pass=build                                   --target=armv5te-unknown-linux-gnueabi &&            python2.7 ../x.py test src/tools/tidy
2020-04-21T23:04:42.9492529Z  ---> 58b910f50f5a
2020-04-21T23:04:42.9492730Z Step 7/8 : ENV NO_DEBUG_ASSERTIONS=1
2020-04-21T23:04:42.9493087Z  ---> Using cache
2020-04-21T23:04:42.9493416Z  ---> ee7702aadba1
---
2020-04-21T23:04:42.9850380Z Looks like docker image is the same as before, not uploading
2020-04-21T23:04:49.8114627Z [CI_JOB_NAME=x86_64-gnu-llvm-8]
2020-04-21T23:04:49.8387439Z [CI_JOB_NAME=x86_64-gnu-llvm-8]
2020-04-21T23:04:49.8417642Z == clock drift check ==
2020-04-21T23:04:49.8428497Z   local time: Tue Apr 21 23:04:49 UTC 2020
2020-04-21T23:04:49.8857500Z   network time: Tue, 21 Apr 2020 23:04:49 GMT
2020-04-21T23:04:49.8882870Z Starting sccache server...
2020-04-21T23:04:49.9735039Z configure: processing command line
2020-04-21T23:04:49.9735353Z configure: 
2020-04-21T23:04:49.9736220Z configure: rust.dist-src        := False
---
2020-04-21T23:10:01.0656231Z    Compiling rustc_feature v0.0.0 (/checkout/src/librustc_feature)
2020-04-21T23:10:02.5144111Z    Compiling fmt_macros v0.0.0 (/checkout/src/libfmt_macros)
2020-04-21T23:10:04.0736982Z    Compiling rustc_ast_pretty v0.0.0 (/checkout/src/librustc_ast_pretty)
2020-04-21T23:10:04.9348866Z    Compiling rustc_hir v0.0.0 (/checkout/src/librustc_hir)
2020-04-21T23:10:13.9082679Z    Compiling rustc_query_system v0.0.0 (/checkout/src/librustc_query_system)
2020-04-21T23:10:16.0629321Z    Compiling rustc_hir_pretty v0.0.0 (/checkout/src/librustc_hir_pretty)
2020-04-21T23:10:20.3515983Z    Compiling rustc_attr v0.0.0 (/checkout/src/librustc_attr)
2020-04-21T23:10:24.3788598Z    Compiling rustc_parse v0.0.0 (/checkout/src/librustc_parse)
2020-04-21T23:10:34.3678039Z    Compiling rustc_ast_lowering v0.0.0 (/checkout/src/librustc_ast_lowering)
---
2020-04-21T23:32:07.3683417Z    Compiling rustc_feature v0.0.0 (/checkout/src/librustc_feature)
2020-04-21T23:32:08.9285512Z    Compiling fmt_macros v0.0.0 (/checkout/src/libfmt_macros)
2020-04-21T23:32:10.5392755Z    Compiling rustc_ast_pretty v0.0.0 (/checkout/src/librustc_ast_pretty)
2020-04-21T23:32:10.7039851Z    Compiling rustc_hir v0.0.0 (/checkout/src/librustc_hir)
2020-04-21T23:32:20.7215601Z    Compiling rustc_query_system v0.0.0 (/checkout/src/librustc_query_system)
2020-04-21T23:32:22.9661410Z    Compiling rustc_hir_pretty v0.0.0 (/checkout/src/librustc_hir_pretty)
2020-04-21T23:32:27.6441367Z    Compiling rustc_attr v0.0.0 (/checkout/src/librustc_attr)
2020-04-21T23:32:31.9372885Z    Compiling rustc_parse v0.0.0 (/checkout/src/librustc_parse)
2020-04-21T23:32:41.9699589Z    Compiling rustc_ast_lowering v0.0.0 (/checkout/src/librustc_ast_lowering)
---
2020-04-21T23:54:44.0170165Z .................................................................................................... 1600/9912
2020-04-21T23:54:50.1162759Z .................................................................................................... 1700/9912
2020-04-21T23:54:54.2952253Z .................................................................................................... 1800/9912
2020-04-21T23:55:02.5786418Z .................................................................................................... 1900/9912
2020-04-21T23:55:10.2035528Z ..i................................................................................................. 2000/9912
2020-04-21T23:55:16.2807925Z ............................................................................................iiiii... 2100/9912
2020-04-21T23:55:35.5365088Z .................................................................................................... 2300/9912
2020-04-21T23:55:37.7192559Z .................................................................................................... 2400/9912
2020-04-21T23:55:39.9552067Z .................................................................................................... 2500/9912
2020-04-21T23:55:45.6465676Z .................................................................................................... 2600/9912
---
2020-04-21T23:58:38.5251435Z .................................................................................................... 5100/9912
2020-04-21T23:58:45.8160586Z .................................................................................................... 5200/9912
2020-04-21T23:58:50.9634536Z ...............i.................................................................................... 5300/9912
2020-04-21T23:59:00.7284995Z .....i.............................................................................................. 5400/9912
2020-04-21T23:59:06.0390886Z .....ii.ii........i...i............................................................................. 5500/9912
2020-04-21T23:59:14.1151434Z ....................................................i............................................... 5700/9912
2020-04-21T23:59:23.2611048Z ....................................................................................ii.............. 5800/9912
2020-04-21T23:59:30.3918127Z .......................i............................................................................ 5900/9912
2020-04-21T23:59:35.9493198Z .................................................................................................... 6000/9912
2020-04-21T23:59:35.9493198Z .................................................................................................... 6000/9912
2020-04-21T23:59:46.6460245Z .................................................................................................... 6100/9912
2020-04-21T23:59:56.7157643Z .................ii...i..ii...........i............................................................. 6200/9912
2020-04-22T00:00:11.1484203Z .................................................................................................... 6400/9912
2020-04-22T00:00:14.6392436Z .................................................................................................... 6500/9912
2020-04-22T00:00:14.6392436Z .................................................................................................... 6500/9912
2020-04-22T00:00:24.1484048Z ...............................................i..ii................................................ 6600/9912
2020-04-22T00:00:46.2323243Z .................................................................................................... 6800/9912
2020-04-22T00:00:48.5046296Z ................................................i................................................... 6900/9912
2020-04-22T00:00:50.5583921Z .................................................................................................... 7000/9912
2020-04-22T00:00:52.5818334Z ........................................................................................i........... 7100/9912
---
2020-04-22T00:02:27.5196338Z .................................................................................................... 7900/9912
2020-04-22T00:02:33.8375509Z .................................................................................................... 8000/9912
2020-04-22T00:02:39.4334020Z ......................................................i............................................. 8100/9912
2020-04-22T00:02:49.2195671Z .................................................................................................... 8200/9912
2020-04-22T00:02:54.4837441Z ...iiiiii.iiiii.i................................................................................... 8300/9912
2020-04-22T00:03:07.5763163Z .................................................................................................... 8500/9912
2020-04-22T00:03:15.2814813Z .................................................................................................... 8600/9912
2020-04-22T00:03:28.5448209Z .................................................................................................... 8700/9912
2020-04-22T00:03:35.0560839Z .................................................................................................... 8800/9912
---
2020-04-22T00:05:51.7269813Z Suite("src/test/codegen") not skipped for "bootstrap::test::Codegen" -- not in ["src/tools/tidy"]
2020-04-22T00:05:51.7477961Z Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-04-22T00:05:51.9454492Z 
2020-04-22T00:05:51.9455839Z running 186 tests
2020-04-22T00:05:54.9545321Z iiii......i.............ii.i..........i.............................i..i..................i....i.... 100/186
2020-04-22T00:05:57.5588737Z ........i.i.i...iii..iiiiiiiiiiiiiiii.......................iii...............ii......
2020-04-22T00:05:57.5594772Z 
2020-04-22T00:05:57.5599683Z  finished in 5.812
2020-04-22T00:05:57.5610127Z Suite("src/test/codegen-units") not skipped for "bootstrap::test::CodegenUnits" -- not in ["src/tools/tidy"]
2020-04-22T00:05:57.5813326Z Check compiletest suite=codegen-units mode=codegen-units (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
---
2020-04-22T00:05:59.7620765Z st/assembly") not skipped for "bootstrap::test::Assembly" -- not in ["src/tools/tidy"]
2020-04-22T00:05:59.7834696Z Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-04-22T00:05:59.9473032Z 
2020-04-22T00:05:59.9474025Z running 9 tests
2020-04-22T00:05:59.9475594Z iiiiiiiii
2020-04-22T00:05:59.9478431Z 
2020-04-22T00:05:59.9479312Z  finished in 0.163
2020-04-22T00:05:59.9517617Z Suite("src/test/incremental") not skipped for "bootstrap::test::Incremental" -- not in ["src/tools/tidy"]
2020-04-22T00:05:59.9734030Z Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
---
2020-04-22T00:06:20.4202431Z Suite("src/test/debuginfo") not skipped for "bootstrap::test::Debuginfo" -- not in ["src/tools/tidy"]
2020-04-22T00:06:20.4436138Z Check compiletest suite=debuginfo mode=debuginfo (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-04-22T00:06:21.3892711Z 
2020-04-22T00:06:21.3893080Z running 115 tests
2020-04-22T00:06:34.7336019Z iiiii..i.....i..i...i..i.i.i..i..i..ii....i.i....ii..........iiii.........i.....i..i.......ii.i.ii.. 100/115
2020-04-22T00:06:36.5301725Z ...iiii.....ii.
2020-04-22T00:06:36.5303081Z 
2020-04-22T00:06:36.5303279Z  finished in 16.086
2020-04-22T00:06:36.5320009Z Suite("src/test/ui-fulldeps") not skipped for "bootstrap::test::UiFullDeps" -- not in ["src/tools/tidy"]
2020-04-22T00:06:36.5320728Z Uplifting stage1 rustc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
---
2020-04-22T00:18:11.5570596Z warning: 2 warnings emitted
2020-04-22T00:18:11.5571587Z 
2020-04-22T00:18:11.5632295Z 
2020-04-22T00:18:11.5632838Z running 2499 tests
2020-04-22T00:18:20.4236208Z ......iiiii......................................................................................... 100/2499
2020-04-22T00:18:29.2375335Z ......................................................................................ii............ 200/2499
2020-04-22T00:18:49.1537567Z ......................i............................................................................. 400/2499
2020-04-22T00:18:58.9138302Z ............................................................................i..i..................ii 500/2499
2020-04-22T00:19:06.2877221Z ii.................................................................................................. 600/2499
2020-04-22T00:19:14.6898284Z .................................................................................................... 700/2499
---
2020-04-22T00:23:06.6990193Z 
2020-04-22T00:23:06.7019156Z running 1020 tests
2020-04-22T00:23:21.8841994Z i................................................................................................... 100/1020
2020-04-22T00:23:31.6857920Z .................................................................................................... 200/1020
2020-04-22T00:23:38.9778558Z ...................iii......i......i...i......i..................................................... 300/1020
2020-04-22T00:23:43.6975238Z .................................................................................................... 400/1020
2020-04-22T00:23:50.0616189Z ....................................................i....i......................................ii.. 500/1020
2020-04-22T00:24:02.3312112Z .................................................................................................... 700/1020
2020-04-22T00:24:02.3312112Z .................................................................................................... 700/1020
2020-04-22T00:24:09.0483425Z ..............................................iiii.................................................. 800/1020
2020-04-22T00:24:21.7654487Z .................................................................................................... 900/1020
2020-04-22T00:24:27.5675789Z ....................................................................iiii............................ 1000/1020
2020-04-22T00:24:28.7753417Z test result: ok. 1000 passed; 0 failed; 20 ignored; 0 measured; 0 filtered out
2020-04-22T00:24:28.7753658Z 
2020-04-22T00:24:28.7854669Z  finished in 153.663
2020-04-22T00:24:28.7858621Z Set({"src/libterm"}) not skipped for "bootstrap::test::Crate" -- not in ["src/tools/tidy"]
---
2020-04-22T00:27:26.5772927Z 
2020-04-22T00:27:26.5773407Z test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out
2020-04-22T00:27:26.5773784Z 
2020-04-22T00:27:26.5832136Z  finished in 0.970
2020-04-22T00:27:26.5840127Z Set({"/checkout/src/librustc_query_system"}) not skipped for "bootstrap::test::CrateLibrustc" -- not in ["src/tools/tidy"]
2020-04-22T00:27:26.5844699Z Testing rustc_query_system stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-04-22T00:27:26.7703852Z    Compiling rustc_query_system v0.0.0 (/checkout/src/librustc_query_system)
2020-04-22T00:27:27.7656067Z      Running build/x86_64-unknown-linux-gnu/stage1-rustc/x86_64-unknown-linux-gnu/release/deps/rustc_query_system-8304b02342b1f7fd
2020-04-22T00:27:27.7685763Z 
2020-04-22T00:27:27.7686034Z running 0 tests
2020-04-22T00:27:27.7686154Z 
---
2020-04-22T00:29:26.4587999Z    Compiling rustdoc v0.0.0 (/checkout/src/librustdoc)
2020-04-22T00:29:33.3278750Z error[E0061]: this function takes 4 arguments but 3 arguments were supplied
2020-04-22T00:29:33.3279525Z    --> src/librustdoc/html/markdown/tests.rs:67:13
2020-04-22T00:29:33.3280016Z     |
2020-04-22T00:29:33.3281235Z 67  |               LangString::parse(s, ErrorCodes::Yes, true),
2020-04-22T00:29:33.3282386Z     |               ^^^^^^^^^^^^^^^^^ -  ---------------  ---- supplied 3 arguments
2020-04-22T00:29:33.3284280Z     |               expected 4 arguments
2020-04-22T00:29:33.3284784Z     | 
2020-04-22T00:29:33.3285309Z    ::: src/librustdoc/html/markdown.rs:717:5
2020-04-22T00:29:33.3285801Z     |
---
2020-04-22T00:29:34.5039458Z warning: build failed, waiting for other jobs to finish...
2020-04-22T00:31:04.3884341Z error: build failed
2020-04-22T00:31:04.3903909Z 
2020-04-22T00:31:04.3905236Z 
2020-04-22T00:31:04.3907907Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "test" "--target" "x86_64-unknown-linux-gnu" "-Zbinary-dep-depinfo" "-j" "2" "--release" "--locked" "--color" "always" "--manifest-path" "/checkout/src/tools/rustdoc/Cargo.toml" "-p" "rustdoc:0.0.0" "--" "--quiet"
2020-04-22T00:31:04.3909431Z 
2020-04-22T00:31:04.3909663Z 
2020-04-22T00:31:04.3921439Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test --exclude src/tools/tidy
2020-04-22T00:31:04.3921831Z Build completed unsuccessfully in 1:24:38
2020-04-22T00:31:04.3921831Z Build completed unsuccessfully in 1:24:38
2020-04-22T00:31:04.3977180Z == clock drift check ==
2020-04-22T00:31:04.3993050Z   local time: Wed Apr 22 00:31:04 UTC 2020
2020-04-22T00:31:04.4687060Z   network time: Wed, 22 Apr 2020 00:31:04 GMT
2020-04-22T00:31:05.1768565Z 
2020-04-22T00:31:05.1768565Z 
2020-04-22T00:31:05.1864856Z ##[error]Bash exited with code '1'.
2020-04-22T00:31:05.1877990Z ##[section]Finishing: Run build
2020-04-22T00:31:05.1924940Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/71408/merge to s
2020-04-22T00:31:05.1929981Z Task         : Get sources
2020-04-22T00:31:05.1930296Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-04-22T00:31:05.1930600Z Version      : 1.0.0
2020-04-22T00:31:05.1930818Z Author       : Microsoft
2020-04-22T00:31:05.1930818Z Author       : Microsoft
2020-04-22T00:31:05.1931150Z Help         : [More Information](https://go.microsoft.com/fwlink/?LinkId=798199)
2020-04-22T00:31:05.1931539Z ==============================================================================
2020-04-22T00:31:05.5299731Z Cleaning any cached credential from repository: rust-lang/rust (GitHub)
2020-04-22T00:31:05.5362625Z ##[section]Finishing: Checkout rust-lang/rust@refs/pull/71408/merge to s
2020-04-22T00:31:05.5449729Z Cleaning up task key
2020-04-22T00:31:05.5451052Z Start cleaning up orphan processes.
2020-04-22T00:31:05.5630243Z Terminate orphan process: pid (3722) (python)
2020-04-22T00:31:05.5868768Z ##[section]Finishing: Finalize Job

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

kinnison

At minimum we need to test that COMPILE_FAIL and friends are correctly handled.

src/librustdoc/html/markdown.rs

src/librustc_session/lint/builtin.rs

GuillaumeGomez · 2020-04-23T12:32:05Z

Updated!

kinnison

The test files still call them tags, otherwise looks good.

rust-highfive · 2020-04-23T14:00:05Z

Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2020-04-23T12:31:19.8034263Z ========================== Starting Command Output ===========================
2020-04-23T12:31:19.8036617Z [command]/bin/bash --noprofile --norc /home/vsts/work/_temp/546a9fc9-3d65-4254-b58c-4b7a32122a42.sh
2020-04-23T12:31:19.8036858Z 
2020-04-23T12:31:19.8041055Z ##[section]Finishing: Disable git automatic line ending conversion
2020-04-23T12:31:19.8082251Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/71408/merge to s
2020-04-23T12:31:19.8086454Z Task         : Get sources
2020-04-23T12:31:19.8086857Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-04-23T12:31:19.8087231Z Version      : 1.0.0
2020-04-23T12:31:19.8087491Z Author       : Microsoft
---
2020-04-23T12:31:20.8066317Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-04-23T12:31:20.8076912Z ##[command]git config gc.auto 0
2020-04-23T12:31:20.8081063Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-04-23T12:31:20.8084027Z ##[command]git config --get-all http.proxy
2020-04-23T12:31:20.8089704Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/71408/merge:refs/remotes/pull/71408/merge
---
2020-04-23T12:34:14.6346930Z  ---> 318032b5f0e2
2020-04-23T12:34:14.6347614Z Step 5/8 : ENV RUST_CONFIGURE_ARGS       --build=x86_64-unknown-linux-gnu       --llvm-root=/usr/lib/llvm-8       --enable-llvm-link-shared       --set rust.thin-lto-import-instr-limit=10
2020-04-23T12:34:14.6349815Z  ---> Using cache
2020-04-23T12:34:14.6350147Z  ---> d44a858fd1ce
2020-04-23T12:34:14.6352241Z Step 6/8 : ENV SCRIPT python2.7 ../x.py test --exclude src/tools/tidy &&            python2.7 ../x.py test src/test/mir-opt --pass=build                                   --target=armv5te-unknown-linux-gnueabi &&            python2.7 ../x.py test src/tools/tidy
2020-04-23T12:34:14.6356369Z  ---> 58b910f50f5a
2020-04-23T12:34:14.6356533Z Step 7/8 : ENV NO_DEBUG_ASSERTIONS=1
2020-04-23T12:34:14.6359092Z  ---> Using cache
2020-04-23T12:34:14.6360049Z  ---> ee7702aadba1
---
2020-04-23T12:34:14.6780348Z Looks like docker image is the same as before, not uploading
2020-04-23T12:34:20.2714837Z [CI_JOB_NAME=x86_64-gnu-llvm-8]
2020-04-23T12:34:20.2986980Z [CI_JOB_NAME=x86_64-gnu-llvm-8]
2020-04-23T12:34:20.3016825Z == clock drift check ==
2020-04-23T12:34:20.3026689Z   local time: Thu Apr 23 12:34:20 UTC 2020
2020-04-23T12:34:20.5930733Z   network time: Thu, 23 Apr 2020 12:34:20 GMT
2020-04-23T12:34:20.5954039Z Starting sccache server...
2020-04-23T12:34:20.6763933Z configure: processing command line
2020-04-23T12:34:20.6765447Z configure: 
2020-04-23T12:34:20.6769829Z configure: rust.dist-src        := False
---
2020-04-23T12:39:20.5435922Z    Compiling rustc_feature v0.0.0 (/checkout/src/librustc_feature)
2020-04-23T12:39:21.9189224Z    Compiling fmt_macros v0.0.0 (/checkout/src/libfmt_macros)
2020-04-23T12:39:23.4899378Z    Compiling rustc_ast_pretty v0.0.0 (/checkout/src/librustc_ast_pretty)
2020-04-23T12:39:24.4535262Z    Compiling rustc_hir v0.0.0 (/checkout/src/librustc_hir)
2020-04-23T12:39:32.9523151Z    Compiling rustc_query_system v0.0.0 (/checkout/src/librustc_query_system)
2020-04-23T12:39:35.0721555Z    Compiling rustc_hir_pretty v0.0.0 (/checkout/src/librustc_hir_pretty)
2020-04-23T12:39:39.1771398Z    Compiling rustc_attr v0.0.0 (/checkout/src/librustc_attr)
2020-04-23T12:39:43.1901580Z    Compiling rustc_parse v0.0.0 (/checkout/src/librustc_parse)
2020-04-23T12:39:52.3842715Z    Compiling rustc_ast_lowering v0.0.0 (/checkout/src/librustc_ast_lowering)
---
2020-04-23T13:01:13.4742862Z    Compiling rustc_feature v0.0.0 (/checkout/src/librustc_feature)
2020-04-23T13:01:14.9744165Z    Compiling fmt_macros v0.0.0 (/checkout/src/libfmt_macros)
2020-04-23T13:01:16.6530346Z    Compiling rustc_ast_pretty v0.0.0 (/checkout/src/librustc_ast_pretty)
2020-04-23T13:01:16.7660855Z    Compiling rustc_hir v0.0.0 (/checkout/src/librustc_hir)
2020-04-23T13:01:26.9097122Z    Compiling rustc_query_system v0.0.0 (/checkout/src/librustc_query_system)
2020-04-23T13:01:29.0428739Z    Compiling rustc_hir_pretty v0.0.0 (/checkout/src/librustc_hir_pretty)
2020-04-23T13:01:33.5784024Z    Compiling rustc_attr v0.0.0 (/checkout/src/librustc_attr)
2020-04-23T13:01:37.9027309Z    Compiling rustc_parse v0.0.0 (/checkout/src/librustc_parse)
2020-04-23T13:01:47.8937779Z    Compiling rustc_ast_lowering v0.0.0 (/checkout/src/librustc_ast_lowering)
---
2020-04-23T13:23:39.8214147Z .................................................................................................... 1700/9917
2020-04-23T13:23:44.5567697Z .................................................................................................... 1800/9917
2020-04-23T13:23:52.0563011Z .................................................................................................... 1900/9917
2020-04-23T13:23:59.3644401Z .....i.............................................................................................. 2000/9917
2020-04-23T13:24:05.0895083Z ...............................................................................................iiiii 2100/9917
2020-04-23T13:24:23.2121017Z .................................................................................................... 2300/9917
2020-04-23T13:24:25.2577641Z .................................................................................................... 2400/9917
2020-04-23T13:24:27.4624782Z .................................................................................................... 2500/9917
2020-04-23T13:24:32.8658656Z .................................................................................................... 2600/9917
---
2020-04-23T13:27:18.8969740Z .................................................................................................... 5100/9917
2020-04-23T13:27:25.3851335Z .................................................................................................... 5200/9917
2020-04-23T13:27:29.7149992Z ..................i................................................................................. 5300/9917
2020-04-23T13:27:38.7658162Z ........i........................................................................................... 5400/9917
2020-04-23T13:27:43.8438884Z ........ii.ii........i....i......................................................................... 5500/9917
2020-04-23T13:27:51.0987533Z .......................................................i............................................ 5700/9917
2020-04-23T13:27:59.3742589Z ........................................................................................ii.......... 5800/9917
2020-04-23T13:28:05.7888438Z ...........................i........................................................................ 5900/9917
2020-04-23T13:28:10.8054491Z .................................................................................................... 6000/9917
2020-04-23T13:28:10.8054491Z .................................................................................................... 6000/9917
2020-04-23T13:28:20.3882149Z .................................................................................................... 6100/9917
2020-04-23T13:28:29.5178814Z .....................ii...i..ii...........i......................................................... 6200/9917
2020-04-23T13:28:44.7992327Z .................................................................................................... 6400/9917
2020-04-23T13:28:48.1298384Z .................................................................................................... 6500/9917
2020-04-23T13:28:48.1298384Z .................................................................................................... 6500/9917
2020-04-23T13:28:55.9392236Z ...................................................i..ii............................................ 6600/9917
2020-04-23T13:29:17.1070157Z .................................................................................................... 6800/9917
2020-04-23T13:29:19.3372282Z ....................................................i............................................... 6900/9917
2020-04-23T13:29:21.1832529Z .................................................................................................... 7000/9917
2020-04-23T13:29:23.0539098Z ............................................................................................i....... 7100/9917
---
2020-04-23T13:30:50.8836993Z .................................................................................................... 7900/9917
2020-04-23T13:30:56.2732424Z .................................................................................................... 8000/9917
2020-04-23T13:31:02.0383162Z ...........................................................i........................................ 8100/9917
2020-04-23T13:31:11.0102796Z .................................................................................................... 8200/9917
2020-04-23T13:31:16.0393871Z ........iiiiii.iiiii.i.............................................................................. 8300/9917
2020-04-23T13:31:28.5659102Z .................................................................................................... 8500/9917
2020-04-23T13:31:35.3384115Z .................................................................................................... 8600/9917
2020-04-23T13:31:47.5495981Z .................................................................................................... 8700/9917
2020-04-23T13:31:53.3449179Z .................................................................................................... 8800/9917
---
2020-04-23T13:33:53.7778113Z Suite("src/test/codegen") not skipped for "bootstrap::test::Codegen" -- not in ["src/tools/tidy"]
2020-04-23T13:33:53.7946820Z Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-04-23T13:33:53.9829895Z 
2020-04-23T13:33:53.9830582Z running 186 tests
2020-04-23T13:33:56.6406116Z iiii......i.............ii.i..........i.............................i..i..................i....i.... 100/186
2020-04-23T13:33:58.9884205Z ........i.i.i...iii..iiiiiiiiiiiiiiii.......................iii...............ii......
2020-04-23T13:33:58.9889507Z 
2020-04-23T13:33:58.9892688Z  finished in 5.194
2020-04-23T13:33:58.9898339Z Suite("src/test/codegen-units") not skipped for "bootstrap::test::CodegenUnits" -- not in ["src/tools/tidy"]
2020-04-23T13:33:59.0073426Z Check compiletest suite=codegen-units mode=codegen-units (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
---
2020-04-23T13:34:00.9810827Z Suite("src/test/assembly") not skipped for "bootstrap::test::Assembly" -- not in ["src/tools/tidy"]
2020-04-23T13:34:00.9995419Z Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-04-23T13:34:01.1405124Z 
2020-04-23T13:34:01.1407831Z running 9 tests
2020-04-23T13:34:01.1415653Z iiiiiiiii
2020-04-23T13:34:01.1424441Z 
2020-04-23T13:34:01.1425306Z  finished in 0.141
2020-04-23T13:34:01.1442732Z Suite("src/test/incremental") not skipped for "bootstrap::test::Incremental" -- not in ["src/tools/tidy"]
2020-04-23T13:34:01.1637343Z Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
---
2020-04-23T13:34:19.8617716Z Suite("src/test/debuginfo") not skipped for "bootstrap::test::Debuginfo" -- not in ["src/tools/tidy"]
2020-04-23T13:34:19.8830579Z Check compiletest suite=debuginfo mode=debuginfo (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-04-23T13:34:20.0589489Z 
2020-04-23T13:34:20.0589829Z running 115 tests
2020-04-23T13:34:32.5071560Z iiiii..i.....i..i...i..i.i.i..i..i..ii....i.i....ii..........iiii.........i.....i..i.......ii.i.ii.. 100/115
2020-04-23T13:34:34.1068477Z ...iiii.....ii.
2020-04-23T13:34:34.1070001Z 
2020-04-23T13:34:34.1074023Z  finished in 14.224
2020-04-23T13:34:34.1078425Z Suite("src/test/ui-fulldeps") not skipped for "bootstrap::test::UiFullDeps" -- not in ["src/tools/tidy"]
2020-04-23T13:34:34.1080956Z Uplifting stage1 rustc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
---
2020-04-23T13:44:59.4526883Z warning: 2 warnings emitted
2020-04-23T13:44:59.4527318Z 
2020-04-23T13:44:59.4588510Z 
2020-04-23T13:44:59.4588900Z running 2499 tests
2020-04-23T13:45:07.4529657Z ......iiiii......................................................................................... 100/2499
2020-04-23T13:45:15.3231988Z ......................................................................................ii............ 200/2499
2020-04-23T13:45:33.3029242Z ......................i............................................................................. 400/2499
2020-04-23T13:45:42.0846497Z ............................................................................i..i..................ii 500/2499
2020-04-23T13:45:48.7226085Z ii.................................................................................................. 600/2499
2020-04-23T13:45:56.5567445Z .................................................................................................... 700/2499
---
2020-04-23T13:49:25.6945173Z 
2020-04-23T13:49:25.6946334Z running 1020 tests
2020-04-23T13:49:40.5708481Z i................................................................................................... 100/1020
2020-04-23T13:49:49.6769695Z .................................................................................................... 200/1020
2020-04-23T13:49:56.5384210Z ....................iii.....i......i...i......i..................................................... 300/1020
2020-04-23T13:50:01.0649292Z .................................................................................................... 400/1020
2020-04-23T13:50:07.1023094Z ....................................................i....i......................................ii.. 500/1020
2020-04-23T13:50:18.5074139Z .................................................................................................... 700/1020
2020-04-23T13:50:18.5074139Z .................................................................................................... 700/1020
2020-04-23T13:50:24.8802665Z ..............................................iiii.................................................. 800/1020
2020-04-23T13:50:36.9256338Z .................................................................................................... 900/1020
2020-04-23T13:50:42.3748679Z ....................................................................iiii............................ 1000/1020
2020-04-23T13:50:43.4840113Z test result: ok. 1000 passed; 0 failed; 20 ignored; 0 measured; 0 filtered out
2020-04-23T13:50:43.4840559Z 
2020-04-23T13:50:43.4945142Z  finished in 143.228
2020-04-23T13:50:44.2020128Z Set({"src/libterm"}) not skipped for "bootstrap::test::Crate" -- not in ["src/tools/tidy"]
---
2020-04-23T13:53:25.3884918Z 
2020-04-23T13:53:25.3885197Z test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out
2020-04-23T13:53:25.3885394Z 
2020-04-23T13:53:25.3939489Z  finished in 0.856
2020-04-23T13:53:25.3956011Z Set({"/checkout/src/librustc_query_system"}) not skipped for "bootstrap::test::CrateLibrustc" -- not in ["src/tools/tidy"]
2020-04-23T13:53:25.3970537Z Testing rustc_query_system stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-04-23T13:53:25.5661222Z    Compiling rustc_query_system v0.0.0 (/checkout/src/librustc_query_system)
2020-04-23T13:53:26.4581337Z      Running build/x86_64-unknown-linux-gnu/stage1-rustc/x86_64-unknown-linux-gnu/release/deps/rustc_query_system-53b1fe752cf363d4
2020-04-23T13:53:26.4609317Z 
2020-04-23T13:53:26.4610414Z running 0 tests
2020-04-23T13:53:26.4610585Z 
---
2020-04-23T13:55:13.1379720Z    Compiling rustdoc v0.0.0 (/checkout/src/librustdoc)
2020-04-23T13:55:19.3417800Z error[E0061]: this function takes 4 arguments but 3 arguments were supplied
2020-04-23T13:55:19.3418541Z    --> src/librustdoc/html/markdown/tests.rs:67:13
2020-04-23T13:55:19.3419052Z     |
2020-04-23T13:55:19.3419731Z 67  |               LangString::parse(s, ErrorCodes::Yes, true),
2020-04-23T13:55:19.3421046Z     |               ^^^^^^^^^^^^^^^^^ -  ---------------  ---- supplied 3 arguments
2020-04-23T13:55:19.3422507Z     |               expected 4 arguments
2020-04-23T13:55:19.3423013Z     | 
2020-04-23T13:55:19.3423529Z    ::: src/librustdoc/html/markdown.rs:717:5
2020-04-23T13:55:19.3424002Z     |
---
2020-04-23T13:55:20.4984864Z warning: build failed, waiting for other jobs to finish...
2020-04-23T13:56:41.5032185Z error: build failed
2020-04-23T13:56:41.5042718Z 
2020-04-23T13:56:41.5045041Z 
2020-04-23T13:56:41.5046305Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "test" "--target" "x86_64-unknown-linux-gnu" "-Zbinary-dep-depinfo" "-j" "2" "--release" "--locked" "--color" "always" "--manifest-path" "/checkout/src/tools/rustdoc/Cargo.toml" "-p" "rustdoc:0.0.0" "--" "--quiet"
2020-04-23T13:56:41.5047109Z 
2020-04-23T13:56:41.5047195Z 
2020-04-23T13:56:41.5058290Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test --exclude src/tools/tidy
2020-04-23T13:56:41.5058669Z Build completed unsuccessfully in 1:20:49
2020-04-23T13:56:41.5058669Z Build completed unsuccessfully in 1:20:49
2020-04-23T13:56:41.5112862Z == clock drift check ==
2020-04-23T13:56:41.5139542Z   local time: Thu Apr 23 13:56:41 UTC 2020
2020-04-23T13:56:41.5909221Z   network time: Thu, 23 Apr 2020 13:56:41 GMT
2020-04-23T13:56:42.2940239Z 
2020-04-23T13:56:42.2940239Z 
2020-04-23T13:56:42.3049967Z ##[error]Bash exited with code '1'.
2020-04-23T13:56:42.3060134Z ##[section]Finishing: Run build
2020-04-23T13:56:42.3100101Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/71408/merge to s
2020-04-23T13:56:42.3105025Z Task         : Get sources
2020-04-23T13:56:42.3105354Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-04-23T13:56:42.3105636Z Version      : 1.0.0
2020-04-23T13:56:42.3105845Z Author       : Microsoft
2020-04-23T13:56:42.3105845Z Author       : Microsoft
2020-04-23T13:56:42.3106185Z Help         : [More Information](https://go.microsoft.com/fwlink/?LinkId=798199)
2020-04-23T13:56:42.3106545Z ==============================================================================
2020-04-23T13:56:42.8170917Z Cleaning any cached credential from repository: rust-lang/rust (GitHub)
2020-04-23T13:56:42.8212632Z ##[section]Finishing: Checkout rust-lang/rust@refs/pull/71408/merge to s
2020-04-23T13:56:42.8294737Z Cleaning up task key
2020-04-23T13:56:42.8295896Z Start cleaning up orphan processes.
2020-04-23T13:56:42.8461068Z Terminate orphan process: pid (4346) (python)
2020-04-23T13:56:42.8674934Z ##[section]Finishing: Finalize Job

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

GuillaumeGomez · 2020-04-23T14:20:02Z

Renamed the tests files. :3

kinnison · 2020-04-23T18:03:12Z

@bors r+

bors · 2020-04-23T18:03:13Z

📌 Commit 977603c has been approved by kinnison

@ghost

Rollup of 7 pull requests Successful merges: - rust-lang#70633 (Confusing suggestion on incorrect closing `}`) - rust-lang#71404 (Don't fuse Chain in its second iterator) - rust-lang#71408 (Check code blocks tags) - rust-lang#71442 (Add a "by reference" adaptor for `AllocRef`) - rust-lang#71446 (Only use read_unaligned in transmute_copy if necessary) - rust-lang#71470 (Fix doc links) - rust-lang#71479 (add back Scalar::null_ptr) Failed merges: r? @ghost

flip1995 · 2020-04-24T01:03:07Z

This PR introduced a weird regression in Clippy, see https://github.com/rust-lang/rust-clippy/runs/613510829#step:14:47

I guess this lint is now enabled for code blocks but wasn't before?

GuillaumeGomez · 2020-04-26T11:18:54Z

It wasn't indeed. And it's not a regression, it just means that you have incorrect attributes (which is a good news I guess).

rust-highfive assigned ollie27 Apr 21, 2020

JohnTitor added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 22, 2020

kinnison suggested changes Apr 22, 2020

View reviewed changes

src/librustdoc/html/markdown.rs Show resolved Hide resolved

src/librustdoc/html/markdown.rs Outdated Show resolved Hide resolved

src/librustdoc/html/markdown.rs Show resolved Hide resolved

src/librustc_session/lint/builtin.rs Outdated Show resolved Hide resolved

Create new rustdoc lint to check for code blocks tags

c687d04

GuillaumeGomez force-pushed the check-code-blocks-tags branch from 7e7d547 to cba9293 Compare April 23, 2020 12:30

kinnison reviewed Apr 23, 2020

View reviewed changes

Add UI tests for new rustdoc lint

96a352e

GuillaumeGomez force-pushed the check-code-blocks-tags branch from cba9293 to 96a352e Compare April 23, 2020 14:19

Update LangString::parse usage in markdown tests

977603c

GuillaumeGomez mentioned this pull request Apr 23, 2020

Improve help for code blocks invalid attributes #71469

Closed

kinnison approved these changes Apr 23, 2020

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 23, 2020

GuillaumeGomez mentioned this pull request Apr 23, 2020

Deny invalid-doctest-attribute for error-index-check #71478

Closed

Dylan-DPC-zz mentioned this pull request Apr 23, 2020

Rollup of 7 pull requests #71483

Merged

bors merged commit 0959802 into rust-lang:master Apr 23, 2020

GuillaumeGomez deleted the check-code-blocks-tags branch April 24, 2020 12:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Check code blocks tags #71408

Check code blocks tags #71408

GuillaumeGomez commented Apr 21, 2020 •

edited

Loading

rust-highfive commented Apr 22, 2020

kinnison left a comment

GuillaumeGomez commented Apr 23, 2020

kinnison left a comment

rust-highfive commented Apr 23, 2020

GuillaumeGomez commented Apr 23, 2020

kinnison commented Apr 23, 2020

bors commented Apr 23, 2020

flip1995 commented Apr 24, 2020

GuillaumeGomez commented Apr 26, 2020 •

edited

Loading

Check code blocks tags #71408

Check code blocks tags #71408

Conversation

GuillaumeGomez commented Apr 21, 2020 • edited Loading

rust-highfive commented Apr 22, 2020

kinnison left a comment

Choose a reason for hiding this comment

GuillaumeGomez commented Apr 23, 2020

kinnison left a comment

Choose a reason for hiding this comment

rust-highfive commented Apr 23, 2020

GuillaumeGomez commented Apr 23, 2020

kinnison commented Apr 23, 2020

bors commented Apr 23, 2020

flip1995 commented Apr 24, 2020

GuillaumeGomez commented Apr 26, 2020 • edited Loading

GuillaumeGomez commented Apr 21, 2020 •

edited

Loading

GuillaumeGomez commented Apr 26, 2020 •

edited

Loading