Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add help message for missing right operand in condition #71433

Merged
merged 1 commit into from
Apr 30, 2020
Merged

Add help message for missing right operand in condition #71433

merged 1 commit into from
Apr 30, 2020

Conversation

antoyo
Copy link
Contributor

@antoyo antoyo commented Apr 22, 2020

closes #30035

@rust-highfive
Copy link
Collaborator

r? @matthewjasper

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 22, 2020
@GuillaumeGomez
Copy link
Member

👍

@joelpalmer joelpalmer added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 30, 2020
@Dylan-DPC-zz
Copy link

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Apr 30, 2020

📌 Commit f8f0f7b has been approved by Dylan-DPC

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 30, 2020
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Apr 30, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 30, 2020
@bors
Auto merge of rust-lang#71717 - Dylan-DPC:rollup-av5vjor, r=Dylan-DPC
7ced01a 
Rollup of 5 pull requests

Successful merges:

 - rust-lang#70950 (extend NLL checker to understand `'empty` combined with universes)
 - rust-lang#71433 (Add help message for missing right operand in condition)
 - rust-lang#71449 (Move `{Free,}RegionRelations` and `FreeRegionMap` to `rustc_infer`)
 - rust-lang#71559 (Detect git version before attempting to use --progress)
 - rust-lang#71597 (Rename Unique::empty() -> Unique::dangling())

Failed merges:

r? @ghost
@bors bors merged commit be3faf3 into rust-lang:master Apr 30, 2020
@antoyo antoyo deleted the error/missing-right-operand branch May 1, 2020 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@matthewjasper matthewjasper

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Better error message when forgetting the right operand in an if condition
7 participants
@antoyo @rust-highfive @GuillaumeGomez @Dylan-DPC-zz @bors @joelpalmer @matthewjasper