Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shrink GHA configuration #71434

Merged
merged 2 commits into from
Apr 26, 2020
Merged

Conversation

pietroalbini
Copy link
Member

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 22, 2020
@Mark-Simulacrum
Copy link
Member

@bors r+

Great!

@bors
Copy link
Contributor

bors commented Apr 22, 2020

📌 Commit 61831ff has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 22, 2020
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Apr 23, 2020
…ark-Simulacrum

Shrink GHA configuration

This shrinks our GHA configuration by [taking advantage of two new features GitHub just announced](https://github.blog/2020-04-22-github-actions-community-momentum-enterprise-capabilities-and-developer-improvements/):

* [Default values for `steps[].shell`](https://help.github.com/en/actions/reference/workflow-syntax-for-github-actions#defaultsrun)
* [Being able to include values in a matrix without having to duplicate the job names.](https://help.github.com/en/actions/reference/workflow-syntax-for-github-actions#example-including-new-combinations)

The configuration should be functionally equivalent to the previous one.

r? @Mark-Simulacrum
@Dylan-DPC-zz
Copy link

@bors p=1

@bors
Copy link
Contributor

bors commented Apr 26, 2020

⌛ Testing commit 61831ff with merge 019ab73...

@bors
Copy link
Contributor

bors commented Apr 26, 2020

☀️ Test successful - checks-azure
Approved by: Mark-Simulacrum
Pushing 019ab73 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 26, 2020
@bors bors merged commit 019ab73 into rust-lang:master Apr 26, 2020
@pietroalbini pietroalbini deleted the shrink-gha-config branch April 26, 2020 10:11
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 30, 2020
…, r=Mark-Simulacrum

ci: use bash when executing the "bors build finished" jobs

We don't clone the repository in those builders, so the default shell (`src/ci/exec-with-shell.py`) is not present there. This fixes a GHA regression introduced in rust-lang#71434.

r? @Mark-Simulacrum
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants