Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggest adding super trait constraints #71451

Merged
merged 4 commits into from
May 13, 2020
Merged

Suggest adding super trait constraints #71451

merged 4 commits into from
May 13, 2020

Conversation

estebank
Copy link
Contributor

No description provided.

@rust-highfive
Copy link
Collaborator

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 22, 2020
@estebank
Copy link
Contributor Author

The first commit is the only logic change. The second change only changes the output to be more verbose and clear.

@crlf0710 crlf0710 added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 2, 2020
@bors

This comment has been minimized.

Sign in to view
@estebank estebank force-pushed the suggest-super-trait-constraint branch from 9ed0197 to cbaff49 Compare May 7, 2020 00:26
@estebank
Copy link
Contributor Author

estebank commented May 7, 2020

r? @nikomatsakis

@rust-highfive rust-highfive assigned nikomatsakis and unassigned eddyb May 7, 2020
@rust-highfive

This comment has been minimized.

Sign in to view
@estebank estebank force-pushed the suggest-super-trait-constraint branch from cbaff49 to 9c539dc Compare May 7, 2020 19:54
@nikomatsakis
Copy link
Contributor

r=me with nits

@nikomatsakis nikomatsakis added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 11, 2020
@estebank estebank force-pushed the suggest-super-trait-constraint branch from 9c539dc to 58797b0 Compare May 12, 2020 18:56
@estebank
Copy link
Contributor Author

@bors r=nikomatsakis

@bors
Copy link
Contributor

bors commented May 13, 2020

📌 Commit 58797b0 has been approved by nikomatsakis

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 13, 2020
@bors
Copy link
Contributor

bors commented May 13, 2020

⌛ Testing commit 58797b0 with merge 750db09...

@bors
Copy link
Contributor

bors commented May 13, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: nikomatsakis
Pushing 750db09 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 13, 2020
@bors bors merged commit 750db09 into rust-lang:master May 13, 2020
This was referenced May 13, 2020
Closed
Merged
Closed
@estebank estebank deleted the suggest-super-trait-constraint branch November 9, 2023 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikomatsakis nikomatsakis nikomatsakis approved these changes

Assignees

@nikomatsakis nikomatsakis

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@estebank @rust-highfive @bors @nikomatsakis @eddyb @crlf0710