-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disable LLD build for cross compiled hosts #71457
Conversation
At present, the LLD build requested by the --enable-lld configure option appears to make direct use of the "llvm-config" binary built as part of the LLVM build. For cross built LLVM, the "llvm-config" binary produced is intended to run on the target system, so it seems like this cannot work as intended today. Disable the LLD build for cross compiled hosts, while continuing to allow --enable-lld to build a native LLD for use by targets like Fuchsia that expect to use it for linking.
(rust_highfive has picked a reviewer for you, use r? to override) |
NOTE: This was chiefly motivated by bumping into this issue as part of work on #71272. |
Hi! I'd like to continue moving on #71272. Would somebody be able to take a look at this PR, and tell me if my analysis is incorrect or if there's a better way I could work on fixing this? Thanks. |
#71486 should properly fix the issue. I'll test it and report later today. |
Cool! Thank you! |
#71486 is now merged and the binary looks correct to me:
|
At present, the LLD build requested by the --enable-lld configure option
appears to make direct use of the "llvm-config" binary built as part of
the LLVM build. For cross built LLVM, the "llvm-config" binary produced
is intended to run on the target system, so it seems like this cannot
work as intended today. Disable the LLD build for cross compiled hosts,
while continuing to allow --enable-lld to build a native LLD for use by
targets like Fuchsia that expect to use it for linking.