Remove ast::{Ident, Name} reexports. #71555

cjgillot · 2020-04-25T16:08:38Z

The reexport of Symbol into Name confused me.

petrochenkov · 2020-04-25T16:37:16Z

Historically, ast::Name is an identifier symbol in AST, while Symbol (which had many other names in the past) is an arbitrary interned string (maybe a literal, or other arbitrary text).

ast::Ident is also an identifier in AST specifically (as opposed to e.g. identifiers tokens which are lowered to AST idents losing their is_raw bit), I don't remember how it ended up in rustc_span.

rust-highfive · 2020-04-25T17:34:12Z

Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2020-04-25T16:18:23.9415592Z ========================== Starting Command Output ===========================
2020-04-25T16:18:23.9420703Z [command]/bin/bash --noprofile --norc /home/vsts/work/_temp/aa756419-ff71-4d4a-8c4b-d33d0275dbad.sh
2020-04-25T16:18:23.9421176Z 
2020-04-25T16:18:23.9426246Z ##[section]Finishing: Disable git automatic line ending conversion
2020-04-25T16:18:23.9446079Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/71555/merge to s
2020-04-25T16:18:23.9449658Z Task         : Get sources
2020-04-25T16:18:23.9450070Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-04-25T16:18:23.9450349Z Version      : 1.0.0
2020-04-25T16:18:23.9450541Z Author       : Microsoft
---
2020-04-25T16:18:25.4978328Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-04-25T16:18:25.4986492Z ##[command]git config gc.auto 0
2020-04-25T16:18:25.4995088Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-04-25T16:18:25.5000985Z ##[command]git config --get-all http.proxy
2020-04-25T16:18:25.5012811Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/71555/merge:refs/remotes/pull/71555/merge
---
2020-04-25T16:20:44.2738353Z  ---> cb2676f08729
2020-04-25T16:20:44.2739156Z Step 5/8 : ENV RUST_CONFIGURE_ARGS       --build=x86_64-unknown-linux-gnu       --llvm-root=/usr/lib/llvm-8       --enable-llvm-link-shared       --set rust.thin-lto-import-instr-limit=10
2020-04-25T16:20:44.2742589Z  ---> Using cache
2020-04-25T16:20:44.2742951Z  ---> df25ce111862
2020-04-25T16:20:44.2743926Z Step 6/8 : ENV SCRIPT python2.7 ../x.py test --exclude src/tools/tidy &&            python2.7 ../x.py test src/test/mir-opt --pass=build                                   --target=armv5te-unknown-linux-gnueabi &&            python2.7 ../x.py test src/tools/tidy
2020-04-25T16:20:44.2769580Z  ---> 599b9ac96b27
2020-04-25T16:20:44.2769839Z Step 7/8 : ENV NO_DEBUG_ASSERTIONS=1
2020-04-25T16:20:44.2770571Z  ---> Using cache
2020-04-25T16:20:44.2770907Z  ---> 091087e35a36
---
2020-04-25T16:20:44.3147021Z Looks like docker image is the same as before, not uploading
2020-04-25T16:20:52.2253251Z [CI_JOB_NAME=x86_64-gnu-llvm-8]
2020-04-25T16:20:52.2543453Z [CI_JOB_NAME=x86_64-gnu-llvm-8]
2020-04-25T16:20:52.2594053Z == clock drift check ==
2020-04-25T16:20:52.2594661Z   local time: Sat Apr 25 16:20:52 UTC 2020
2020-04-25T16:20:52.2867190Z   network time: Sat, 25 Apr 2020 16:20:52 GMT
2020-04-25T16:20:52.2894165Z Starting sccache server...
2020-04-25T16:20:52.3747743Z configure: processing command line
2020-04-25T16:20:52.3748468Z configure: 
2020-04-25T16:20:52.3749459Z configure: rust.dist-src        := False
---
2020-04-25T16:26:51.7237307Z    Compiling rustc_feature v0.0.0 (/checkout/src/librustc_feature)
2020-04-25T16:26:53.4771799Z    Compiling fmt_macros v0.0.0 (/checkout/src/libfmt_macros)
2020-04-25T16:26:55.3613500Z    Compiling rustc_ast_pretty v0.0.0 (/checkout/src/librustc_ast_pretty)
2020-04-25T16:26:58.6419425Z    Compiling rustc_hir v0.0.0 (/checkout/src/librustc_hir)
2020-04-25T16:27:07.4315089Z    Compiling rustc_query_system v0.0.0 (/checkout/src/librustc_query_system)
2020-04-25T16:27:12.2145753Z    Compiling rustc_hir_pretty v0.0.0 (/checkout/src/librustc_hir_pretty)
2020-04-25T16:27:17.7005483Z    Compiling rustc_attr v0.0.0 (/checkout/src/librustc_attr)
2020-04-25T16:27:22.5562588Z    Compiling rustc_parse v0.0.0 (/checkout/src/librustc_parse)
2020-04-25T16:27:31.9514381Z    Compiling rustc_ast_lowering v0.0.0 (/checkout/src/librustc_ast_lowering)
---
2020-04-25T16:53:31.5698751Z    Compiling rustc_feature v0.0.0 (/checkout/src/librustc_feature)
2020-04-25T16:53:33.4910985Z    Compiling fmt_macros v0.0.0 (/checkout/src/libfmt_macros)
2020-04-25T16:53:35.5638658Z    Compiling rustc_ast_pretty v0.0.0 (/checkout/src/librustc_ast_pretty)
2020-04-25T16:53:36.6064992Z    Compiling rustc_hir v0.0.0 (/checkout/src/librustc_hir)
2020-04-25T16:53:47.8413771Z    Compiling rustc_query_system v0.0.0 (/checkout/src/librustc_query_system)
2020-04-25T16:53:51.6007787Z    Compiling rustc_hir_pretty v0.0.0 (/checkout/src/librustc_hir_pretty)
2020-04-25T16:53:56.9404013Z    Compiling rustc_attr v0.0.0 (/checkout/src/librustc_attr)
2020-04-25T16:54:02.1297297Z    Compiling rustc_parse v0.0.0 (/checkout/src/librustc_parse)
2020-04-25T16:54:12.0445139Z    Compiling rustc_ast_lowering v0.0.0 (/checkout/src/librustc_ast_lowering)
---
2020-04-25T17:20:22.9749388Z .................................................................................................... 1700/9922
2020-04-25T17:20:27.5777119Z .................................................................................................... 1800/9922
2020-04-25T17:20:36.8642593Z .................................................................................................... 1900/9922
2020-04-25T17:20:45.6501467Z ......i............................................................................................. 2000/9922
2020-04-25T17:20:52.4060765Z ................................................................................................iiii 2100/9922
2020-04-25T17:21:07.3513010Z i................................................................................................... 2200/9922
2020-04-25T17:21:16.4523769Z .................................................................................................... 2400/9922
2020-04-25T17:21:18.8962494Z .................................................................................................... 2500/9922
2020-04-25T17:21:25.1317966Z .................................................................................................... 2600/9922
2020-04-25T17:21:46.3795287Z .................................................................................................... 2700/9922
---
2020-04-25T17:24:39.3819454Z .................................................................................................... 5100/9922
2020-04-25T17:24:47.3057817Z .................................................................................................... 5200/9922
2020-04-25T17:24:52.3985548Z ...................i................................................................................ 5300/9922
2020-04-25T17:25:02.7843039Z ..........i......................................................................................... 5400/9922
2020-04-25T17:25:08.8445486Z ..........ii.ii........i...i........................................................................ 5500/9922
2020-04-25T17:25:17.2453647Z .........................................................i.......................................... 5700/9922
2020-04-25T17:25:26.6209843Z ..........................................................................................ii........ 5800/9922
2020-04-25T17:25:33.7702167Z .............................i...................................................................... 5900/9922
2020-04-25T17:25:39.9807985Z .................................................................................................... 6000/9922
2020-04-25T17:25:39.9807985Z .................................................................................................... 6000/9922
2020-04-25T17:25:51.4897014Z .................................................................................................... 6100/9922
2020-04-25T17:26:02.0498100Z .......................ii...i..ii...........i....................................................... 6200/9922
2020-04-25T17:26:19.6017898Z .................................................................................................... 6400/9922
2020-04-25T17:26:27.3267151Z .................................................................................................... 6500/9922
2020-04-25T17:26:27.3267151Z .................................................................................................... 6500/9922
2020-04-25T17:26:39.4074725Z .....................................................i..ii.......................................... 6600/9922
2020-04-25T17:27:07.7208279Z .................................................................................................... 6800/9922
2020-04-25T17:27:11.0135753Z ......................................................i............................................. 6900/9922
2020-04-25T17:27:13.2541667Z .................................................................................................... 7000/9922
2020-04-25T17:27:15.6269828Z ................................................................................................i... 7100/9922
---
2020-04-25T17:29:05.4098809Z .................................................................................................... 7900/9922
2020-04-25T17:29:11.2675329Z .................................................................................................... 8000/9922
2020-04-25T17:29:18.4038259Z ...............................................................i.................................... 8100/9922
2020-04-25T17:29:29.3873770Z .................................................................................................... 8200/9922
2020-04-25T17:29:35.1884349Z ............iiiiii.iiiii.i.......................................................................... 8300/9922
2020-04-25T17:29:50.4232405Z .................................................................................................... 8500/9922
2020-04-25T17:29:57.2324556Z .................................................................................................... 8600/9922
2020-04-25T17:30:13.1220789Z .................................................................................................... 8700/9922
2020-04-25T17:30:20.5501105Z .................................................................................................... 8800/9922
---
2020-04-25T17:32:49.9496199Z Suite("src/test/codegen") not skipped for "bootstrap::test::Codegen" -- not in ["src/tools/tidy"]
2020-04-25T17:32:49.9705477Z Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-04-25T17:32:50.1887756Z 
2020-04-25T17:32:50.1888802Z running 186 tests
2020-04-25T17:32:53.4870735Z iiii......i.............ii.i..........i.............................i..i..................i....i.... 100/186
2020-04-25T17:32:56.3687770Z ........i.i.i...iii..iiiiiiiiiiiiiiii.......................iii...............ii......
2020-04-25T17:32:56.3692166Z 
2020-04-25T17:32:56.3696622Z  finished in 6.399
2020-04-25T17:32:56.3703751Z Suite("src/test/codegen-units") not skipped for "bootstrap::test::CodegenUnits" -- not in ["src/tools/tidy"]
2020-04-25T17:32:56.3991932Z Check compiletest suite=codegen-units mode=codegen-units (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
---
2020-04-25T17:32:58.6454162Z Suite("src/test/assembly") not skipped for "bootstrap::test::Assembly" -- not in ["src/tools/tidy"]
2020-04-25T17:32:58.6705759Z Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-04-25T17:32:58.8390249Z 
2020-04-25T17:32:58.8393370Z running 9 tests
2020-04-25T17:32:58.8394815Z iiiiiiiii
2020-04-25T17:32:58.8398983Z 
2020-04-25T17:32:58.8399159Z  finished in 0.169
2020-04-25T17:32:58.8400192Z Suite("src/test/incremental") not skipped for "bootstrap::test::Incremental" -- not in ["src/tools/tidy"]
2020-04-25T17:32:58.8605978Z Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
---
2020-04-25T17:33:20.6811715Z Suite("src/test/debuginfo") not skipped for "bootstrap::test::Debuginfo" -- not in ["src/tools/tidy"]
2020-04-25T17:33:20.7082450Z Check compiletest suite=debuginfo mode=debuginfo (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-04-25T17:33:20.9268796Z 
2020-04-25T17:33:20.9269187Z running 115 tests
2020-04-25T17:33:35.2660309Z iiiii..i.....i..i...i..i.i.i..i..i..ii....i.i....ii..........iiii.........i.....i..i.......ii.i.ii.. 100/115
2020-04-25T17:33:37.2107351Z ...iiii.....ii.
2020-04-25T17:33:37.2112759Z 
2020-04-25T17:33:37.2117950Z  finished in 16.504
2020-04-25T17:33:37.2133518Z Suite("src/test/ui-fulldeps") not skipped for "bootstrap::test::UiFullDeps" -- not in ["src/tools/tidy"]
2020-04-25T17:33:37.2134795Z Uplifting stage1 rustc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
---
2020-04-25T17:34:06.4978430Z ---- [ui] ui-fulldeps/pprust-expr-roundtrip.rs stdout ----
2020-04-25T17:34:06.4978617Z 
2020-04-25T17:34:06.4979014Z error: test compilation failed although it shouldn't!
2020-04-25T17:34:06.4979270Z status: exit code: 1
2020-04-25T17:34:06.4981015Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui-fulldeps/pprust-expr-roundtrip.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/pprust-expr-roundtrip/a" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/pprust-expr-roundtrip/auxiliary"
2020-04-25T17:34:06.4982697Z ------------------------------------------
2020-04-25T17:34:06.4982857Z 
2020-04-25T17:34:06.4983228Z ------------------------------------------
2020-04-25T17:34:06.4983419Z stderr:
2020-04-25T17:34:06.4983419Z stderr:
2020-04-25T17:34:06.4983782Z ------------------------------------------
2020-04-25T17:34:06.4984102Z error[E0433]: failed to resolve: use of undeclared type or module `Ident`
2020-04-25T17:34:06.4984664Z   --> /checkout/src/test/ui-fulldeps/pprust-expr-roundtrip.rs:62:39
2020-04-25T17:34:06.4984909Z    |
2020-04-25T17:34:06.4985166Z LL |     let seg = PathSegment::from_ident(Ident::from_str("x"));
2020-04-25T17:34:06.4985759Z 
2020-04-25T17:34:06.4986104Z error[E0433]: failed to resolve: use of undeclared type or module `Ident`
2020-04-25T17:34:06.4986727Z   --> /checkout/src/test/ui-fulldeps/pprust-expr-roundtrip.rs:83:51
2020-04-25T17:34:06.4986963Z    |
2020-04-25T17:34:06.4986963Z    |
2020-04-25T17:34:06.4987227Z LL |                 let seg = PathSegment::from_ident(Ident::from_str("x"));
2020-04-25T17:34:06.4988828Z 
2020-04-25T17:34:06.4991170Z error[E0433]: failed to resolve: use of undeclared type or module `Ident`
2020-04-25T17:34:06.4991876Z   --> /checkout/src/test/ui-fulldeps/pprust-expr-roundtrip.rs:135:69
2020-04-25T17:34:06.4992114Z    |
2020-04-25T17:34:06.4992114Z    |
2020-04-25T17:34:06.4992671Z LL |                 iter_exprs(depth - 1, &mut |e| g(ExprKind::Field(e, Ident::from_str("f"))));
2020-04-25T17:34:06.4995590Z 
2020-04-25T17:34:06.4995830Z error[E0433]: failed to resolve: use of undeclared type or module `Ident`
2020-04-25T17:34:06.4996538Z   --> /checkout/src/test/ui-fulldeps/pprust-expr-roundtrip.rs:154:45
2020-04-25T17:34:06.4996776Z    |
2020-04-25T17:34:06.4996776Z    |
2020-04-25T17:34:06.4997030Z LL |                 let path = Path::from_ident(Ident::from_str("S"));
2020-04-25T17:34:06.4997669Z 
2020-04-25T17:34:06.4997844Z error: aborting due to 4 previous errors
2020-04-25T17:34:06.4997999Z 
2020-04-25T17:34:06.4998436Z For more information about this error, try `rustc --explain E0433`.
---
2020-04-25T17:34:06.5000512Z test result: FAILED. 63 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out
2020-04-25T17:34:06.5000748Z 
2020-04-25T17:34:06.5000883Z 
2020-04-25T17:34:06.5000975Z 
2020-04-25T17:34:06.5005495Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui-fulldeps" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-8/bin/FileCheck" "--nodejs" "/usr/bin/node" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "8.0.0" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2020-04-25T17:34:06.5008159Z 
2020-04-25T17:34:06.5008259Z 
2020-04-25T17:34:06.5009592Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:348:22
2020-04-25T17:34:06.5009985Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
2020-04-25T17:34:06.5009985Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
2020-04-25T17:34:06.5010605Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test --exclude src/tools/tidy
2020-04-25T17:34:06.5011084Z Build completed unsuccessfully in 1:11:21
2020-04-25T17:34:06.5059464Z == clock drift check ==
2020-04-25T17:34:06.5077295Z   local time: Sat Apr 25 17:34:06 UTC 2020
2020-04-25T17:34:06.5307331Z   network time: Sat, 25 Apr 2020 17:34:06 GMT
2020-04-25T17:34:07.3041662Z 
2020-04-25T17:34:07.3041662Z 
2020-04-25T17:34:07.3120114Z ##[error]Bash exited with code '1'.
2020-04-25T17:34:07.3134441Z ##[section]Finishing: Run build
2020-04-25T17:34:07.3196959Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/71555/merge to s
2020-04-25T17:34:07.3202516Z Task         : Get sources
2020-04-25T17:34:07.3202844Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-04-25T17:34:07.3203130Z Version      : 1.0.0
2020-04-25T17:34:07.3203767Z Author       : Microsoft
2020-04-25T17:34:07.3203767Z Author       : Microsoft
2020-04-25T17:34:07.3204089Z Help         : [More Information](https://go.microsoft.com/fwlink/?LinkId=798199)
2020-04-25T17:34:07.3205136Z ==============================================================================
2020-04-25T17:34:07.6934199Z Cleaning any cached credential from repository: rust-lang/rust (GitHub)
2020-04-25T17:34:07.6981472Z ##[section]Finishing: Checkout rust-lang/rust@refs/pull/71555/merge to s
2020-04-25T17:34:07.7086587Z Cleaning up task key
2020-04-25T17:34:07.7088043Z Start cleaning up orphan processes.
2020-04-25T17:34:07.7411245Z Terminate orphan process: pid (5114) (python)
2020-04-25T17:34:07.7461168Z ##[section]Finishing: Finalize Job

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

rust-highfive · 2020-04-25T20:51:54Z

Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2020-04-25T19:19:50.0981065Z ========================== Starting Command Output ===========================
2020-04-25T19:19:50.0986586Z [command]/bin/bash --noprofile --norc /home/vsts/work/_temp/1a8be272-941e-4b3e-964d-32bdfab3c3a1.sh
2020-04-25T19:19:50.0987074Z 
2020-04-25T19:19:50.0992451Z ##[section]Finishing: Disable git automatic line ending conversion
2020-04-25T19:19:50.1012103Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/71555/merge to s
2020-04-25T19:19:50.1016228Z Task         : Get sources
2020-04-25T19:19:50.1016526Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-04-25T19:19:50.1016840Z Version      : 1.0.0
2020-04-25T19:19:50.1017035Z Author       : Microsoft
---
2020-04-25T19:19:51.1098692Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-04-25T19:19:51.1104876Z ##[command]git config gc.auto 0
2020-04-25T19:19:51.1108703Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-04-25T19:19:51.1113482Z ##[command]git config --get-all http.proxy
2020-04-25T19:19:51.1128537Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/71555/merge:refs/remotes/pull/71555/merge
---
2020-04-25T19:21:44.0533005Z  ---> cb2676f08729
2020-04-25T19:21:44.0533835Z Step 5/8 : ENV RUST_CONFIGURE_ARGS       --build=x86_64-unknown-linux-gnu       --llvm-root=/usr/lib/llvm-8       --enable-llvm-link-shared       --set rust.thin-lto-import-instr-limit=10
2020-04-25T19:21:44.0534488Z  ---> Using cache
2020-04-25T19:21:44.0534838Z  ---> df25ce111862
2020-04-25T19:21:44.0535847Z Step 6/8 : ENV SCRIPT python2.7 ../x.py test --exclude src/tools/tidy &&            python2.7 ../x.py test src/test/mir-opt --pass=build                                   --target=armv5te-unknown-linux-gnueabi &&            python2.7 ../x.py test src/tools/tidy
2020-04-25T19:21:44.0536985Z  ---> 599b9ac96b27
2020-04-25T19:21:44.0537209Z Step 7/8 : ENV NO_DEBUG_ASSERTIONS=1
2020-04-25T19:21:44.0537604Z  ---> Using cache
2020-04-25T19:21:44.0537955Z  ---> 091087e35a36
---
2020-04-25T19:21:44.1040122Z Looks like docker image is the same as before, not uploading
2020-04-25T19:21:51.0198492Z [CI_JOB_NAME=x86_64-gnu-llvm-8]
2020-04-25T19:21:51.0507574Z [CI_JOB_NAME=x86_64-gnu-llvm-8]
2020-04-25T19:21:51.0534422Z == clock drift check ==
2020-04-25T19:21:51.0544369Z   local time: Sat Apr 25 19:21:51 UTC 2020
2020-04-25T19:21:51.2186990Z   network time: Sat, 25 Apr 2020 19:21:51 GMT
2020-04-25T19:21:51.2212382Z Starting sccache server...
2020-04-25T19:21:51.2999153Z configure: processing command line
2020-04-25T19:21:51.2999992Z configure: 
2020-04-25T19:21:51.3001986Z configure: rust.dist-src        := False
---
2020-04-25T19:24:24.4178130Z    Compiling unicode-width v0.1.6
2020-04-25T19:24:24.5077908Z    Compiling getopts v0.2.21
2020-04-25T19:24:35.8514693Z    Compiling test v0.0.0 (/checkout/src/libtest)
2020-04-25T19:24:45.1886799Z     Finished release [optimized] target(s) in 1m 07s
2020-04-25T19:24:45.1893190Z {"reason":"build-finished","success":true}
2020-04-25T19:24:45.2136443Z Building stage0 compiler artifacts (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-04-25T19:24:45.7813906Z    Compiling cfg-if v0.1.10
2020-04-25T19:24:45.7814493Z    Compiling libc v0.2.69
2020-04-25T19:24:45.8278397Z    Compiling semver-parser v0.7.0
---
2020-04-25T19:27:34.5944432Z    Compiling rustc_feature v0.0.0 (/checkout/src/librustc_feature)
2020-04-25T19:27:36.1988233Z    Compiling fmt_macros v0.0.0 (/checkout/src/libfmt_macros)
2020-04-25T19:27:37.9120234Z    Compiling rustc_ast_pretty v0.0.0 (/checkout/src/librustc_ast_pretty)
2020-04-25T19:27:39.5056490Z    Compiling rustc_hir v0.0.0 (/checkout/src/librustc_hir)
2020-04-25T19:27:48.9850044Z    Compiling rustc_query_system v0.0.0 (/checkout/src/librustc_query_system)
2020-04-25T19:27:51.9741856Z    Compiling rustc_hir_pretty v0.0.0 (/checkout/src/librustc_hir_pretty)
2020-04-25T19:27:56.8235396Z    Compiling rustc_attr v0.0.0 (/checkout/src/librustc_attr)
2020-04-25T19:28:01.4387972Z    Compiling rustc_parse v0.0.0 (/checkout/src/librustc_parse)
2020-04-25T19:28:11.7767859Z    Compiling rustc_ast_lowering v0.0.0 (/checkout/src/librustc_ast_lowering)
---
2020-04-25T19:41:53.5112153Z    Compiling rustc_passes v0.0.0 (/checkout/src/librustc_passes)
2020-04-25T19:43:59.5824378Z    Compiling rustc_plugin_impl v0.0.0 (/checkout/src/librustc_plugin_impl)
2020-04-25T19:44:07.9176748Z    Compiling rustc_privacy v0.0.0 (/checkout/src/librustc_privacy)
2020-04-25T19:48:18.3288973Z    Compiling rustc-main v0.0.0 (/checkout/src/rustc)
2020-04-25T19:48:19.0215042Z {"reason":"build-finished","success":true}
2020-04-25T19:48:19.0711364Z Copying stage0 rustc from stage0 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
2020-04-25T19:48:19.0746945Z Assembling stage1 compiler (x86_64-unknown-linux-gnu)
2020-04-25T19:48:19.0772284Z Building stage1 std artifacts (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-04-25T19:48:19.4064777Z    Compiling cc v1.0.50
---
2020-04-25T19:49:13.4403163Z    Compiling unicode-width v0.1.6
2020-04-25T19:49:13.5475068Z    Compiling getopts v0.2.21
2020-04-25T19:49:26.6319893Z    Compiling test v0.0.0 (/checkout/src/libtest)
2020-04-25T19:49:37.0148067Z     Finished release [optimized] target(s) in 1m 17s
2020-04-25T19:49:37.0152924Z {"reason":"build-finished","success":true}
2020-04-25T19:49:37.0295897Z Building stage1 compiler artifacts (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-04-25T19:49:37.6606109Z    Compiling cfg-if v0.1.10
2020-04-25T19:49:37.6614063Z    Compiling libc v0.2.69
2020-04-25T19:49:37.7079114Z    Compiling semver-parser v0.7.0
---
2020-04-25T19:52:41.7347088Z    Compiling rustc_feature v0.0.0 (/checkout/src/librustc_feature)
2020-04-25T19:52:43.5538345Z    Compiling fmt_macros v0.0.0 (/checkout/src/libfmt_macros)
2020-04-25T19:52:45.5306883Z    Compiling rustc_ast_pretty v0.0.0 (/checkout/src/librustc_ast_pretty)
2020-04-25T19:52:46.9870619Z    Compiling rustc_hir v0.0.0 (/checkout/src/librustc_hir)
2020-04-25T19:52:57.2388086Z    Compiling rustc_query_system v0.0.0 (/checkout/src/librustc_query_system)
2020-04-25T19:53:01.0441851Z    Compiling rustc_hir_pretty v0.0.0 (/checkout/src/librustc_hir_pretty)
2020-04-25T19:53:06.1689743Z    Compiling rustc_attr v0.0.0 (/checkout/src/librustc_attr)
2020-04-25T19:53:11.0915077Z    Compiling rustc_parse v0.0.0 (/checkout/src/librustc_parse)
2020-04-25T19:53:20.8242479Z    Compiling rustc_ast_lowering v0.0.0 (/checkout/src/librustc_ast_lowering)
---
2020-04-25T20:10:01.8744155Z    Compiling rustc_plugin_impl v0.0.0 (/checkout/src/librustc_plugin_impl)
2020-04-25T20:10:10.5743766Z    Compiling rustc_privacy v0.0.0 (/checkout/src/librustc_privacy)
2020-04-25T20:14:41.9433419Z    Compiling rustc-main v0.0.0 (/checkout/src/rustc)
2020-04-25T20:14:42.6063641Z     Finished release [optimized] target(s) in 25m 05s
2020-04-25T20:14:42.6069156Z {"reason":"build-finished","success":true}
2020-04-25T20:14:42.6623683Z Assembling stage2 compiler (x86_64-unknown-linux-gnu)
2020-04-25T20:14:42.6636472Z Uplifting stage1 std (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-04-25T20:14:42.6637851Z Copying stage2 std from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
2020-04-25T20:14:42.6647229Z Building test helpers
---
2020-04-25T20:15:27.7931429Z    Compiling serde_derive v1.0.81
2020-04-25T20:15:57.2367861Z    Compiling serde_json v1.0.40
2020-04-25T20:15:58.8182148Z    Compiling rustfix v0.5.0
2020-04-25T20:16:02.3070295Z    Compiling compiletest v0.0.0 (/checkout/src/tools/compiletest)
2020-04-25T20:16:17.2203777Z {"reason":"build-finished","success":true}
2020-04-25T20:16:17.2544038Z Check compiletest suite=ui mode=ui (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-04-25T20:16:20.7611197Z 
2020-04-25T20:16:20.7612995Z running 9922 tests
2020-04-25T20:16:35.2405290Z .................................................................................................... 100/9922
---
2020-04-25T20:18:31.2610619Z .................................................................................................... 1700/9922
2020-04-25T20:18:35.7828782Z .................................................................................................... 1800/9922
2020-04-25T20:18:44.4982055Z .................................................................................................... 1900/9922
2020-04-25T20:18:53.0665923Z ......i............................................................................................. 2000/9922
2020-04-25T20:18:59.7189632Z ................................................................................................iiii 2100/9922
2020-04-25T20:19:14.3121415Z i................................................................................................... 2200/9922
2020-04-25T20:19:22.9666832Z .................................................................................................... 2400/9922
2020-04-25T20:19:25.3557365Z .................................................................................................... 2500/9922
2020-04-25T20:19:31.1888279Z .................................................................................................... 2600/9922
2020-04-25T20:19:50.3215488Z .................................................................................................... 2700/9922
---
2020-04-25T20:22:36.8181934Z .................................................................................................... 5100/9922
2020-04-25T20:22:44.1778968Z .................................................................................................... 5200/9922
2020-04-25T20:22:48.9018616Z ...................i................................................................................ 5300/9922
2020-04-25T20:22:58.9754384Z ..........i......................................................................................... 5400/9922
2020-04-25T20:23:04.6905635Z ..........ii.ii........i...i........................................................................ 5500/9922
2020-04-25T20:23:12.6657387Z .........................................................i.......................................... 5700/9922
2020-04-25T20:23:21.6771311Z ..........................................................................................ii........ 5800/9922
2020-04-25T20:23:28.5063084Z .............................i...................................................................... 5900/9922
2020-04-25T20:23:34.0503536Z .................................................................................................... 6000/9922
2020-04-25T20:23:34.0503536Z .................................................................................................... 6000/9922
2020-04-25T20:23:44.8330489Z .................................................................................................... 6100/9922
2020-04-25T20:23:55.3627472Z .......................ii....i.ii...........i....................................................... 6200/9922
2020-04-25T20:24:11.6781068Z .................................................................................................... 6400/9922
2020-04-25T20:24:18.6060422Z .................................................................................................... 6500/9922
2020-04-25T20:24:18.6060422Z .................................................................................................... 6500/9922
2020-04-25T20:24:33.6030175Z .....................................................i..ii.......................................... 6600/9922
2020-04-25T20:25:03.8575440Z .................................................................................................... 6800/9922
2020-04-25T20:25:06.9007907Z ......................................................i............................................. 6900/9922
2020-04-25T20:25:09.0280244Z .................................................................................................... 7000/9922
2020-04-25T20:25:11.1948202Z ................................................................................................i... 7100/9922
---
2020-04-25T20:26:53.2184586Z .................................................................................................... 7900/9922
2020-04-25T20:26:58.8503537Z .................................................................................................... 8000/9922
2020-04-25T20:27:05.4913102Z ...............................................................i.................................... 8100/9922
2020-04-25T20:27:15.8375821Z .................................................................................................... 8200/9922
2020-04-25T20:27:21.3114316Z ............iiiiii.iiiii.i.......................................................................... 8300/9922
2020-04-25T20:27:35.3364723Z .................................................................................................... 8500/9922
2020-04-25T20:27:41.5910532Z .................................................................................................... 8600/9922
2020-04-25T20:27:56.5722116Z .................................................................................................... 8700/9922
2020-04-25T20:28:03.5725402Z .................................................................................................... 8800/9922
---
2020-04-25T20:30:25.3070661Z s/tidy"]
2020-04-25T20:30:25.3267607Z Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-04-25T20:30:25.5702584Z 
2020-04-25T20:30:25.5703534Z running 186 tests
2020-04-25T20:30:28.8647387Z iiii......i.............ii.i..........i.............................i..i..................i....i.... 100/186
2020-04-25T20:30:31.6446924Z ........i.i.i...iii..iiiiiiiiiiiiiiii.......................iii...............ii......
2020-04-25T20:30:31.6452554Z 
2020-04-25T20:30:31.6452767Z  finished in 6.318
2020-04-25T20:30:31.6454054Z Suite("src/test/codegen-units") not skipped for "bootstrap::test::CodegenUnits" -- not in ["src/tools/tidy"]
2020-04-25T20:30:31.6652258Z Check compiletest suite=codegen-units mode=codegen-units (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
---
2020-04-25T20:30:33.9607945Z Suite("src/test/assembly") not skipped for "bootstrap::test::Assembly" -- not in ["src/tools/tidy"]
2020-04-25T20:30:33.9808131Z Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-04-25T20:30:34.1401509Z 
2020-04-25T20:30:34.1401846Z running 9 tests
2020-04-25T20:30:34.1403234Z iiiiiiiii
2020-04-25T20:30:34.1404200Z 
2020-04-25T20:30:34.1406928Z  finished in 0.159
2020-04-25T20:30:34.1412744Z Suite("src/test/incremental") not skipped for "bootstrap::test::Incremental" -- not in ["src/tools/tidy"]
2020-04-25T20:30:34.1617969Z Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
---
2020-04-25T20:30:56.4382934Z Suite("src/test/debuginfo") not skipped for "bootstrap::test::Debuginfo" -- not in ["src/tools/tidy"]
2020-04-25T20:30:56.4625412Z Check compiletest suite=debuginfo mode=debuginfo (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-04-25T20:30:56.6485351Z 
2020-04-25T20:30:56.6485682Z running 115 tests
2020-04-25T20:31:10.9398515Z iiiii..i.....i..i...i..i.i.i..i..i..ii....i.i....ii..........iiii.........i.....i..i.......ii.i.ii.. 100/115
2020-04-25T20:31:13.1817731Z ...iiii.....ii.
2020-04-25T20:31:13.1818863Z 
2020-04-25T20:31:13.1819000Z  finished in 16.339
2020-04-25T20:31:13.1819527Z Suite("src/test/ui-fulldeps") not skipped for "bootstrap::test::UiFullDeps" -- not in ["src/tools/tidy"]
2020-04-25T20:31:13.1820124Z Uplifting stage1 rustc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
---
2020-04-25T20:44:08.4295796Z 
2020-04-25T20:44:08.4296893Z    Doc-tests core
2020-04-25T20:44:13.9205624Z 
2020-04-25T20:44:13.9206468Z running 2499 tests
2020-04-25T20:44:23.1957113Z ......iiiii......................................................................................... 100/2499
2020-04-25T20:44:32.7701556Z ......................................................................................ii............ 200/2499
2020-04-25T20:44:55.6967939Z ......................i............................................................................. 400/2499
2020-04-25T20:45:06.7949904Z ............................................................................i..i..................ii 500/2499
2020-04-25T20:45:15.0433560Z ii.................................................................................................. 600/2499
2020-04-25T20:45:24.3767935Z .................................................................................................... 700/2499
---
2020-04-25T20:49:33.2098577Z 
2020-04-25T20:49:33.2098942Z running 1020 tests
2020-04-25T20:49:50.9008566Z i................................................................................................... 100/1020
2020-04-25T20:50:01.3818648Z .................................................................................................... 200/1020
2020-04-25T20:50:08.8991945Z ...................iii......i......i...i......i..................................................... 300/1020
2020-04-25T20:50:13.8454396Z .................................................................................................... 400/1020
2020-04-25T20:50:20.6190281Z ....................................................i....i......................................ii.. 500/1020
2020-04-25T20:50:33.4153365Z .................................................................................................... 700/1020
2020-04-25T20:50:33.4153365Z .................................................................................................... 700/1020
2020-04-25T20:50:40.4983416Z ..............................................iiii.................................................. 800/1020
2020-04-25T20:50:54.4043259Z .................................................................................................... 900/1020
2020-04-25T20:51:00.6083775Z ....................................................................iiii............................ 1000/1020
2020-04-25T20:51:01.8709905Z test result: ok. 1000 passed; 0 failed; 20 ignored; 0 measured; 0 filtered out
2020-04-25T20:51:01.8710211Z 
2020-04-25T20:51:01.8863046Z  finished in 166.084
2020-04-25T20:51:01.8868291Z Set({"src/libterm"}) not skipped for "bootstrap::test::Crate" -- not in ["src/tools/tidy"]
---
2020-04-25T20:51:48.3007800Z 
2020-04-25T20:51:48.3008257Z error[E0603]: struct `Ident` is private
2020-04-25T20:51:48.3008847Z   --> src/librustc_ast_pretty/pprust/tests.rs:29:31
2020-04-25T20:51:48.3009435Z    |
2020-04-25T20:51:48.3010178Z 29 |         let abba_ident = ast::Ident::from_str("abba");
2020-04-25T20:51:48.3011443Z    |
2020-04-25T20:51:48.3011904Z note: the struct `Ident` is defined here
2020-04-25T20:51:48.3012433Z   --> /checkout/src/librustc_ast/ast.rs:35:35
2020-04-25T20:51:48.3012853Z    |
2020-04-25T20:51:48.3012853Z    |
2020-04-25T20:51:48.3013662Z 35 | use rustc_span::symbol::{kw, sym, Ident, Symbol};
2020-04-25T20:51:48.3014317Z    |                                   ^^^^^
2020-04-25T20:51:48.3014549Z 
2020-04-25T20:51:48.3015091Z error[E0603]: struct `Ident` is private
2020-04-25T20:51:48.3015663Z   --> src/librustc_ast_pretty/pprust/tests.rs:44:26
2020-04-25T20:51:48.3016106Z    |
2020-04-25T20:51:48.3016743Z 44 |         let ident = ast::Ident::from_str("principal_skinner");
2020-04-25T20:51:48.3018152Z    |
2020-04-25T20:51:48.3018620Z note: the struct `Ident` is defined here
2020-04-25T20:51:48.3019147Z   --> /checkout/src/librustc_ast/ast.rs:35:35
2020-04-25T20:51:48.3019564Z    |
---
2020-04-25T20:51:48.7214556Z 
2020-04-25T20:51:48.7215199Z To learn more, run the command again with --verbose.
2020-04-25T20:51:48.7233087Z 
2020-04-25T20:51:48.7233515Z 
2020-04-25T20:51:48.7235218Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "test" "--target" "x86_64-unknown-linux-gnu" "-Zbinary-dep-depinfo" "-j" "2" "--release" "--locked" "--color" "always" "--features" " llvm" "--manifest-path" "/checkout/src/rustc/Cargo.toml" "-p" "rustc_ast_pretty" "--" "--quiet"
2020-04-25T20:51:48.7236312Z 
2020-04-25T20:51:48.7236424Z 
2020-04-25T20:51:48.7246638Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test --exclude src/tools/tidy
2020-04-25T20:51:48.7247225Z Build completed unsuccessfully in 1:28:12
2020-04-25T20:51:48.7247225Z Build completed unsuccessfully in 1:28:12
2020-04-25T20:51:48.7307567Z == clock drift check ==
2020-04-25T20:51:48.7327240Z   local time: Sat Apr 25 20:51:48 UTC 2020
2020-04-25T20:51:48.8996185Z   network time: Sat, 25 Apr 2020 20:51:48 GMT
2020-04-25T20:51:49.3108420Z 
2020-04-25T20:51:49.3108420Z 
2020-04-25T20:51:49.3148954Z ##[error]Bash exited with code '1'.
2020-04-25T20:51:49.3179902Z ##[section]Finishing: Run build
2020-04-25T20:51:49.3266070Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/71555/merge to s
2020-04-25T20:51:49.3271930Z Task         : Get sources
2020-04-25T20:51:49.3272290Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-04-25T20:51:49.3272643Z Version      : 1.0.0
2020-04-25T20:51:49.3272892Z Author       : Microsoft
2020-04-25T20:51:49.3272892Z Author       : Microsoft
2020-04-25T20:51:49.3273260Z Help         : [More Information](https://go.microsoft.com/fwlink/?LinkId=798199)
2020-04-25T20:51:49.3273678Z ==============================================================================
2020-04-25T20:51:49.7253333Z Cleaning any cached credential from repository: rust-lang/rust (GitHub)
2020-04-25T20:51:49.7301564Z ##[section]Finishing: Checkout rust-lang/rust@refs/pull/71555/merge to s
2020-04-25T20:51:49.7408107Z Cleaning up task key
2020-04-25T20:51:49.7409562Z Start cleaning up orphan processes.
2020-04-25T20:51:49.7634417Z Terminate orphan process: pid (3586) (python)
2020-04-25T20:51:49.7901751Z ##[section]Finishing: Finalize Job

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

bors · 2020-04-26T04:48:04Z

☔ The latest upstream changes (presumably #71566) made this pull request unmergeable. Please resolve the merge conflicts.

bors · 2020-04-28T08:32:11Z

☔ The latest upstream changes (presumably #71292) made this pull request unmergeable. Please resolve the merge conflicts.

cjgillot · 2020-04-28T10:55:45Z

Rebased.

bors · 2020-05-03T12:15:45Z

☔ The latest upstream changes (presumably #71828) made this pull request unmergeable. Please resolve the merge conflicts.

matthewjasper · 2020-05-08T16:44:21Z

@petrochenkov is your comment objecting to this change or just providing some background information?

I think this is an improvement, so r=me unless someone objects.

petrochenkov · 2020-05-08T20:04:11Z

@bors r=matthewjasper

bors · 2020-05-08T20:04:12Z

📌 Commit 32507d6 has been approved by matthewjasper

@ghost

Rollup of 5 pull requests Successful merges: - rust-lang#69406 (upgrade chalk and use chalk-solve/chalk-ir/chalk-rust-ir) - rust-lang#71185 (Move tests from `test/run-fail` to UI) - rust-lang#71234 (rustllvm: Use .init_array rather than .ctors) - rust-lang#71508 (Simplify the `tcx.alloc_map` API) - rust-lang#71555 (Remove ast::{Ident, Name} reexports.) Failed merges: r? @ghost

Remove ast::{Ident, Name} reexports. The reexport of `Symbol` into `Name` confused me.

rust-highfive assigned matthewjasper Apr 25, 2020

cjgillot force-pushed the nameless branch from 87fdcac to c85d989 Compare April 25, 2020 16:17

bors added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Apr 26, 2020

cjgillot force-pushed the nameless branch from 864eeaa to ad0124e Compare April 26, 2020 16:12

cjgillot force-pushed the nameless branch from ad0124e to 1399ccc Compare April 28, 2020 09:58

cjgillot added 3 commits May 8, 2020 13:13

Remove ast::{Ident, Name} reexports.

d4e143e

Fix clippy.

7bf21d4

Fix tests

32507d6

cjgillot force-pushed the nameless branch from 1399ccc to 32507d6 Compare May 8, 2020 11:57

petrochenkov self-assigned this May 8, 2020

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 8, 2020

petrochenkov removed their assignment May 8, 2020

RalfJung mentioned this pull request May 9, 2020

Rollup of 5 pull requests #72041

Merged

bors merged commit 366c178 into rust-lang:master May 9, 2020

cjgillot deleted the nameless branch May 10, 2020 12:14

flip1995 pushed a commit to flip1995/rust that referenced this pull request May 15, 2020

Rollup merge of rust-lang#71555 - cjgillot:nameless, r=matthewjasper

51158cc

Remove ast::{Ident, Name} reexports. The reexport of `Symbol` into `Name` confused me.

CAD97 mentioned this pull request May 15, 2020

rustc 658 rust-lang/rustfmt#4174

Closed

This was referenced May 15, 2020

Rustup to rustc-ap 658 rust-lang/rustfmt#4177

Closed

rustfmt no longer builds after rust-lang/rust#69659 #72232

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove ast::{Ident, Name} reexports. #71555

Remove ast::{Ident, Name} reexports. #71555

cjgillot commented Apr 25, 2020

petrochenkov commented Apr 25, 2020

rust-highfive commented Apr 25, 2020

rust-highfive commented Apr 25, 2020

bors commented Apr 26, 2020

bors commented Apr 28, 2020

cjgillot commented Apr 28, 2020

bors commented May 3, 2020

matthewjasper commented May 8, 2020

petrochenkov commented May 8, 2020

bors commented May 8, 2020

Remove ast::{Ident, Name} reexports. #71555

Remove ast::{Ident, Name} reexports. #71555

Conversation

cjgillot commented Apr 25, 2020

petrochenkov commented Apr 25, 2020

rust-highfive commented Apr 25, 2020

rust-highfive commented Apr 25, 2020

bors commented Apr 26, 2020

bors commented Apr 28, 2020

cjgillot commented Apr 28, 2020

bors commented May 3, 2020

matthewjasper commented May 8, 2020

petrochenkov commented May 8, 2020

bors commented May 8, 2020