Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix exceeding bitshifts not emitting for assoc. consts (properly this time, I swear!) #71663

Merged
merged 19 commits into from
May 3, 2020
Merged

Fix exceeding bitshifts not emitting for assoc. consts (properly this time, I swear!) #71663

merged 19 commits into from
May 3, 2020

Commits on May 1, 2020

  1. Don't duplicate macro for optional arg.

    @jumbatm
    jumbatm committed May 1, 2020
    Configuration menu
    Copy the full SHA
    14d90de View commit details
    Browse the repository at this point in the history

  2. Add try_validation_pat.

    @jumbatm
    jumbatm committed May 1, 2020
    Configuration menu
    Copy the full SHA
    326d38f View commit details
    Browse the repository at this point in the history

  3. Don't duplicate body of try_validation.

    @jumbatm
    jumbatm committed May 1, 2020
    Configuration menu
    Copy the full SHA
    e66e37c View commit details
    Browse the repository at this point in the history

  4. Don't fail for UndefinedBehaviourInfo in validation.

    @jumbatm
    jumbatm committed May 1, 2020
    Configuration menu
    Copy the full SHA
    bc7b714 View commit details
    Browse the repository at this point in the history

  5. Throw validation failure for InvalidUndefBytes.

    @jumbatm
    jumbatm committed May 1, 2020
    Configuration menu
    Copy the full SHA
    6b413d9 View commit details
    Browse the repository at this point in the history

  6. Partially unrevert rust-lang#70566. 

    This partially reverts commit 4b5b6cb,
reversing some changes made to 62b3624.
    @jumbatm
    jumbatm committed May 1, 2020
    Configuration menu
    Copy the full SHA
    2887d79 View commit details
    Browse the repository at this point in the history

  7. Update stderrs.

    @jumbatm
    jumbatm committed May 1, 2020
    Configuration menu
    Copy the full SHA
    5b1d600 View commit details
    Browse the repository at this point in the history

  8. Apply suggestions from code review 

    Co-Authored-By: Ralf Jung <post@ralfj.de>
Co-Authored-By: Oliver Scherer <github35764891676564198441@oli-obk.de>
    @jumbatm @RalfJung @oli-obk
    3 people committed May 1, 2020
    Configuration menu
    Copy the full SHA
    894a83d View commit details
    Browse the repository at this point in the history

  9. Add FIXME about replacing all usages of try_validation.

    @jumbatm
    jumbatm committed May 1, 2020
    Configuration menu
    Copy the full SHA
    656ab76 View commit details
    Browse the repository at this point in the history

  10. Match kind in try_validation_pat!. 

    Avoids having to repeat InterpErrorInfo { .. }
    @jumbatm
    jumbatm committed May 1, 2020
    Configuration menu
    Copy the full SHA
    eca1478 View commit details
    Browse the repository at this point in the history

  11. Allow unreachable_patterns instead of using if true

    @jumbatm
    jumbatm committed May 1, 2020
    Configuration menu
    Copy the full SHA
    9c898d6 View commit details
    Browse the repository at this point in the history

  12. Fix comment to reflect error handling behaviour.

    @jumbatm
    jumbatm committed May 1, 2020
    Configuration menu
    Copy the full SHA
    9459b37 View commit details
    Browse the repository at this point in the history

  13. Apply suggestions for try_validation_pat!.

    @jumbatm
    jumbatm committed May 1, 2020
    Configuration menu
    Copy the full SHA
    cb96d41 View commit details
    Browse the repository at this point in the history

  14. Update try_validation_pat! doc comment.

    @jumbatm
    jumbatm committed May 1, 2020
    Configuration menu
    Copy the full SHA
    425a99f View commit details
    Browse the repository at this point in the history

  15. Wrap try_validation_pat! args in format_args!

    @jumbatm
    jumbatm committed May 1, 2020
    Configuration menu
    Copy the full SHA
    65c36f6 View commit details
    Browse the repository at this point in the history

  16. Also make expected param wrapped in format_args.

    @jumbatm
    jumbatm committed May 1, 2020
    Configuration menu
    Copy the full SHA
    f1d778f View commit details
    Browse the repository at this point in the history

  17. Expect at least one expr for p, what_fmt and expected_fmt.

    @jumbatm
    jumbatm committed May 1, 2020
    Configuration menu
    Copy the full SHA
    8175c4c View commit details
    Browse the repository at this point in the history

  18. Manually format macro to not go over text width.

    @jumbatm
    jumbatm committed May 1, 2020
    Configuration menu
    Copy the full SHA
    8304739 View commit details
    Browse the repository at this point in the history

  19. Note that try_validation_pat can take a format str directly.

    @jumbatm
    jumbatm committed May 1, 2020
    Configuration menu
    Copy the full SHA
    bd18ad4 View commit details
    Browse the repository at this point in the history