Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect errors caused by async block in 2015 edition #71783

Merged
merged 1 commit into from
May 8, 2020
Merged

Detect errors caused by async block in 2015 edition #71783

merged 1 commit into from
May 8, 2020

Conversation

estebank
Copy link
Contributor

@estebank estebank commented May 2, 2020

Fix #67204.

@rust-highfive
Copy link
Collaborator

r? @cramertj

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 2, 2020
@estebank
Copy link
Contributor Author

estebank commented May 2, 2020

r? @tmandry

@rust-highfive rust-highfive assigned tmandry and unassigned cramertj May 2, 2020
@estebank estebank force-pushed the async-block-2015 branch from a7ea919 to 964c214 Compare May 2, 2020 02:08
@tmandry
Copy link
Member

tmandry commented May 5, 2020

Looks good, thanks!! r=me after nit.

@estebank estebank force-pushed the async-block-2015 branch from 964c214 to 3cf5569 Compare May 6, 2020 02:58
@estebank
Copy link
Contributor Author

estebank commented May 6, 2020

@bors r=tmandry

@bors
Copy link
Contributor

bors commented May 6, 2020

📌 Commit 3cf5569 has been approved by tmandry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 6, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request May 7, 2020
@Dylan-DPC
Rollup merge of rust-lang#71783 - estebank:async-block-2015, r=tmandry
931f099 
Detect errors caused by `async` block in 2015 edition

Fix rust-lang#67204.
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request May 7, 2020
Closed
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request May 7, 2020
@Dylan-DPC
Rollup merge of rust-lang#71783 - estebank:async-block-2015, r=tmandry
180c4fd 
Detect errors caused by `async` block in 2015 edition

Fix rust-lang#67204.
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request May 7, 2020
Closed
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request May 7, 2020
Merged
@bors
Copy link
Contributor

bors commented May 7, 2020

⌛ Testing commit 3cf5569 with merge 869761e5f3a94a4004b5b631001030dc3cbef605...

@bors
Copy link
Contributor

bors commented May 7, 2020

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 7, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request May 8, 2020
@bors
Auto merge of rust-lang#71992 - Dylan-DPC:rollup-29qjvpe, r=Dylan-DPC
29630ce 
Rollup of 5 pull requests

Successful merges:

 - rust-lang#70733 (Add Arc::{incr,decr}_strong_count)
 - rust-lang#71598 (improve Drop documentation)
 - rust-lang#71783 (Detect errors caused by `async` block in 2015 edition)
 - rust-lang#71903 (reword "possible candidate" import suggestion)
 - rust-lang#71960 (Fix E0284 to not use incorrect wording)

Failed merges:

r? @ghost
@bors bors merged commit f3691ac into rust-lang:master May 8, 2020
@goffrie goffrie mentioned this pull request Jul 6, 2020
Closed
@estebank estebank deleted the async-block-2015 branch November 9, 2023 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmandry tmandry tmandry left review comments

Assignees

@tmandry tmandry

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Explain editions when trying to use async block in 2015 edition
5 participants
@estebank @rust-highfive @tmandry @bors @cramertj