Fix hang in lexical_region_resolve #72087

matthewjasper · 2020-05-10T20:12:51Z

Regionck was stuck in a loop where a region value was changing between two equal regions.

Closes #72051

rust-highfive · 2020-05-10T20:12:54Z

r? @petrochenkov

(rust_highfive has picked a reviewer for you, use r? to override)

matthewjasper · 2020-05-10T20:13:24Z

r? @nikomatsakis

rust-highfive · 2020-05-10T21:27:58Z

The job x86_64-gnu-llvm-8 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

##[section]Starting: Linux x86_64-gnu-llvm-8
##[section]Starting: Initialize job
Agent name: 'Azure Pipelines 25'
Agent machine name: 'fv-az578'
Current agent version: '2.168.2'
##[group]Operating System
16.04.6
LTS
LTS
##[endgroup]
##[group]Virtual Environment
Environment: ubuntu-16.04
Version: 20200430.2
Included Software: https://github.com/actions/virtual-environments/blob/ubuntu16/20200430.2/images/linux/Ubuntu1604-README.md
##[endgroup]
Agent running as: 'vsts'
Prepare build directory.
Set build variables.
Download all required tasks.
Download all required tasks.
Downloading task: Bash (3.163.1)
Checking job knob settings.
   Knob: AgentToolsDirectory = /opt/hostedtoolcache Source: ${AGENT_TOOLSDIRECTORY} 
   Knob: AgentPerflog = /home/vsts/perflog Source: ${VSTS_AGENT_PERFLOG} 
Start tracking orphan processes.
##[section]Finishing: Initialize job
##[section]Starting: Configure Job Name
==============================================================================
---
========================== Starting Command Output ===========================
[command]/bin/bash --noprofile --norc /home/vsts/work/_temp/66829910-197f-4d82-8cb3-9e6bcf866ae7.sh

##[section]Finishing: Disable git automatic line ending conversion
##[section]Starting: Checkout rust-lang/rust@refs/pull/72087/merge to s
Task         : Get sources
Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
Version      : 1.0.0
Author       : Microsoft
---
##[command]git remote add origin https://github.com/rust-lang/rust
##[command]git config gc.auto 0
##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
##[command]git config --get-all http.proxy
##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/72087/merge:refs/remotes/pull/72087/merge
---
 ---> cb2676f08729
Step 5/8 : ENV RUST_CONFIGURE_ARGS       --build=x86_64-unknown-linux-gnu       --llvm-root=/usr/lib/llvm-8       --enable-llvm-link-shared       --set rust.thin-lto-import-instr-limit=10
 ---> Using cache
 ---> df25ce111862
Step 6/8 : ENV SCRIPT python2.7 ../x.py test --exclude src/tools/tidy &&            python2.7 ../x.py test src/test/mir-opt --pass=build                                   --target=armv5te-unknown-linux-gnueabi &&            python2.7 ../x.py test src/tools/tidy
 ---> 599b9ac96b27
Step 7/8 : ENV NO_DEBUG_ASSERTIONS=1
 ---> Using cache
 ---> 091087e35a36
---
   Compiling fmt_macros v0.0.0 (/checkout/src/libfmt_macros)
   Compiling chalk-rust-ir v0.10.0
   Compiling rustc_ast_pretty v0.0.0 (/checkout/src/librustc_ast_pretty)
   Compiling rustc_hir v0.0.0 (/checkout/src/librustc_hir)
   Compiling rustc_query_system v0.0.0 (/checkout/src/librustc_query_system)
   Compiling chalk-solve v0.10.0
   Compiling rustc_hir_pretty v0.0.0 (/checkout/src/librustc_hir_pretty)
   Compiling rustc_parse v0.0.0 (/checkout/src/librustc_parse)
   Compiling rustc_ast_lowering v0.0.0 (/checkout/src/librustc_ast_lowering)
---
   Compiling fmt_macros v0.0.0 (/checkout/src/libfmt_macros)
   Compiling chalk-ir v0.10.0
   Compiling rustc_ast_pretty v0.0.0 (/checkout/src/librustc_ast_pretty)
   Compiling rustc_hir v0.0.0 (/checkout/src/librustc_hir)
   Compiling rustc_query_system v0.0.0 (/checkout/src/librustc_query_system)
   Compiling chalk-rust-ir v0.10.0
   Compiling rustc_parse v0.0.0 (/checkout/src/librustc_parse)
   Compiling rustc_hir_pretty v0.0.0 (/checkout/src/librustc_hir_pretty)
   Compiling rustc_ast_lowering v0.0.0 (/checkout/src/librustc_ast_lowering)
---
.....................................................i.............................................. 1800/10161
.................................................................................................... 1900/10161
.......................................................................i..i......................... 2000/10161
.................................................................................................... 2100/10161
.............................................................iiiii.................................. 2200/10161
.................................................................................................... 2400/10161
.................................................................................................... 2500/10161
.................................................................................................... 2600/10161
.................................................................................................... 2700/10161
---
.................................................................................................... 5200/10161
.................................................................................................... 5300/10161
........................i........................................................................... 5400/10161
.................i.................................................................................. 5500/10161
........................ii.ii........i...i.......................................................... 5600/10161
.........................................................................i.......................... 5800/10161
.................................................................................................... 5900/10161
....................ii.....................................i........................................ 6000/10161
.................................................................................................... 6100/10161
.................................................................................................... 6100/10161
.................................................................................................... 6200/10161
.................................................................................ii...i..ii......... 6300/10161
.................................................................................................... 6500/10161
.................................................................................................... 6600/10161
.................................................................................................... 6700/10161
.................................................................................................... 6700/10161
..............i..ii................................................................................. 6800/10161
.................................................................................................... 7000/10161
....................................................................i............................... 7100/10161
.................................................................................................... 7200/10161
.................................................................................................... 7300/10161
---
.................................................................................................... 8100/10161
.................................................................................................... 8200/10161
.....................................................................................i.............. 8300/10161
.................................................................................................... 8400/10161
......................................iiiiii.iiiii.i................................................ 8500/10161
.................................................................................................... 8700/10161
.................................................................................................... 8800/10161
.................................................................................................... 8900/10161
.................................................................................................... 9000/10161
---
---- [ui] ui/regions/issue-72051-member-region-hang.rs stdout ----

error: test compilation failed although it shouldn't!
status: exit code: 1
command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/regions/issue-72051-member-region-hang.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/regions/issue-72051-member-region-hang" "-A" "unused" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--edition= 2018" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/regions/issue-72051-member-region-hang/auxiliary"
------------------------------------------

------------------------------------------
stderr:
stderr:
------------------------------------------
error: argument for `--edition` must be one of: 2015|2018. (instead was ` 2018`)

------------------------------------------


---
thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:348:22
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace


command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-8/bin/FileCheck" "--nodejs" "/usr/bin/node" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "8.0.0" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"


failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test --exclude src/tools/tidy
Build completed unsuccessfully in 1:08:31
Build completed unsuccessfully in 1:08:31
== clock drift check ==
  local time: Sun May 10 21:27:53 UTC 2020
  network time: Sun, 10 May 2020 21:27:53 GMT
== end clock drift check ==

##[error]Bash exited with code '1'.
##[section]Finishing: Run build
##[section]Starting: Checkout rust-lang/rust@refs/pull/72087/merge to s
Task         : Get sources
Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
Version      : 1.0.0
Author       : Microsoft
Author       : Microsoft
Help         : [More Information](https://go.microsoft.com/fwlink/?LinkId=798199)
==============================================================================
Cleaning any cached credential from repository: rust-lang/rust (GitHub)
##[section]Finishing: Checkout rust-lang/rust@refs/pull/72087/merge to s
Cleaning up task key
Start cleaning up orphan processes.
Terminate orphan process: pid (4302) (python)
##[section]Finishing: Finalize Job

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

src/librustc_infer/infer/lexical_region_resolve/mod.rs

nikomatsakis · 2020-05-11T14:21:48Z

I'm happy to r+, but I'd like to improve the understand the issue more deeply and then improve the comment a bit so we can remember it in the future. =)

nikomatsakis · 2020-05-13T16:25:40Z

@bors r+

bors · 2020-05-13T16:25:42Z

📌 Commit e7b0204 has been approved by nikomatsakis

spastorino · 2020-05-13T19:24:18Z

Adding T-compiler label so we process the beta nomination.

…matsakis Fix hang in lexical_region_resolve Regionck was stuck in a loop where a region value was changing between two equal regions. Closes rust-lang#72051

pnkfelix · 2020-05-14T15:15:26Z

unilaterally accepting for beta-backport.

@ghost

Rollup of 8 pull requests Successful merges: - rust-lang#71910 (Fix unused_parens false positive when using binary operations) - rust-lang#72087 (Fix hang in lexical_region_resolve) - rust-lang#72126 (Change `WorkProduct::saved_files` to an `Option`.) - rust-lang#72127 (add long error explanation for E0228) - rust-lang#72141 (Warn against thread::sleep in async fn) - rust-lang#72170 (use `require_lang_item` over `unwrap`.) - rust-lang#72191 (Clean up E0589 explanation) - rust-lang#72194 (Don't ICE on missing `Unsize` impl) Failed merges: r? @ghost

[beta] Rollup backports This includes: * Fail if I/O error occurs during testing rust-lang#72089 * Fix hang in lexical_region_resolve rust-lang#72087 * Fix E0284 to not use incorrect wording rust-lang#71960 * Bump pulldown-cmark rust-lang#71682

rust-highfive assigned petrochenkov May 10, 2020

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 10, 2020

matthewjasper added the beta-nominated Nominated for backporting to the compiler in the beta channel. label May 10, 2020

rust-highfive assigned nikomatsakis and unassigned petrochenkov May 10, 2020

nikomatsakis approved these changes May 11, 2020

View reviewed changes

src/librustc_infer/infer/lexical_region_resolve/mod.rs Outdated Show resolved Hide resolved

matthewjasper force-pushed the regionck-hang branch 2 times, most recently from 76cb078 to c5eee55 Compare May 11, 2020 19:34

Fix hang in lexical_region_resolve

e7b0204

matthewjasper force-pushed the regionck-hang branch from c5eee55 to e7b0204 Compare May 11, 2020 20:05

nikomatsakis approved these changes May 13, 2020

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 13, 2020

spastorino added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label May 13, 2020

Dylan-DPC-zz mentioned this pull request May 13, 2020

Rollup of 9 pull requests #72182

Closed

pnkfelix added the beta-accepted Accepted for backporting to the compiler in the beta channel. label May 14, 2020

Dylan-DPC-zz mentioned this pull request May 14, 2020

Rollup of 8 pull requests #72202

Merged

bors merged commit 2e65f7b into rust-lang:master May 14, 2020

matthewjasper deleted the regionck-hang branch May 15, 2020 06:24

Elinvynia mentioned this pull request May 22, 2020

[beta] Rollup backports #72468

Merged

Mark-Simulacrum removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label May 22, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix hang in lexical_region_resolve #72087

Fix hang in lexical_region_resolve #72087

matthewjasper commented May 10, 2020

rust-highfive commented May 10, 2020

matthewjasper commented May 10, 2020

rust-highfive commented May 10, 2020

nikomatsakis commented May 11, 2020

nikomatsakis commented May 13, 2020

bors commented May 13, 2020

spastorino commented May 13, 2020

pnkfelix commented May 14, 2020

Fix hang in lexical_region_resolve #72087

Fix hang in lexical_region_resolve #72087

Conversation

matthewjasper commented May 10, 2020

rust-highfive commented May 10, 2020

matthewjasper commented May 10, 2020

rust-highfive commented May 10, 2020

nikomatsakis commented May 11, 2020

nikomatsakis commented May 13, 2020

bors commented May 13, 2020

spastorino commented May 13, 2020

pnkfelix commented May 14, 2020