Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't type_of on trait assoc ty without default #72149

Merged
merged 1 commit into from
May 22, 2020

Conversation

estebank
Copy link
Contributor

Fix #72076.

@rust-highfive
Copy link
Collaborator

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 12, 2020
@Elinvynia Elinvynia added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 20, 2020
@eddyb
Copy link
Member

eddyb commented May 20, 2020

@bors r+

@bors
Copy link
Contributor

bors commented May 20, 2020

📌 Commit a3f30bb has been approved by eddyb

@bors
Copy link
Contributor

bors commented May 20, 2020

🌲 The tree is currently closed for pull requests below priority 9000, this pull request will be tested once the tree is reopened

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 20, 2020
RalfJung added a commit to RalfJung/rust that referenced this pull request May 21, 2020
Don't `type_of` on trait assoc ty without default

Fix rust-lang#72076.
RalfJung added a commit to RalfJung/rust that referenced this pull request May 21, 2020
Don't `type_of` on trait assoc ty without default

Fix rust-lang#72076.
This was referenced May 21, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request May 21, 2020
Rollup of 7 pull requests

Successful merges:

 - rust-lang#72055 (Intern predicates)
 - rust-lang#72149 (Don't `type_of` on trait assoc ty without default)
 - rust-lang#72347 (Make intra-link resolve links for both trait and impl items)
 - rust-lang#72350 (Improve documentation of `slice::from_raw_parts`)
 - rust-lang#72382 (Show default values for debug-assertions & debug-assertions-std)
 - rust-lang#72421 (Fix anchor display when hovering impl)
 - rust-lang#72425 (fix discriminant_value sign extension)

Failed merges:

r? @ghost
@bors bors merged commit dc65fd4 into rust-lang:master May 22, 2020
@estebank estebank deleted the icemation branch November 9, 2023 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ICE: associated type missing default with default impl
5 participants