Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix leaks from panics in drops #72152

Closed
wants to merge 2 commits into from
Closed

Fix leaks from panics in drops #72152

wants to merge 2 commits into from

Conversation

matthewjasper
Copy link
Contributor

Opening to check perf

Closes #47949

r? @ghost

@matthewjasper
Copy link
Contributor Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion

@bors
Copy link
Contributor

bors commented May 12, 2020

⌛ Trying commit a7b304b with merge 56112e7ba69edcd36b8bdb3d232e7fdc6910978c...

@bors
Copy link
Contributor

bors commented May 12, 2020

☀️ Try build successful - checks-actions, checks-azure
Build commit: 56112e7ba69edcd36b8bdb3d232e7fdc6910978c (56112e7ba69edcd36b8bdb3d232e7fdc6910978c)

@rust-timer
Copy link
Collaborator

Queued 56112e7ba69edcd36b8bdb3d232e7fdc6910978c with parent 769d12e, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit 56112e7ba69edcd36b8bdb3d232e7fdc6910978c, comparison URL.

@matthewjasper
Copy link
Contributor Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion

@bors
Copy link
Contributor

bors commented May 13, 2020

⌛ Trying commit 0ce2ce1 with merge 0037846e83159df1e4252cbffacce9df477f0fdf...

@bors
Copy link
Contributor

bors commented May 13, 2020

☀️ Try build successful - checks-actions, checks-azure
Build commit: 0037846e83159df1e4252cbffacce9df477f0fdf (0037846e83159df1e4252cbffacce9df477f0fdf)

@rust-timer
Copy link
Collaborator

Queued 0037846e83159df1e4252cbffacce9df477f0fdf with parent 75e1463, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit 0037846e83159df1e4252cbffacce9df477f0fdf, comparison URL.

@crlf0710 crlf0710 added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label May 22, 2020
@crlf0710 crlf0710 added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 30, 2020
@JohnCSimon JohnCSimon added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 6, 2020
@matthewjasper matthewjasper mentioned this pull request Oct 10, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Panics in destructors can cause the return value to be leaked
5 participants
@matthewjasper @rust-timer @bors @crlf0710 @JohnCSimon