Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[const-prop] Don't replace Rvalues that are already constants #72220

Merged
merged 1 commit into from
May 16, 2020

Conversation

wesleywiser
Copy link
Member

@wesleywiser wesleywiser commented May 14, 2020

This cleans up a few mir-opt tests which have slight changes to spans for consts as a result of replacing them with new Rvalues.

@wesleywiser
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion

@bors
Copy link
Contributor

bors commented May 15, 2020

⌛ Trying commit e84b379 with merge 2e6f8f3453482faa1008713333e7b4eff7fb0d4a...

@bors
Copy link
Contributor

bors commented May 15, 2020

☀️ Try build successful - checks-azure
Build commit: 2e6f8f3453482faa1008713333e7b4eff7fb0d4a (2e6f8f3453482faa1008713333e7b4eff7fb0d4a)

@rust-timer
Copy link
Collaborator

Queued 2e6f8f3453482faa1008713333e7b4eff7fb0d4a with parent a74d186, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit 2e6f8f3453482faa1008713333e7b4eff7fb0d4a, comparison URL.

@wesleywiser
Copy link
Member Author

r? @oli-obk

@wesleywiser
Copy link
Member Author

@bors rollup

(Perf neutral)

@oli-obk
Copy link
Contributor

oli-obk commented May 15, 2020

@bors r+

@bors
Copy link
Contributor

bors commented May 15, 2020

📌 Commit e84b379 has been approved by oli-obk

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label May 15, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request May 15, 2020
… r=oli-obk

[const-prop] Don't replace Rvalues that are already constants

This cleans up a few mir-opt tests which have slight changes to spans for `consts` as a result of replacing them with new Rvalues.
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request May 15, 2020
… r=oli-obk

[const-prop] Don't replace Rvalues that are already constants

This cleans up a few mir-opt tests which have slight changes to spans for `consts` as a result of replacing them with new Rvalues.
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request May 15, 2020
… r=oli-obk

[const-prop] Don't replace Rvalues that are already constants

This cleans up a few mir-opt tests which have slight changes to spans for `consts` as a result of replacing them with new Rvalues.
bors added a commit to rust-lang-ci/rust that referenced this pull request May 16, 2020
Rollup of 9 pull requests

Successful merges:

 - rust-lang#71662 (Implement FromStr for OsString)
 - rust-lang#71677 (Add explicit references to the BuildHasher trait)
 - rust-lang#71724 (Doc alias improvements)
 - rust-lang#71948 (Suggest to await future before ? operator)
 - rust-lang#72090 (rustc_driver: factor out computing the exit code)
 - rust-lang#72206 (Cleanup stale 'FIXME(rust-lang#64197)')
 - rust-lang#72218 (make sure even unleashed miri does not do pointer stuff)
 - rust-lang#72220 ([const-prop] Don't replace Rvalues that are already constants)
 - rust-lang#72224 (doc: add links to rotate_(left|right))

Failed merges:

r? @ghost
@bors bors merged commit 941dfb9 into rust-lang:master May 16, 2020
wesleywiser added a commit to oli-obk/rust that referenced this pull request May 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants