Rollup of 6 pull requests #72378
Merged
Rollup of 6 pull requests #72378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g an error. This way the hir is "valid" and we can remove one more call to `opt_node_id_to_hir_id` but an error is still emitted. This is another partial fix for rust-lang#71104
`fold` is currently implemented via `try_fold`, but implementing it directly results in slightly less LLVM IR being generated, speeding up compilation of some benchmarks. (And likewise for `rfold`.) The commit adds `fold` implementations to all the iterators that lack one but do have a `try_fold` implementation. Most of these just call the `try_fold` implementation directly.
Many default iterator methods use `try_fold` or `fold`, and these ones can too.
This was supposed to land as part of rust-lang#72227. (I wish `git push` would abort when you have uncommited changes.)
Suggest fixes and add error recovery for `use foo::self` Fixes rust-lang#63741. I have implemented 2 suggestions on how to fix a `use foo::self` import, however I feel like showing them both might be too verbose. Additionally, I have also implemented error recovery as [menitoned](rust-lang#63741 (comment)) by @comex. I believe r? @estebank deals with diagnostics.
Make `fold` standalone. `fold` is currently implemented via `try_fold`, but implementing it directly results in slightly less LLVM IR being generated, speeding up compilation of some benchmarks. r? @cuviper
…static-morse Continue lowering for unsupported async generator instead of returning an error. This way the hir is "valid" and we can remove one more call to `opt_node_id_to_hir_id` but an error is still emitted. This is another partial fix for rust-lang#71104 r? @eddyb
…king_issue, r=shepmaster split_inclusive: add tracking issue number (72360) Adds tracking issue number ( rust-lang#72360 ) to the unstable feature attributes.
…ulacrum Remove unused dependencies Remove some unused dependencies found while while working on rust-lang#72342.
…owup, r=Amanieu Adjust the zero check in `RawVec::grow`. This was supposed to land as part of rust-lang#72227. (I wish `git push` would abort when you have uncommited changes.) r? @Amanieu
|
@bors r+ rollup=never p=6 |
|
📌 Commit 51f80b7 has been approved by |
|
🌲 The tree is currently closed for pull requests below priority 9000, this pull request will be tested once the tree is reopened |
bors
added
the
S-waiting-on-bors
|
@bors treeclosed- |
|
☀️ Test successful - checks-azure |
This was referenced May 20, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
use foo::self#71863 (Suggest fixes and add error recovery foruse foo::self)foldstandalone. #72139 (Makefoldstandalone.)RawVec::grow. #72366 (Adjust the zero check inRawVec::grow.)Failed merges:
r? @ghost