Builtin bounds for closures and traits #7248
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hlight the mod path in "use module;" properly.
|
Reading. |
| @@ -360,7 +360,7 @@ fn visit_expr(expr: @ast::expr, (rcx, v): (@mut Rcx, rvt)) { | |||
| // explaining how it goes about doing that. | |||
| let target_ty = rcx.resolve_node_type(expr.id); | |||
| match ty::get(target_ty).sty { | |||
| ty::ty_trait(_, _, ty::RegionTraitStore(trait_region), _) => { | |||
| ty::ty_trait(_, _, ty::RegionTraitStore(trait_region), _, _) => { | |||
There was a problem hiding this comment.
In reality, what should happen here is that we should check the region bound no matter the store, and also check the region from the store as we do now. This is what causes #5723, because for an @Object or ~Object we never check any region bounds at all.
There was a problem hiding this comment.
It might be that this fix should wait for another PR though since it will implicate the I/O library a bit I guess.
There was a problem hiding this comment.
I'm already having to change the way with_bytes_reader is "implicated" in some more recent commits. I've made it use unsafe transmute and tagged it with a bunch of fixmes saying it should use an &Trait instead.
|
the extra commit just fixes a macro test |
bors
added a commit
that referenced
this pull request
Jun 23, 2013
Fixed a merge conflict, some tests, some bitrotting, etc., from #7248.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is pretty much all I can do before a snapshot.
The next step is to change the way boxed traits kind-check, which will involve lifting one restriction in
kind.rsand imposing several others intype_contents. To do that I will need to actually add bounds to traits in unrelated code, which requires them to parse to begin with, which requires a snapshot.r? @nikomatsakis @pcwalton