rustc_session: Cleanup session creation #72669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -174,6 +174,10 @@ impl ParseSess { | |||
| &self.source_map | |||
| } | |||
|
|
|||
| pub fn clone_source_map(&self) -> Lrc<SourceMap> { | |||
There was a problem hiding this comment.
Hm, should we avoid the clone_ here since it's really cheap to clone it (since it's just an Arc)?
Alternatively maybe the previously existing method can be made to return &Lrc<SourceMap> and then we could clone that in callers.
There was a problem hiding this comment.
This is only used once from rustdoc, source map doesn't generally need cloning.
Perhaps we'll be able to replace Lrc<SourceMap> with just SourceMap in the future.
So I'd rather keep this method explicit / visible for now.
|
@bors r=Mark-Simulacrum |
|
📌 Commit 5369f4a has been approved by |
bors
added
the
S-waiting-on-bors
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
May 28, 2020
…crum rustc_session: Cleanup session creation Noticed while reviewing rust-lang#72618.
RalfJung
added a commit
to RalfJung/rust
that referenced
this pull request
May 30, 2020
…crum rustc_session: Cleanup session creation Noticed while reviewing rust-lang#72618.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 30, 2020
Rollup of 13 pull requests Successful merges: - rust-lang#72543 (Account for missing lifetime in opaque and trait object return types) - rust-lang#72625 (Improve inline asm error diagnostics) - rust-lang#72637 (expand `env!` with def-site context) - rust-lang#72650 (Sort sidebar elements) - rust-lang#72657 (Allow types (with lifetimes/generics) in impl_lint_pass) - rust-lang#72666 (Add -Z profile-emit=<path> for Gcov gcda output.) - rust-lang#72668 (Fix missing parentheses Fn notation error) - rust-lang#72669 (rustc_session: Cleanup session creation) - rust-lang#72728 (Make bootstrap aware of relative libdir in stage0 compiler) - rust-lang#72757 (rustc_lexer: Optimize shebang detection slightly) - rust-lang#72772 (miri validation: clarify valid values of 'char') - rust-lang#72773 (Fix is_char_boundary documentation) - rust-lang#72777 (rustdoc: remove calls to `local_def_id_from_node_id`) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed while reviewing #72618.