Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add windows group to triagebot #72706

Merged
merged 3 commits into from
Jun 11, 2020
Merged

Add windows group to triagebot #72706

merged 3 commits into from
Jun 11, 2020

Conversation

spastorino
Copy link
Member

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 28, 2020
@joshtriplett
Copy link
Member

The linked instructions don't seem to exist.

@spastorino
Copy link
Member Author

spastorino commented May 29, 2020 •
edited
Loading

The linked instructions don't seem to exist.

Hey Josh, yeah sorry, I should have explained this better :). @nikomatsakis is the only person aware about what I'm doing here but this is part of a some steps needed to add a Windows ICEBreaker like group. There's a tracking issue here rust-lang/compiler-team#282.
For the link to work we need to merge first https://github.com/nikomatsakis/rustc-dev-guide/tree/notification-groups which I'm not sure if Niko already opened a PR or not.

Anyway, this is kind of WIP, I'd say.

@Dylan-DPC-zz
Copy link

@bors r+ rollup

@bors
Copy link
Contributor

bors commented May 29, 2020

📌 Commit 474b16b has been approved by Dylan-DPC

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 29, 2020
@Dylan-DPC-zz
Copy link

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 29, 2020
@Dylan-DPC-zz Dylan-DPC-zz marked this pull request as draft May 29, 2020 15:59
@Dylan-DPC-zz
Copy link

read the comment after r+'g it :D

@nikomatsakis nikomatsakis mentioned this pull request Jun 9, 2020
Closed
9 tasks
@nikomatsakis nikomatsakis marked this pull request as ready for review June 9, 2020 22:02
@nikomatsakis
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jun 9, 2020

📌 Commit e0ec3d5 has been approved by nikomatsakis

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 9, 2020
retep998
retep998 reviewed Jun 9, 2020
View reviewed changes
triagebot.toml Outdated Show resolved Hide resolved
@spastorino
Copy link
Member Author

@bors r=nikomatsakis

@bors
Copy link
Contributor

bors commented Jun 10, 2020

📌 Commit a01485c has been approved by nikomatsakis

@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Jun 10, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 10, 2020
@bors
Auto merge of rust-lang#73206 - Dylan-DPC:rollup-rha9g8q, r=Dylan-DPC
ec42485 
Rollup of 9 pull requests

Successful merges:

 - rust-lang#72706 (Add windows group to triagebot)
 - rust-lang#72789 (resolve: Do not suggest imports from the same module in which we are resolving)
 - rust-lang#72890 (improper ctypes: normalize return types and transparent structs)
 - rust-lang#72897 (normalize adt fields during structural match checking)
 - rust-lang#73005 (Don't create impl candidates when obligation contains errors)
 - rust-lang#73023 (Remove noisy suggestion of hash_map )
 - rust-lang#73070 (Add regression test for const generic ICE in rust-lang#72819)
 - rust-lang#73157 (Don't lose empty `where` clause when pretty-printing)
 - rust-lang#73184 (Reoder order in which MinGW libs are linked to fix recent breakage)

Failed merges:

r? @ghost
@bors bors merged commit a70fb70 into rust-lang:master Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@retep998 retep998 retep998 left review comments

Assignees

@nikomatsakis nikomatsakis

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@spastorino @joshtriplett @Dylan-DPC-zz @bors @nikomatsakis @retep998 @rust-highfive