Deprecate old items in RFC 2700 #72885
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
tesuji
commented
Jun 1, 2020
src/libcore/num/f64.rs
Outdated
Comment on lines
128
to
131
| #[rustc_deprecated( | ||
| since = "1.46.0", | ||
| reason = "The associated constant `f64::INFINITY` is now prefered", | ||
| suggestion = "f64::INFINITY", |
There was a problem hiding this comment.
I am afraid that rustfix cannot handle this suggestion.
For example, what does rustfix do in this case?
use std::f64;
f64::INFINITY;There was a problem hiding this comment.
I ran the snippet locally. rustfix doesn't do anything except for this case:
#![warn(deprecated_in_future)]
pub fn foo() -> f64 {
- use std::f64 as float;
- float::INFINITY
+
+ f64::INFINITY
}
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
Was it decided to actually deprecate the old constants now? That was met with resistance from some people which is why it was soft-deprecated for now. I'm in favor of fully deprecating them, but I suspect this is too soon after stabilization according to some people(?). Moving ahead and using |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
tesuji
force-pushed
the
deprecate-int-max_value
branch
from
7571d0d to
cd1fb91
Compare
tesuji
force-pushed
the
deprecate-int-max_value
branch
from
cd1fb91 to
9e81b51
Compare
tesuji
commented
Jun 2, 2020
| LL | if value <= (u32::max_value() as i64) && value >= 0 { | ||
| | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::try_from(value).is_ok()` | ||
| | | ||
| = note: `-D clippy::checked-conversions` implied by `-D warnings` |
There was a problem hiding this comment.
False negative tracked at rust-lang/rust-clippy#5675
|
Closing in favor of #72906. |
RalfJung
added a commit
to RalfJung/rust
that referenced
this pull request
Jun 11, 2020
…, r=dtolnay Migrate to numeric associated consts The deprecation PR is rust-lang#72885 cc rust-lang#68490 cc rust-lang/rfcs#2700
RalfJung
added a commit
to RalfJung/rust
that referenced
this pull request
Jun 12, 2020
…, r=dtolnay Migrate to numeric associated consts The deprecation PR is rust-lang#72885 cc rust-lang#68490 cc rust-lang/rfcs#2700
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Jun 12, 2020
…, r=dtolnay Migrate to numeric associated consts The deprecation PR is rust-lang#72885 cc rust-lang#68490 cc rust-lang/rfcs#2700
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jun 23, 2020
…, r=dtolnay Migrate to numeric associated consts The deprecation PR is rust-lang#72885 cc rust-lang#68490 cc rust-lang/rfcs#2700
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The numeric associated constants were stabilized from 1.43.0.
This PR deprecates the following items as of 1.46.0:
MIN/MAXconstants in the integer modulesmin_value/max_valuemethods on the integer types.cc #68490
cc rust-lang/rfcs#2700
r? @dtolnay
cc @faern, @LukasKalbertodt