add Option::{err_or,err_or_else} methods under option_err_or gate
#73040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds 2 methods to `Option<T>`: - `err_or` (similar to `ok_or`, signature is `fn<T, O>(Option<T>, O) -> Result<T, O>`) - `err_or_else` (similar to `ok_or_else`, signature is `fn<T, O>(Option<T>, impl FnOnce() -> O) -> Result<T, O>`) Both under `option_err_or` feature gate.
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Elinvynia
added
S-waiting-on-review
|
Reassigning to t-libs. |
dtolnay
reviewed
Jul 3, 2020
There was a problem hiding this comment.
Thanks for the PR!
I think I would prefer not to add this set of methods. As you mentioned, these are pretty rarely applicable. Instead of x.err_or(0) I would recommend that people write the same thing using existing methods as x.map_or(Ok(0), Err) or using match.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds 2 methods to
Option<T>:err_or(similar took_or, signature isfn<T, O>(Option<T>, O) -> Result<T, O>)err_or_else(similar took_or_else, signature isfn<T, O>(Option<T>, impl FnOnce() -> O) -> Result<T, O>)Both under
option_err_orfeature gate.It seems unintuitive to have
ok_orandok_or_else, but noterr*versions. This PR fills this gap inResult<->Optiontransformations.Those methods may be less useful, then their
ok*versions, however, need for them comes every now and then.I'm curious if the name
err_oris ok? Isn't It too similar toerror?