Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use LocalDefId directly in Resolver::export_map #73090

Merged
merged 1 commit into from
Jun 9, 2020

Conversation

marmeladema
Copy link
Contributor

This is to avoid the final conversion from NodeId to HirId
during call to (clone|into)_outputs

This brings down the post-lowering uses of NodeId down to 2 calls to convert the trait_map.

cc #50928

r? @petrochenkov

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 7, 2020
src/librustc_resolve/imports.rs Outdated Show resolved Hide resolved
src/librustc_middle/ty/context.rs Outdated Show resolved Hide resolved
src/librustc_middle/ty/context.rs Outdated Show resolved Hide resolved
@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 7, 2020
@marmeladema marmeladema force-pushed the resolver-outputs-local-def-id branch from 53a9edc to c896765 Compare June 7, 2020 16:33
@marmeladema marmeladema requested a review from petrochenkov June 7, 2020 16:38
@marmeladema marmeladema force-pushed the resolver-outputs-local-def-id branch from c896765 to ab18ce7 Compare June 7, 2020 17:55
@marmeladema marmeladema requested a review from petrochenkov June 7, 2020 17:57
@petrochenkov
Copy link
Contributor

r=me after squashing commits

…ts` query

This is to avoid the final conversion from `NodeId` to `HirId`
during call to `Resolver::(clone|into)_outputs`.
@marmeladema marmeladema force-pushed the resolver-outputs-local-def-id branch from ab18ce7 to e759222 Compare June 7, 2020 20:17
@marmeladema
Copy link
Contributor Author

@petrochenkov squashed 👍

@petrochenkov
Copy link
Contributor

Thanks!
@bors r+

@bors
Copy link
Contributor

bors commented Jun 7, 2020

📌 Commit e759222 has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 7, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Jun 7, 2020
…def-id, r=petrochenkov

Use `LocalDefId` directly in `Resolver::export_map`

This is to avoid the final conversion from `NodeId` to `HirId`
during call to `(clone|into)_outputs`

This brings down the post-lowering uses of `NodeId` down to 2 calls to convert the `trait_map`.

cc rust-lang#50928

r? @petrochenkov
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 8, 2020
Rollup of 8 pull requests

Successful merges:

 - rust-lang#71842 (doc: make impl block collapsible if it has an associated constant)
 - rust-lang#72912 (Add new E0758 error code)
 - rust-lang#73008 (Update RELEASES.md)
 - rust-lang#73090 (Use `LocalDefId` directly in `Resolver::export_map`)
 - rust-lang#73118 (Improve the wording in documentation of std::mem::drop)
 - rust-lang#73124 (Removed lifetime parameters from Explanation of E0207 )
 - rust-lang#73138 (Use shorthand linker strip arguments in order to support MacOS)
 - rust-lang#73143 (Update books)

Failed merges:

r? @ghost
@bors bors merged commit 845b869 into rust-lang:master Jun 9, 2020
@marmeladema marmeladema deleted the resolver-outputs-local-def-id branch April 24, 2021 09:12
@cuviper cuviper added this to the 1.46 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants