Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lint: normalize projections using opaque types #73287

Merged
merged 1 commit into from
Jun 21, 2020
Merged

lint: normalize projections using opaque types #73287

merged 1 commit into from
Jun 21, 2020

Conversation

davidtwco
Copy link
Member

Fixes #73251.

This PR normalizes projections which use opaque types (opaque types are otherwise linted against, which is would have previously made the test cases added in this PR fail).

@rust-highfive
Copy link
Collaborator

r? @estebank

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 12, 2020
This was referenced Jun 12, 2020
Merged
Closed
@estebank
Copy link
Contributor

Needs ./x.py fmt.

r=me after that

@davidtwco davidtwco force-pushed the issue-73251-opaque-types-in-projections branch from 8eb731a to 86c5aac Compare June 12, 2020 18:27
@davidtwco
Copy link
Member Author

Oops, fixed, will r=you after CI passes.

@rust-highfive

This comment has been minimized.

Sign in to view
@davidtwco davidtwco force-pushed the issue-73251-opaque-types-in-projections branch from 86c5aac to 4ff1678 Compare June 13, 2020 15:50
@davidtwco
Copy link
Member Author

Pushed a minor commit re-wording to re-trigger CI as the last failure was spurious.

@davidtwco
Copy link
Member Author

@bors r=estebank

@bors
Copy link
Contributor

bors commented Jun 13, 2020

📌 Commit 4ff1678 has been approved by estebank

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 13, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Jun 14, 2020
@Dylan-DPC
Rollup merge of rust-lang#73287 - davidtwco:issue-73251-opaque-types-…
30fc113 
…in-projections, r=estebank

lint: normalize projections using opaque types

Fixes rust-lang#73251.

This PR normalizes projections which use opaque types (opaque types are otherwise linted against, which is would have previously made the test cases added in this PR fail).
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Jun 14, 2020
Closed
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Jun 15, 2020
@Dylan-DPC
Rollup merge of rust-lang#73287 - davidtwco:issue-73251-opaque-types-…
b2a98b2 
…in-projections, r=estebank

lint: normalize projections using opaque types

Fixes rust-lang#73251.

This PR normalizes projections which use opaque types (opaque types are otherwise linted against, which is would have previously made the test cases added in this PR fail).
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Jun 15, 2020
Closed
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Jun 15, 2020
@Dylan-DPC
Rollup merge of rust-lang#73287 - davidtwco:issue-73251-opaque-types-…
9618aae 
…in-projections, r=estebank

lint: normalize projections using opaque types

Fixes rust-lang#73251.

This PR normalizes projections which use opaque types (opaque types are otherwise linted against, which is would have previously made the test cases added in this PR fail).
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Jun 15, 2020
Closed
@Dylan-DPC-zz
Copy link

failed in rollup ci

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 16, 2020
@davidtwco davidtwco force-pushed the issue-73251-opaque-types-in-projections branch from 4ff1678 to 792bd3b Compare June 16, 2020 09:46
@davidtwco davidtwco added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 16, 2020
@davidtwco
Copy link
Member Author

@bors r=estebank

@bors
Copy link
Contributor

bors commented Jun 16, 2020

📌 Commit 792bd3b has been approved by estebank

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 16, 2020
Manishearth added a commit to Manishearth/rust that referenced this pull request Jun 19, 2020
@Manishearth
Rollup merge of rust-lang#73287 - davidtwco:issue-73251-opaque-types-…
43fc34c 
…in-projections, r=estebank

lint: normalize projections using opaque types

Fixes rust-lang#73251.

This PR normalizes projections which use opaque types (opaque types are otherwise linted against, which is would have previously made the test cases added in this PR fail).
@Manishearth Manishearth mentioned this pull request Jun 19, 2020
Closed
@bors

This comment has been minimized.

Sign in to view
@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 19, 2020
@davidtwco
lint: normalize projections using opaque types
2e781dd 
This commit normalizes projections which contain opaque types (opaque types
are otherwise linted against, which is would have previously made the
test cases added in this commit fail).

Signed-off-by: David Wood <david@davidtw.co>
@davidtwco davidtwco force-pushed the issue-73251-opaque-types-in-projections branch from 792bd3b to 2e781dd Compare June 20, 2020 11:07
@davidtwco davidtwco added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 20, 2020
@davidtwco
Copy link
Member Author

@bors r=estebank

@bors
Copy link
Contributor

bors commented Jun 20, 2020

📌 Commit 2e781dd has been approved by estebank

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 20, 2020
Manishearth added a commit to Manishearth/rust that referenced this pull request Jun 20, 2020
@Manishearth
Rollup merge of rust-lang#73287 - davidtwco:issue-73251-opaque-types-…
e9ad00a 
…in-projections, r=estebank

lint: normalize projections using opaque types

Fixes rust-lang#73251.

This PR normalizes projections which use opaque types (opaque types are otherwise linted against, which is would have previously made the test cases added in this PR fail).
This was referenced Jun 20, 2020
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 20, 2020
@bors
Auto merge of rust-lang#73563 - Manishearth:rollup-oowgwwm, r=Manishe…
7058471 
…arth

Rollup of 9 pull requests

Successful merges:

 - rust-lang#72456 (Try to suggest dereferences on trait selection failed)
 - rust-lang#72788 (Projection bound validation)
 - rust-lang#72790 (core/time: Add Duration methods for zero)
 - rust-lang#73227 (Allow multiple `asm!` options groups and report an error on duplicate options)
 - rust-lang#73287 (lint: normalize projections using opaque types)
 - rust-lang#73291 (Pre-compute `LocalDefId` <-> `HirId` mappings and remove `NodeId` <-> `HirId` conversion APIs)
 - rust-lang#73378 (Remove use of specialization from librustc_arena)
 - rust-lang#73411 (Update bootstrap to rustc 1.45.0-beta.2 (1dc0f6d 2020-06-15))
 - rust-lang#73443 (ci: allow gating GHA on everything but macOS)

Failed merges:

r? @ghost
@bors bors merged commit 9003087 into rust-lang:master Jun 21, 2020
@davidtwco davidtwco deleted the issue-73251-opaque-types-in-projections branch June 25, 2020 11:09
@jruderman jruderman mentioned this pull request Nov 11, 2022
Closed
@cuviper cuviper added this to the 1.46 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@estebank estebank

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.46
Development

Successfully merging this pull request may close these issues.

improper_ctypes incorrectly warns on projections featuring opaque types
6 participants
@davidtwco @rust-highfive @estebank @bors @Dylan-DPC-zz @cuviper