-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix links when pinging notification groups #73290
Conversation
Filed this because the problem happened in #68812 (comment) |
probably the end quotes should be before the link rather than after? |
Quotes seem consistent with the other ping configurations though |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
@bors r+ rollup |
📌 Commit b126f32 has been approved by |
Fix links when pinging notification groups I think a blank line is necessary for the link to be applied. Not sure who to assign, r? @Dylan-DPC
Fix links when pinging notification groups I think a blank line is necessary for the link to be applied. Not sure who to assign, r? @Dylan-DPC
Fix links when pinging notification groups I think a blank line is necessary for the link to be applied. Not sure who to assign, r? @Dylan-DPC
Fix links when pinging notification groups I think a blank line is necessary for the link to be applied. Not sure who to assign, r? @Dylan-DPC
Fix links when pinging notification groups I think a blank line is necessary for the link to be applied. Not sure who to assign, r? @Dylan-DPC
Fix links when pinging notification groups I think a blank line is necessary for the link to be applied. Not sure who to assign, r? @Dylan-DPC
Rollup of 8 pull requests Successful merges: - rust-lang#72932 (Clarify the behaviour of Pattern when used with methods like str::contains) - rust-lang#73066 (Querify whether a type has structural equality (Take 2)) - rust-lang#73194 (Prefer the associated constants for pattern matching error) - rust-lang#73241 (Add/update comments about MinGW late_link_args) - rust-lang#73267 (Use the built cargo for cargotest.) - rust-lang#73290 (Fix links when pinging notification groups) - rust-lang#73302 (Adjusted some doctests in libcore to use `should_panic`.) - rust-lang#73308 (pretty/asm.rs should only be tested for x86_64 and not AArch64) Failed merges: r? @ghost
I think a blank line is necessary for the link to be applied.
Not sure who to assign, r? @Dylan-DPC