Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use str-literal instead of char-literal before converting to String #73463

Closed
wants to merge 1 commit into from
Closed

use str-literal instead of char-literal before converting to String #73463

wants to merge 1 commit into from

Conversation

matthiaskrgr
Copy link
Member

use str-literal instead of char-literal before converting to String since str to String conversion is cheaper.

See #73462

@rust-highfive
Copy link
Collaborator

r? @petrochenkov

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 18, 2020
@Mark-Simulacrum
Copy link
Member

I'd prefer that we fix this at the root in std/alloc instead of trying to fix use sites.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@petrochenkov petrochenkov

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@matthiaskrgr @rust-highfive @Mark-Simulacrum @petrochenkov