Clean up E0689 explanation #73472
Merged
Clean up E0689 explanation #73472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
pickfire
reviewed
Jun 18, 2020
Comment on lines
+9
to
+10
| This error indicates that the numeric value for the method being passed exists | ||
| but the type of the numeric value or binding could not be identified. |
There was a problem hiding this comment.
I believe maybe it would be better to arrange above the example like the below description which this refers to. Or maybe it would be better if we use This error rather than The error for the text below to avoid confusion.
There was a problem hiding this comment.
Thanks for the feedback. Most of the error messages are of th esimilar fashion and I think it is fine for now.
|
@bors r+ rollup |
|
📌 Commit 1d08b1b has been approved by |
bors
added
S-waiting-on-bors
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jun 21, 2020
…an-DPC Clean up E0689 explanation r? @Dylan-DPC
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jun 21, 2020
…an-DPC Clean up E0689 explanation r? @Dylan-DPC
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jun 22, 2020
…an-DPC Clean up E0689 explanation r? @Dylan-DPC
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jun 22, 2020
…an-DPC Clean up E0689 explanation r? @Dylan-DPC
This was referenced Jun 22, 2020
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 23, 2020
…arth Rollup of 9 pull requests Successful merges: - rust-lang#72271 (Improve compiler error message for wrong generic parameter order) - rust-lang#72493 ( move leak-check to during coherence, candidate eval) - rust-lang#73398 (A way forward for pointer equality in const eval) - rust-lang#73472 (Clean up E0689 explanation) - rust-lang#73496 (Account for multiple impl/dyn Trait in return type when suggesting `'_`) - rust-lang#73515 (Add second message for LiveDrop errors) - rust-lang#73567 (Clarify --extern documentation.) - rust-lang#73572 (Fix typos in doc comments) - rust-lang#73590 (bootstrap: no `config.toml` exists regression) Failed merges: r? @ghost
|
☔ The latest upstream changes (presumably #73643) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @Dylan-DPC