Make lang items private #73500
Closed
Make lang items private #73500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
What do you think will be easier to do? Merge this PR first or merge #72559 first? EDIT: linked wrong PR |
I'll give it a proper read this afternoon but my gut feeling is probably this |
|
I'll review the other PR then and carry it over the finish line |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
☔ The latest upstream changes (presumably #73504) made this pull request unmergeable. Please resolve the merge conflicts. |
1 similar comment
|
☔ The latest upstream changes (presumably #73504) made this pull request unmergeable. Please resolve the merge conflicts. |
lcnr
reviewed
Jun 19, 2020
| impl<CTX> HashStable<CTX> for LangItemRecord { | ||
| fn hash_stable(&self, _: &mut CTX, hasher: &mut StableHasher) { | ||
| ::std::hash::Hash::hash(self, hasher); | ||
| } |
There was a problem hiding this comment.
Is this implementation correct? LangItemRecord can contain a DefId for which hash is not stable.
JohnCSimon
added
S-waiting-on-author
|
@doctorn This is another ping from Triage. |
|
@doctorn hey :) closing this due to inactivity. If you wish when you have the time to do so, you can submit a new PR with these changes. Thank you for taking the time to contribute :) |
Dylan-DPC-zz
added
S-inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements rust-lang/compiler-team#301
Design is largely as discussed, but I also made an effort to remove
require_lang_item. Instead,LangItemRecordhas methodsrequireandrequire_withwhich take a reference to aMissingLangItemHandler(implemented byTyCtxt). In my opinion this makes the interface a lot cleaner while also reducing the number of imports (it is no longer necessary to importlang_itemsor specific items in order to require them).This change also made it possible to unify the
itemandmissingfields of the lang items table. We no longer require the hack in the weak lang items pass for markingeh_personalityas missing as all lang items are now assumed missing until found. To make this work,alloc_error_handleris explicitly whitelisted in crates which do not require an allocator.This is likely to conflict with a lot of open PRs as it touches a lot of code, but my biggest worry is #72559 (which will need to be re-implemented to use the new API although I can't imagine it will be too difficult).
Resolves #72240
r? @oli-obk
cc @ecstatic-morse + @Aaron1011