Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename clashing_extern_decl to clashing_extern_declarations. #73817

Merged

Conversation

jumbatm
Copy link
Contributor

@jumbatm jumbatm commented Jun 27, 2020

Rename clashing_extern_decl to clashing_extern_declarations to bring in-line with lint naming conventions.

Fixes #73802.

r? @petrochenkov

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 27, 2020
@rust-highfive

This comment has been minimized.

Also, run RustFmt on the clashing_extern_fn test case and update
stderrs.
@jumbatm jumbatm force-pushed the rename-to-clashing-extern-declarations branch from ebd27a1 to c72a5dd Compare June 28, 2020 00:12
@petrochenkov
Copy link
Contributor

Thanks!
@bors r+

@bors
Copy link
Contributor

bors commented Jun 28, 2020

📌 Commit c72a5dd has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 28, 2020
@phansch
Copy link
Member

phansch commented Jun 28, 2020

@petrochenkov I believe this is missing a register_renamed call (here)?

@petrochenkov
Copy link
Contributor

@phansch
This lint was only merged a ~week ago, so it didn't propagate to the stable channel yet and we don't need any compatibility measures.

bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 28, 2020
…arth

Rollup of 9 pull requests

Successful merges:

 - rust-lang#73577 (Add partition_point)
 - rust-lang#73757 (Const prop: erase all block-only locals at the end of every block)
 - rust-lang#73774 (Make liveness more precise for assignments to fields)
 - rust-lang#73795 (Add some `const_compare_raw_pointers`-related regression tests)
 - rust-lang#73800 (Forward Hash::write_iN to Hash::write_uN)
 - rust-lang#73813 (Rename two `Resolver` traits)
 - rust-lang#73817 (Rename clashing_extern_decl to clashing_extern_declarations.)
 - rust-lang#73826 (Fix docstring typo)
 - rust-lang#73833 (Remove GlobalCtxt::enter_local)

Failed merges:

r? @ghost
@bors bors merged commit 8b92eec into rust-lang:master Jun 28, 2020
@jumbatm jumbatm deleted the rename-to-clashing-extern-declarations branch June 28, 2020 20:50
@cuviper cuviper added this to the 1.46 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

clashing_extern_decl lint does not follow naming conventions
6 participants