-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 12 pull requests #74019
Merged
Merged
Rollup of 12 pull requests #74019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The xml.etree.cElementTree has been deprecated since Python 3.3 and removed in Python 3.9 https://bugs.python.org/issue36543.
Apply suggestion from varkor Co-authored-by: varkor <github@varkor.com>
Co-Authored-By: Ralf Jung <post@ralfj.de>
If temporaries are used beyond just the temporary chain, then we can't optimize out the reads and writes.
The previous link is 404.
- Add newline to provide concise module summary - Add wikipedia link - Italicize O notation
Fallback to xml.etree.ElementTree The xml.etree.cElementTree has been deprecated since Python 3.3 and removed in Python 3.9 https://bugs.python.org/issue36543.
…varkor Add `format_args_capture` feature This is the initial implementation PR for [RFC 2795](rust-lang/rfcs#2795). Note that, as dicussed in the tracking issue (rust-lang#67984), the feature gate has been called `format_args_capture`. Next up I guess I need to add documentation for this feature. I've not written any docs before for rustc / std so I would appreciate suggestions on where I should add docs.
…atch, r=oli-obk Use exhaustive match in const_prop.rs Addresses a comment left by @RalfJung on rust-lang#73613 r? @RalfJung
Use &raw in A|Rc::as_ptr This PR uses `&raw` for offsetting `*mut [A]RcInner<T> -> *mut T`. Additionally, this updates the implementation of `Weak::as_ptr` to support unsized `T`, though it does not yet relax the bounds of `Weak::as_ptr`/`into_raw`/`from_raw` to accept unsized `T`.
…n-DPC Create E0768 r? @Dylan-DPC
…s-schievink Standardize bibliographic citations in rustc API docs See rust-lang#73877.
… r=RalfJung Improve comments from rust-lang#72617, as suggested by RalfJung r? @RalfJung
…li-obk [mir-opt] Fix mis-optimization and other issues with the SimplifyArmIdentity pass This does not yet attempt re-enabling the pass, but it does resolve a number of issues with the pass. r? @oli-obk I believe this closes rust-lang#73223.
…chievink Edit docs for rustc_data_structures::graph::scc - Add newline to provide concise module summary - Add wikipedia link - Italicize O notation
…nas-schievink Fix "getting started" link The previous link is 404.
…ievink fix typo r? @Dylan-DPC
Bump mingw-check CI image from Ubuntu 16.04 to 18.04. I chose 18.04 because we use it for other builders, and it's enough to get a version of MinGW that can build `libssh2-sys`. This is a prereq for rust-lang#73902, where `libssh2-sys` shows up as an indirect dependency of `x.py check src/tools/semverver` (through `src/tools/cargo`, which we don't currently `x.py check` because it's not in-tree). See also rust-lang#73902 (comment). r? @Mark-Simulacrum cc @mati865
📌 Commit d69a846 has been approved by |
bors
added
the
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
label
Jul 4, 2020
☔ The latest upstream changes (presumably #73650) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Jul 4, 2020
lol |
That's an interesting state we're in @pietroalbini I assume it merged with git's algorithm but not github's |
☀️ Test successful - checks-actions, checks-azure |
This was referenced Jul 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
merged-by-bors
This PR was explicitly merged by bors.
rollup
A PR which is a rollup
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
format_args_capture
feature #73670 (Addformat_args_capture
feature)std::thread::panicking
. #72617, as suggested by RalfJung)Failed merges:
lazy_normalization_consts
feature gate #74000 (addlazy_normalization_consts
feature gate)r? @ghost