Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

std: Fix compilation without backtrace feature #74540

Merged
merged 1 commit into from
Jul 20, 2020

Conversation

alexcrichton
Copy link
Member

This should hopefully handle #74484 but in any case fixes compilation of
the standard library without the backtrace feature. The need for this
feature is somewhat unclear now because the backtrace crate should
always compile (no more C code!) but we can handle that later if
necessary.

This should hopefully handle rust-lang#74484 but in any case fixes compilation of
the standard library without the `backtrace` feature. The need for this
feature is somewhat unclear now because the `backtrace` crate should
always compile (no more C code!) but we can handle that later if
necessary.
@rust-highfive
Copy link
Collaborator

r? @withoutboats

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 20, 2020
@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Jul 20, 2020

📌 Commit 028f8d7 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 20, 2020
Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 20, 2020
…rk-Simulacrum

std: Fix compilation without backtrace feature

This should hopefully handle rust-lang#74484 but in any case fixes compilation of
the standard library without the `backtrace` feature. The need for this
feature is somewhat unclear now because the `backtrace` crate should
always compile (no more C code!) but we can handle that later if
necessary.
@bors
Copy link
Contributor

bors commented Jul 20, 2020

⌛ Testing commit 028f8d7 with merge 05630b0...

@bors
Copy link
Contributor

bors commented Jul 20, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: Mark-Simulacrum
Pushing 05630b0 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 20, 2020
@bors bors merged commit 05630b0 into rust-lang:master Jul 20, 2020
@alexcrichton alexcrichton deleted the std-no-backtrace branch July 20, 2020 14:10
@cuviper cuviper added this to the 1.47.0 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants