Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 13 pull requests #74569

Merged
merged 30 commits into from
Jul 21, 2020
Merged

Rollup of 13 pull requests #74569

merged 30 commits into from
Jul 21, 2020

Conversation

Manishearth
Copy link
Member

Successful merges:

Failed merges:

r? @ghost

c410-f3r and others added 30 commits June 9, 2020 23:10
They are now unnecessary for projects written in Rust, since
backtrace-rs used by the standard library has only Rust dependencies.
This has been put in place to patch over an ICE caused when we encounter
a non-static lifetime in a const generic during borrow checking. This
restriction may be relaxed in the future, but we need more discussion
before then, and in the meantime we should still deal with this ICE.

Fixes issue rust-lang#60814
This commit extends current well-formedness checking to apply to foreign
function declarations, re-using the existing machinery for regular
functions. In doing this, later parts of the compiler (such as the
`improper_ctypes` lint) can rely on being operations not failing as a
result of invalid code which would normally be caught earlier.

Signed-off-by: David Wood <david@davidtw.co>
Impl Default for ranges

Couldn't find an issue about it.

`Range` and friends probably can implement `Default` if `Idx: Default`. For example, the following would be possible:

```rust
#[derive(Default)]
struct Foo(core::ops::RangeToInclusive<u64>);

let _ = [1, 2, 3].get(core::ops::Range::default());

core::ops::RangeFrom::<u8>::default().take(20).for_each(|x| { dbg!(x); });

fn stuff<T: Default>() { let instance = T::default(); ... more stuff }
stuff::<core::ops::RangeTo<f32>>();
```

Maybe there are some concerns about safety or misunderstandings?
…gn-fn-decl, r=ecstatic-morse

wf: check foreign fn decls for well-formedness

Fixes rust-lang#73252 and fixes rust-lang#73253.

This PR extends current well-formedness checking to apply to foreign function declarations, re-using the existing machinery for regular functions. In doing this, later parts of the compiler (such as the `improper_ctypes` lint) can rely on being operations not failing as a result of invalid code which would normally be caught earlier.
…akis

disallow non-static lifetimes in const generics

Disallow non-static lifetimes in const generics in order to to patch over an ICE caused when we encounter a non-static lifetime in a const generic during borrow checking. This restriction may be relaxed in the future, but we need more discussion before then, and in the meantime we should still deal with this ICE.

Fixes issue rust-lang#60814
…=eddyb

test caching opt_const_param_of on disc

Followup to rust-lang#74113, implements parts of rust-lang#74360

Tried caching `opt_const_param_of` on disk and adding an early exit if `tcx.dep_kind(def_id) != DefKind::AnonConst`.

Ended up causing a perf regression instead, so we just remove the FIXME and a short note to `opt_const_param_of`.

r? @eddyb
…omez

Ayu theme: Use different background color for Run button

Make it clearer that there is a button Run there.

Demo in rust-lang#74501 (comment) .
Update sanitizer docs

* Document AddressSanitizer memory leak detection defaults.
* Remove CC & CFLAGS from MemorySanitizer example - they are now unnecessary for pure Rust projects (backtrace-rs moved away from libbacktrace).
…be_uninit_extra, r=kennytm

Fix duplicate maybe_uninit_extra attribute

Introduced in rust-lang#72414
…up, r=Manishearth

Improve "important traits" popup display on mobile

I implemented what @XAMPPRocky suggested in the [internals thread topic](https://internals.rust-lang.org/t/feedback-on-important-traits-rustdoc-feature/12752/18). I can confirm it works nicely.

r? @Manishearth

@Manishearth: By the way: I realized that when you click on the "i", you have to click again to make the popup disappear. Do you want me to extend the popup removal to any click outside the popup?
Fix an ICE on an invalid `binding @ ...` in a tuple struct pattern

Fixes rust-lang#74539.
@Manishearth
Copy link
Member Author

@rustbot modify labels: +rollup
@bors r+ rollup=never p=5 treeclosed=5

@rustbot rustbot added the rollup A PR which is a rollup label Jul 20, 2020
@bors
Copy link
Contributor

bors commented Jul 20, 2020

📌 Commit df8d169 has been approved by Manishearth

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jul 20, 2020
@bors
Copy link
Contributor

bors commented Jul 20, 2020

⌛ Testing commit df8d169 with merge 1d31d85f63b411275ad79b0b3494ecda6888e932...

@bors
Copy link
Contributor

bors commented Jul 20, 2020

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 20, 2020
@Manishearth
Copy link
Member Author

@bors retry

toolstate permission denied cc @Mark-Simulacrum

2020-07-20T20:11:28.5526361Z [master 4353d43] (linux CI update)
2020-07-20T20:11:28.5526853Z  1 file changed, 1 insertion(+)
2020-07-20T20:11:32.0799579Z To https://github.com/pietroalbini/rust-toolstate
2020-07-20T20:11:32.0800179Z  ! [remote rejected] master -> master (permission denied)
2020-07-20T20:11:32.0800694Z error: failed to push some refs to 'https://github.com/pietroalbini/rust-toolstate'

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 20, 2020
@bors
Copy link
Contributor

bors commented Jul 20, 2020

⌛ Testing commit df8d169 with merge 2880f171fe36733789c95a80dc538ec811ed3913...

@Mark-Simulacrum
Copy link
Member

@bors retry

I suspect we need #74565 to land first before this, right? @pietroalbini -- do you know? My assumption is that if we've switched tokens in the UI and that's leading to problems here or so.

@bors
Copy link
Contributor

bors commented Jul 20, 2020

⌛ Testing commit df8d169 with merge 734233d...

@pietroalbini
Copy link
Member

@Mark-Simulacrum I should have hopefully granted the right permissions.

@bors
Copy link
Contributor

bors commented Jul 21, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: Manishearth
Pushing 734233d to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 21, 2020
@bors bors merged commit 734233d into rust-lang:master Jul 21, 2020
@rust-highfive
Copy link
Collaborator

📣 Toolstate changed by #74569!

Tested on commit 734233d.
Direct link to PR: #74569

🎉 miri on windows: test-fail → test-pass (cc @oli-obk @eddyb @RalfJung).
🎉 miri on linux: test-fail → test-pass (cc @oli-obk @eddyb @RalfJung).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Jul 21, 2020
Tested on commit rust-lang/rust@734233d.
Direct link to PR: <rust-lang/rust#74569>

🎉 miri on windows: test-fail → test-pass (cc @oli-obk @eddyb @RalfJung).
🎉 miri on linux: test-fail → test-pass (cc @oli-obk @eddyb @RalfJung).
@Manishearth Manishearth deleted the rollup-hkn5ex9 branch July 21, 2020 01:41
@cuviper cuviper added this to the 1.47.0 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.