Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DO NOT MERGE] perf-test for #74478 #74678

Closed
wants to merge 2 commits into from
Closed

[DO NOT MERGE] perf-test for #74478 #74678

wants to merge 2 commits into from

Conversation

rust-timer
Copy link
Collaborator

This is an automatically generated pull request (from here) to run perf tests for #74478 which merged in a rollup.

r? @ghost

@rust-timer
Revert to 1fa54ad
f4f34f6
@rust-timer
rust-timer simulated merge of a83e294
24e0da0 
Original message:
Rollup merge of rust-lang#74478 - rust-lang:revert-74416-linker-locale-utf8, r=Mark-Simulacrum

Revert "Use an UTF-8 locale for the linker."

Reverts rust-lang#74416

This is suspected to have caused significant compile time regressions: https://perf.rust-lang.org/compare.html?start=39d5a61f2e4e237123837f5162cc275c2fd7e625&end=d3df8512d2c2afc6d2e7d8b5b951dd7f2ad77b02&stat=instructions:u
@rust-timer
Copy link
Collaborator Author

@bors try @rust-timer queue

The try commit's (master) parent should be 2bbfa02. If it isn't, then please:

  • Stop this try build (try-).
  • Run @rust-timer update-pr-for a83e294f7778c3643005dc0567fe47767fab6508.
  • Rerun bors try.

You do not need to reinvoke the queue command as long as the perf build hasn't yet started.

@rust-timer
Copy link
Collaborator Author

Awaiting bors try build completion

@bors
Copy link
Contributor

bors commented Jul 23, 2020

⌛ Trying commit 24e0da0 with merge a2bdac26d4f4c69c6c065d86225b764ba750819b...

@bors
Copy link
Contributor

bors commented Jul 23, 2020

☔ The latest upstream changes (presumably #74613) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jul 23, 2020
@bors
Copy link
Contributor

bors commented Jul 23, 2020

☀️ Try build successful - checks-actions, checks-azure
Build commit: a2bdac26d4f4c69c6c065d86225b764ba750819b (a2bdac26d4f4c69c6c065d86225b764ba750819b)

@rust-timer
Copy link
Collaborator Author

Queued a2bdac26d4f4c69c6c065d86225b764ba750819b with parent 2bbfa02, future comparison URL.

@Mark-Simulacrum
Copy link
Member

Real comparison URL: https://perf.rust-lang.org/compare.html?start=1fa54ad9680cc82e7301f8ed4e9b7402dfd6ce0e&end=a2bdac26d4f4c69c6c065d86225b764ba750819b

@rust-timer
Copy link
Collaborator Author

Finished benchmarking try commit (a2bdac26d4f4c69c6c065d86225b764ba750819b): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rust-timer @bors @Mark-Simulacrum