Avoid bool-like naming #74905
Avoid bool-like naming #74905
Conversation
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
It looks like bors didn't actually register this message 🤔 cc @rust-lang/infra @bors r=jyn514 rollup=always |
|
📌 Commit 0374006 has been approved by |
bors
added
S-waiting-on-bors
|
Do we still need to support python 2? |
|
Yes, AFAIK. What's in this change that isn't python2 compatible? |
@lcnr bors doesn't listen to the message from the review comments IIRC. |
| if listed: | ||
| tests = [test for test in tests if test in listed] | ||
| args = sys.argv[1:] | ||
| tests = [test for test in tests if test in args] |
There was a problem hiding this comment.
This changes the no-arg behavior, previously it included everyhting now it will include nothing. Was this intentional?
There was a problem hiding this comment.
Yeah, that's right. Will prepare another PR.
…arth Rollup of 9 pull requests Successful merges: - rust-lang#74751 (Clean up E0730 explanation) - rust-lang#74782 (Don't use "weak count" around Weak::from_raw_ptr) - rust-lang#74835 (Clean up E0734 explanation) - rust-lang#74871 (Enable docs on dist-x86_64-musl) - rust-lang#74905 (Avoid bool-like naming) - rust-lang#74907 (Clean up E0740 explanation) - rust-lang#74915 (rustc: Ignore fs::canonicalize errors in metadata) - rust-lang#74934 (Improve diagnostics when constant pattern is too generic) - rust-lang#74951 (Cherry-pick the release notes for 1.45.1) Failed merges: r? @ghost
Run all tests if have no specified tests The behaviour was changed in rust-lang#74905 (comment) cc @alex if you could check it again, thank you.
@jyn514 Sorry, I was discussing something off-topic, but I am just wondering if we still need to support python 2 even though it is already end of life. |
|
IIRC, rust repo have moved to python3 for a while. |
|
We intend to support both Python 2.7 and Python 3 currently -- I believe this is somewhat tested on CI, but obviously not fully. |
|
@Mark-Simulacrum How long do we still intend to support it? Python 2 is already not being supported by python themselves since the start of the year and 7 months have passed since then. By python 3 do you mean python 3.4 or above? |
|
We have not established a minimum minor version for Python 3, we'd need to do some research about what is available on older (linux) systems by default (or through package managers). Python 2 is still supported by many distros to my knowledge. |
Lost in #74127 (comment)