Prefer pattern matching over indexing #75036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
pickfire
reviewed
Aug 2, 2020
pickfire
approved these changes
Aug 2, 2020
cuviper
reviewed
Aug 2, 2020
|
☔ The latest upstream changes (presumably #75388) made this pull request unmergeable. Please resolve the merge conflicts. |
cuviper
approved these changes
Aug 11, 2020
|
@bors r+ rollup |
|
📌 Commit e8ea6e5 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 11, 2020
Rollup of 7 pull requests Successful merges: - rust-lang#75036 (Prefer pattern matching over indexing) - rust-lang#75378 (Introduce `rustc_lexer::is_ident` and use it in couple of places) - rust-lang#75393 (Fully handle "?" shortcut) - rust-lang#75403 (Update comment for function) - rust-lang#75407 (Requested changes to [*mut T|*const T]::set_ptr_value) - rust-lang#75408 (Update MinGW comments in ci.yml) - rust-lang#75409 (Fix range term in alloc vec doc) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quite a bit nicer IMO.
r? @cuviper