Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rust_ast::ast => rustc_ast #75120

Merged
merged 1 commit into from
Aug 18, 2020
Merged

rust_ast::ast => rustc_ast #75120

merged 1 commit into from
Aug 18, 2020

Conversation

JulianKnodt
Copy link
Contributor

Rework of #71199 which is a rework #70621

Still working on this but just made the PR to track progress

r? @Dylan-DPC

@rust-highfive
Copy link
Collaborator

Some changes occurred in intra-doc-links.

cc @jyn514

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 3, 2020
@Dylan-DPC-zz
Copy link

r? @eddyb

@rust-highfive rust-highfive assigned eddyb and unassigned Dylan-DPC-zz Aug 3, 2020
@Dylan-DPC-zz
Copy link

r? @eddyb

@jyn514
Copy link
Member

jyn514 commented Aug 3, 2020

Wow, that is a lot of changed files 😅

@JulianKnodt JulianKnodt force-pushed the rm_reps branch 2 times, most recently from 58f7ebc to 57e489f Compare August 4, 2020 00:42
@bors
Copy link
Contributor

bors commented Aug 7, 2020

☔ The latest upstream changes (presumably #74627) made this pull request unmergeable. Please resolve the merge conflicts.

@eddyb
Copy link
Member

eddyb commented Aug 16, 2020 •
edited
Loading

Please don't r? me on this, I wanted this (for consistency etc.), someone else from @rust-lang/compiler should approve it.

@eddyb eddyb removed their assignment Aug 16, 2020
@eddyb eddyb added S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 16, 2020
@JulianKnodt
Copy link
Contributor Author

Is this high priority or just for consistency? If it's slow to review there's no point in me rebasing because it touches so many things the time between merge conflicts is quite low.

@JulianKnodt JulianKnodt force-pushed the rm_reps branch 3 times, most recently from fc9a973 to a61e626 Compare August 17, 2020 04:13
@oli-obk
Copy link
Contributor

oli-obk commented Aug 17, 2020

@bors p=6 super bitrotty

r=me with the accidentally added file removed.

@bors
Copy link
Contributor

bors commented Aug 17, 2020

☔ The latest upstream changes (presumably #75187) made this pull request unmergeable. Please resolve the merge conflicts.

@Dylan-DPC-zz
Copy link

@JulianKnodt you need to run tidy once over this and we are good to go

@wesleywiser
Copy link
Member

@bors r=oli-obk

@bors
Copy link
Contributor

bors commented Aug 17, 2020

📌 Commit a888b02 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). labels Aug 17, 2020
@matklad
Copy link
Member

matklad commented Aug 17, 2020

cc @mark-i-m , for removing rustc prefix idea

@bors
Copy link
Contributor

bors commented Aug 17, 2020

⌛ Testing commit a888b02 with merge 668ef72...

@mark-i-m
Copy link
Member

I'm pretty torn honestly. I think this change is great, but also look at all that churn! Now imagine doing that literally for the whole compiler.

@JulianKnodt
Copy link
Contributor Author

Is there a way to allow for previous paths to exist but request people update?

@bors
Copy link
Contributor

bors commented Aug 18, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: oli-obk
Pushing 668ef72 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 18, 2020
@bors bors merged commit 668ef72 into rust-lang:master Aug 18, 2020
@bors bors mentioned this pull request Aug 18, 2020
Closed
6 tasks
@mark-i-m
Copy link
Member

The only thing I thought of was to use use ast as rustc_ast; and so on. So we can change the crate names but continue to use the old names.

This was referenced Aug 18, 2020
Merged
Merged
Merged
@Dylan-DPC-zz
Copy link

@mark-i-m looks like more PRs to work on, on my list :D

@bors bors mentioned this pull request Aug 18, 2020
Merged
flip1995 pushed a commit to flip1995/rust that referenced this pull request Aug 28, 2020
@bors
Auto merge of rust-lang#75120 - JulianKnodt:rm_reps, r=oli-obk
4b0e6d5 
rust_ast::ast => rustc_ast

Rework of rust-lang#71199 which is a rework rust-lang#70621

Still working on this but just made the PR to track progress

r? @Dylan-DPC
@cuviper cuviper added this to the 1.47.0 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyn514 jyn514 jyn514 left review comments

@oli-obk oli-obk oli-obk left review comments

Assignees
No one assigned
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.47.0
Development

Successfully merging this pull request may close these issues.