-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove two fields from SubstFolder
.
#75133
Conversation
Some local measurements:
@bors try @rust-timer queue |
Awaiting bors try build completion |
⌛ Trying commit ff51bdcca3fa65d55b8f276f772775384e910aee with merge 0b19afee13894f423bd57e571688ba5631ec40ce... |
☀️ Try build successful - checks-actions, checks-azure |
Queued 0b19afee13894f423bd57e571688ba5631ec40ce with parent 80f84eb, future comparison URL. |
Did you mean to |
GitHub suggested you as a reviewer, but it sounds like that wasn't a good suggestion. |
They're only used in error messages printed if there's an internal compiler error, and the cost of maintaining them is high enough to show up in profiles.
ff51bdc
to
eeb4b83
Compare
That's strange, I don't think I am in the reviewers list/have r+ powers 😅 |
Finished benchmarking try commit (0b19afee13894f423bd57e571688ba5631ec40ce): comparison url. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up. @bors rollup=never |
@bors r+ |
📌 Commit eeb4b83 has been approved by |
☀️ Test successful - checks-actions, checks-azure |
They're only used in error messages printed if there's an internal
compiler error, and the cost of maintaining them is high enough to show
up in profiles.
r? @matthewjasper