more work leading up to exchange allocation header removal #7521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 3, 2013
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Sep 3, 2021
…g, r=camsteffen lintcheck always copies in a fresh crate when provided with a crate path changelog: none When lintcheck is run on local crates it copies the crate to `target/lintcheck/sources/crate_name` on the first run only. Then in subsequent runs of lintcheck it reuses this same copy. This caching behaviour makes sense when dealing with immutable crates.io releases and git commits. However it is quite surprising that the changes to my local crate are not used when I run lintcheck. To fix this I removed the copy, instead clippy runs directly off the provided crate folder. I have tested this and have not observed any negative effects from doing this. But maybe i'm missing something as im not familiar with clippy! Alternatively we could make it copy the entire crate every run, but that seems problematic to me as multi-gigabyte target folders will take a long time to copy and wear down SSDs for developers who frequently run lintcheck.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
continued from #7495