Change the type of AssertModuleSource::available_cgus.
#75210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
Does it affect the build reproducibility? |
|
#65657 changed the |
It's currently a `BTreeSet<Symbol>`, which is a strange type. The
`BTreeSet` suggests that element order is important, but `Symbol` is a
type whose ordering isn't useful to humans. The ordering of the
collection only manifests in an obscure error message ("no module named
`...`") that doesn't appear in any tests.
This commit changes the `Symbol` to a `String`, which is more
typical.
nnethercote
force-pushed
the
change-type-of-available_cgus
branch
from
f1aa8af to
ebbf07a
Compare
|
I have changed it to a |
|
@bors r+ rollup |
|
📌 Commit ebbf07a has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 7, 2020
Rollup of 12 pull requests Successful merges: - rust-lang#74888 (compiletest: ignore-endian-big, fixes rust-lang#74829, fixes rust-lang#74885) - rust-lang#75175 (Make doctests of Ipv4Addr::from(u32) easier to read) - rust-lang#75179 (Remove unused FromInner impl for Ipv4Addr) - rust-lang#75181 (Fix typo in `librustc_feature/active.rs`) - rust-lang#75183 (Label rustfmt toolstate issues with A-rustfmt) - rust-lang#75188 (Handle fieldless tuple structs in diagnostic code) - rust-lang#75190 (Clean up E0746 explanation) - rust-lang#75210 (Change the type of `AssertModuleSource::available_cgus`.) - rust-lang#75211 (Note about endianness of returned value of {integer}::from_be_bytes and friends) - rust-lang#75217 (Clean up E0747 explanation) - rust-lang#75232 (Fix typo "TraitObligatiom" -> "TraitObligation") - rust-lang#75236 (Fix typo "biset" -> "bitset") Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's currently a
BTreeSet<Symbol>, which is a strange type. TheBTreeSetsuggests that element order is important, butSymbolis atype whose ordering isn't useful to humans. The ordering of the
collection only manifests in an obscure error message ("no module named
...") that doesn't appear in any tests.This commit changes the
Symbolto aString, which is moretypical.