Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect likely for foo of bar JS syntax #75320

Merged
merged 1 commit into from
Aug 10, 2020
Merged

Detect likely for foo of bar JS syntax #75320

merged 1 commit into from
Aug 10, 2020

Conversation

estebank
Copy link
Contributor

@estebank estebank commented Aug 9, 2020

Fix #75311.

@rust-highfive
Copy link
Collaborator

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 9, 2020
@estebank
Copy link
Contributor Author

estebank commented Aug 9, 2020

r? @JohnTitor

@rust-highfive rust-highfive assigned JohnTitor and unassigned eddyb Aug 9, 2020
JohnTitor
JohnTitor approved these changes Aug 9, 2020
View reviewed changes
Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! But I'm not sure if I could r+ here as I'm not a part of the compiler team or its contributors officially. r=me if you think it's okay :)

@estebank
Copy link
Contributor Author

estebank commented Aug 9, 2020

r? @davidtwco

@rust-highfive rust-highfive assigned davidtwco and unassigned JohnTitor Aug 9, 2020
davidtwco
davidtwco approved these changes Aug 9, 2020
View reviewed changes
Copy link
Member

@davidtwco davidtwco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@davidtwco
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Aug 9, 2020

📌 Commit 4dbe0ac has been approved by davidtwco

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 9, 2020
@JohnTitor JohnTitor mentioned this pull request Aug 10, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 10, 2020
@bors
Auto merge of rust-lang#75351 - JohnTitor:rollup-q9udsyx, r=JohnTitor
cee62c1 
Rollup of 8 pull requests

Successful merges:

 - rust-lang#74200 (Std panicking unsafe block in unsafe fn)
 - rust-lang#75286 (Add additional case for Path starts with)
 - rust-lang#75318 (Resolve `char` as a primitive even if there is a module in scope)
 - rust-lang#75320 (Detect likely `for foo of bar` JS syntax)
 - rust-lang#75328 (Cleanup E0749)
 - rust-lang#75344 (Rename "Important traits" to "Notable traits")
 - rust-lang#75348 (Move to intra-doc links in library/core/src/time.rs)
 - rust-lang#75350 (Do not ICE when lowering invalid extern fn with bodies)

Failed merges:

r? @ghost
@bors bors merged commit d8ac403 into rust-lang:master Aug 10, 2020
@estebank estebank deleted the js-for-i-of-x branch November 9, 2023 05:16
@cuviper cuviper added this to the 1.47.0 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnTitor JohnTitor JohnTitor approved these changes

@davidtwco davidtwco davidtwco approved these changes

Assignees

@davidtwco davidtwco

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.47.0
Development

Successfully merging this pull request may close these issues.

Provide auto-fix suggestion for for..of loop
7 participants
@estebank @rust-highfive @davidtwco @bors @JohnTitor @cuviper @eddyb