-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to intra-doc links for /library/core/src/hint.rs #75423
Move to intra-doc links for /library/core/src/hint.rs #75423
Conversation
r? @dtolnay (rust_highfive has picked a reviewer for you, use r? to override) |
@@ -61,7 +61,7 @@ pub const unsafe fn unreachable_unchecked() -> ! { | |||
/// **Note**: On platforms that do not support receiving spin-loop hints this function does not | |||
/// do anything at all. | |||
/// | |||
/// [`core::sync::atomic::spin_loop_hint`]: ../sync/atomic/fn.spin_loop_hint.html | |||
/// [`core::sync::atomic::spin_loop_hint`]: crate::sync::atomic::spin_loop_hint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would be easier if #73473 were fixed :(
Co-authored-by: Joshua Nelson <joshua@yottadb.com>
When I try to replace |
It's breaking on a re-export, which is #65983, fixed a couple of weeks ago. The error happens because CI tests with --stage 0 (#75368 (comment)). So that link can't be fixed for another couple weeks until the beta release. |
Okay let's than wait until this is fixed and I'll try another attempt with this link. |
@bors r+ |
📌 Commit 4c5896f has been approved by |
It sounds like the two changes here (unreachable and spin_loop_hint) are fine, and we can follow up on the convert::identity link separately. |
…int, r=dtolnay Move to intra-doc links for /library/core/src/hint.rs Helps with rust-lang#75080. @rustbot modify labels: T-doc, A-intra-doc-links, T-rustdoc
Rollup of 10 pull requests Successful merges: - rust-lang#74204 (Don't visit foreign function bodies when lowering ast to hir) - rust-lang#74314 (rustc_typeck: construct {Closure,Generator}Substs more directly.) - rust-lang#74346 (Use LocalDefId instead of HirId for reachable_set elements.) - rust-lang#74399 (Move DelaySpanBugEmitted to ty::context) - rust-lang#75177 (Add regression test for issue-66768) - rust-lang#75223 (Add #[track_caller] to `Session::delay_span_bug`) - rust-lang#75423 (Move to intra-doc links for /library/core/src/hint.rs) - rust-lang#75485 (pin docs: add some forward references) - rust-lang#75569 (Bump minor version of emsdk to 1.38.47) - rust-lang#75596 (Switch to intra-doc links in /sys/windows/ext/{ffi,fs,process}.rs) Failed merges: r? @ghost
Helps with #75080.
@rustbot modify labels: T-doc, A-intra-doc-links, T-rustdoc