Rollup of 10 pull requests #75474
Closed
Rollup of 10 pull requests #75474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This creates the language item for arrays, and adds the map fn which is like map in options or iterators. It currently allocates an extra array, unfortunately. Added fixme for transmuting Fix typo
Add basic test And also run fmt which is where the other changes are from Fix mut issues These only appear when running tests, so resolved by adding mut
Add pub and rm guard impl Add explicit type to guard Add safety note Change guard type from T to S It should never have been T, as it guards over [MaybeUninit<S>; N] Also add feature to test
Switch from indexing to zip, and also use `write` on `MaybeUninit`. Add array_map feature to core/src/lib Attempt to fix issue of no such feature
This changes a couple of names around, adds another small test of variable size, and hides the rustdoc #![feature(..)]. Fmt doctest
All of these were review comments in rust-lang#74621 that I first fixed in that PR, but later accidentally overwrote by a force push.
A few updates: - Some minor wording and formatting changes. - Remove the `cargo` column. - Explain the columns up-front. - Add no-wrap on the target-triple, which looks better to me. - Minor mention on how to install support for a built-in target via rustup.
…rAus `#[deny(unsafe_op_in_unsafe_fn)]` in sys/cloudabi Partial fix of rust-lang#73904. This encloses unsafe operations in unsafe fn in sys/cloudabi.
…rAus Fix wasi::fs::OpenOptions to imply write when append is on This PR fixes a bug in `OpenOptions` of `wasi` platform that it currently doesn't imply write mode when only `append` is enabled. As explained in the [doc of OpenOptions#append](https://doc.rust-lang.org/std/fs/struct.OpenOptions.html#method.append), calling `.append(true)` should imply `.write(true)` as well. ## Reproduce Given below simple Rust program: ```rust use std::fs::OpenOptions; use std::io::Write; fn main() { let mut file = OpenOptions::new() .write(true) .create(true) .open("foo.txt") .unwrap(); writeln!(file, "abc").unwrap(); } ``` it can successfully compiled into wasm and execute by `wasmtime` runtime: ```sh $ rustc --target wasm32-wasi write.rs $ ~/wasmtime/target/debug/wasmtime run --dir=. write.wasm $ cat foo.txt abc ``` However when I change `.write(true)` to `.append(true)`, it fails to execute by the error "Capabilities insufficient": ```sh $ ~/wasmtime/target/debug/wasmtime run --dir=. append.wasm thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Os { code: 76, kind: Other, message: "Capabilities insufficient" }', append.rs:10:5 note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace Error: failed to run main module `append.wasm` ... ``` This is because of lacking "rights" on the opened file: ```sh $ RUST_LOG=trace ~/wasmtime/target/debug/wasmtime run --dir=. append.wasm 2>&1 | grep validate_rights TRACE wasi_common::entry > | validate_rights failed: required rights = HandleRights { base: fd_write (0x40), inheriting: empty (0x0) }; actual rights = HandleRights { base: fd_seek|fd_fdstat_set_flags|fd_sync|fd_tell|fd_advise|fd_filestat_set_times|poll_fd_readwrite (0x88000bc), inheriting: empty (0x0) } ```
…gs, r=varkor Fix some Clippy warnings in librustc_serialize
…rtodt Add `array` lang item and `[T; N]::map(f: FnMut(T) -> S)` This introduces an `array` lang item so functions can be defined on top of `[T; N]`. This was previously not done because const-generics was not complete enough to allow for this. Now it is in a state that is usable enough to start adding functions. The function added is a monadic (I think?) map from `[T; N] -> [S; N]`. Until transmute can function on arrays, it also allocates an extra temporary array, but this can be removed at some point. r? @lcnr
Fix suggestion to use lifetime in type and in assoc const _Do not merge until rust-lang#75363 has landed, as it has the test case for this._ * Account for associated types * Associated `const`s can't have generics (fix rust-lang#74264) * Do not suggest duplicate lifetimes and suggest `for<'a>` more (fix rust-lang#72404)
…rAus Fix minor things in the `f32` primitive docs All of these were review comments in rust-lang#74621 that I first fixed in that PR, but later accidentally overwrote by a force push. Thanks @the8472 for noticing. r? @KodrAus
Update cargo 7 commits in 1653f354644834073d6d2541e27fae94588e685e..ab32ee88dade1b50c77347599e82ca2de3fb8a51 2020-08-04 23:14:37 +0000 to 2020-08-10 17:44:43 +0000 - Build manpage archive deterministically (rust-lang/cargo#8600) - doc: Qualify GNU licenses in example license field (rust-lang/cargo#8604) - Fix jobserver_exists test on single-cpu systems (rust-lang/cargo#8598) - Fix small typo in reference/profiles.md (rust-lang/cargo#8605) - Default cargo publish to the alt registry if it's the only allowed one (rust-lang/cargo#8571) - cargo install with specific yanked version gives confusing "not found" error (rust-lang/cargo#8565) - Fix typo (rust-lang/cargo#8589)
…lacrum Move platform support to the rustc book. This moves the [Platform Support](https://forge.rust-lang.org/release/platform-support.html) page from the forge to the rustc book. There are several reasons for doing this: * The forge is not really oriented towards end-users (it mostly contains infrastructure, governance and policy, internal team pages, etc.). This platform support page is useful to user to know which targets are supported. * This page can now be updated in-sync with any PRs that add or remove a target, or change its status. * This is now automatically checked on CI to verify the list does not get out of sync. Currently it only checks the presence/absence of an entry, but more sophisticated checks could be added in the future. I'm not 100% certain this is the best location, but I think it fits. I'd like to see the rustc guide continue to grow, including things like linking information and more platform-specific details.
merge `as_local_hir_id` with `local_def_id_to_hir_id` `as_local_hir_id` was defined as just calling `local_def_id_to_hir_id` and I think that having two different ways to call the same method is somewhat confusing. Don't really care about which of these 2 methods we want to keep. Does this require an MCP, considering that these methods are fairly frequently used?
…iser add regression test for rust-lang#74739 (mir const-prop bug) Fixes rust-lang#74739
|
@bors r+ p=5 rollup=never |
|
📌 Commit efc4776 has been approved by |
bors
added
the
S-waiting-on-bors
|
⌛ Testing commit efc4776 with merge 2b2219a8d47f8d8796ee6067ea8e25b3bff6e384... |
|
@Dylan-DPC It'd be great if you could add the |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
Failed due to #75212, closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
#[deny(unsafe_op_in_unsafe_fn)]in sys/cloudabi #75115 (#[deny(unsafe_op_in_unsafe_fn)]in sys/cloudabi)arraylang item and[T; N]::map(f: FnMut(T) -> S)#75212 (Addarraylang item and[T; N]::map(f: FnMut(T) -> S))f32primitive docs #75400 (Fix minor things in thef32primitive docs)as_local_hir_idwithlocal_def_id_to_hir_id#75448 (mergeas_local_hir_idwithlocal_def_id_to_hir_id)Failed merges:
r? @ghost