Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote missing_fragment_specifier to hard error #75516

Merged
merged 4 commits into from
Aug 18, 2020
Merged

Promote missing_fragment_specifier to hard error #75516

merged 4 commits into from
Aug 18, 2020

Commits on Aug 18, 2020

  1. Move macro test to ui/macros

    @matklad
    matklad committed Aug 18, 2020
    Configuration menu
    Copy the full SHA
    84fcd0d View commit details
    Browse the repository at this point in the history

  2. Promote missing_fragment_specifier to hard error 

    It has been deny_by_default since 2017 (and warned for some time
before that), so it seems reasonable to promote it.

The specific technical motivation to do this now is to remove a field
from `ParseSess` -- it is a global state, and global state makes
extracting libraries annoying.

Closes rust-lang#40107
    @matklad
    matklad committed Aug 18, 2020
    Configuration menu
    Copy the full SHA
    02eae43 View commit details
    Browse the repository at this point in the history

  3. Remove missing_fragment_specifier lint

    @matklad
    matklad committed Aug 18, 2020
    Configuration menu
    Copy the full SHA
    5ba9610 View commit details
    Browse the repository at this point in the history

  4. Remove broken clap versions from cargotest 

    treeify depends on an outdated version of clap, which will fail to compile
when we promote missing_fragment_specifier future compat lint to
error (ie, old clap contains code that shouldn't have compiled in the
first place).

Additionally, this crate seem tiny relative to other crates we are
testing here, so it seems like it doesn't provide that much additional
confidence.

The same happens with tokei project, but it is an actively maintained
one, so we can just upgrade it to a version from 2018, where clap was
upgraded.
    @matklad
    matklad committed Aug 18, 2020
    Configuration menu
    Copy the full SHA
    eb4d6b5 View commit details
    Browse the repository at this point in the history