unions: test move behavior of non-Copy fields #75559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
7 tasks
|
@joshtriplett IIRC you had some interest in stabilizing more of unions; could you maybe help review this? |
RalfJung
force-pushed
the
union-test-move
branch
2 times, most recently
from
5249b39 to
9c16cc2
Compare
|
@joshtriplett this is ready for another round of review. |
|
LGTM. |
|
@bors r=joshtriplett rollup |
|
📌 Commit 9c16cc2 has been approved by |
bors
added
S-waiting-on-bors
RalfJung
added a commit
to RalfJung/rust
that referenced
this pull request
Sep 13, 2020
…plett unions: test move behavior of non-Copy fields This test ensures the behaviors suggested by @petrochenkov [here](rust-lang#32836 (comment)).
|
Failed in #76664 (comment) |
bors
added
S-waiting-on-author
RalfJung
force-pushed
the
union-test-move
branch
from
9c16cc2 to
5dfe015
Compare
|
@bors r=joshtriplett |
|
📌 Commit 5dfe015 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 13, 2020
…as-schievink Rollup of 12 pull requests Successful merges: - rust-lang#75559 (unions: test move behavior of non-Copy fields) - rust-lang#76441 (Note that parallel-compiler = true causes tests to fail) - rust-lang#76527 (Remove internal and unstable MaybeUninit::UNINIT.) - rust-lang#76629 (Simplify iter zip struct doc) - rust-lang#76640 (Simplify SyncOnceCell's `take` and `drop`.) - rust-lang#76646 (Add mailmap entry) - rust-lang#76651 (Remove Windows details from Unix and VmWorks symlink() docstrings) - rust-lang#76663 (Simplify iter chain struct doc) - rust-lang#76665 (slice::from_raw_parts: explicitly mention that data must be initialized) - rust-lang#76667 (Fix CI LLVM to work on NixOS out of the box) - rust-lang#76668 (Add visualization of rustc span in doc) - rust-lang#76677 (note that test_stable_pointers does not reflect a stable guarantee) Failed merges: r? `@ghost`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test ensures the behaviors suggested by @petrochenkov here.