-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't use dep_graph.with_ignore
when encoding fn param names
#75635
Conversation
The call to `with_ignore` was added years ago, and should no longer be necessary with the modern incremental query infrastructure. I also removed a related FIXME comment for issue rust-lang#38501, which was closed months ago.
r? @lcnr (rust_highfive has picked a reviewer for you, use r? to override) |
@bors try @rust-timer queue |
Awaiting bors try build completion |
⌛ Trying commit 5d40e45 with merge 465b1652e593ffc0e226b5e06bd770104f1451b7... |
r? @eddyb |
☀️ Try build successful - checks-actions, checks-azure |
Queued 465b1652e593ffc0e226b5e06bd770104f1451b7 with parent e8df0b8, future comparison URL. |
Finished benchmarking try commit (465b1652e593ffc0e226b5e06bd770104f1451b7): comparison url. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up. @bors rollup=never |
@bors r+ |
📌 Commit 5d40e45 has been approved by |
☀️ Test successful - checks-actions, checks-azure |
The call to
with_ignore
was added years ago, and should no longer benecessary with the modern incremental query infrastructure.
I also removed a related FIXME comment for issue #38501, which was
closed months ago.