Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use dep_graph.with_ignore when encoding fn param names #75635

Merged
merged 1 commit into from
Aug 18, 2020

Conversation

Aaron1011
Copy link
Member

The call to with_ignore was added years ago, and should no longer be
necessary with the modern incremental query infrastructure.

I also removed a related FIXME comment for issue #38501, which was
closed months ago.

The call to `with_ignore` was added years ago, and should no longer be
necessary with the modern incremental query infrastructure.

I also removed a related FIXME comment for issue rust-lang#38501, which was
closed months ago.
@rust-highfive
Copy link
Collaborator

r? @lcnr

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 17, 2020
@Mark-Simulacrum
Copy link
Member

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion

@bors
Copy link
Contributor

bors commented Aug 17, 2020

⌛ Trying commit 5d40e45 with merge 465b1652e593ffc0e226b5e06bd770104f1451b7...

@lcnr
Copy link
Contributor

lcnr commented Aug 17, 2020

r? @eddyb

@rust-highfive rust-highfive assigned eddyb and unassigned lcnr Aug 17, 2020
@bors
Copy link
Contributor

bors commented Aug 17, 2020

☀️ Try build successful - checks-actions, checks-azure
Build commit: 465b1652e593ffc0e226b5e06bd770104f1451b7 (465b1652e593ffc0e226b5e06bd770104f1451b7)

@rust-timer
Copy link
Collaborator

Queued 465b1652e593ffc0e226b5e06bd770104f1451b7 with parent e8df0b8, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (465b1652e593ffc0e226b5e06bd770104f1451b7): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never

@eddyb
Copy link
Member

eddyb commented Aug 18, 2020

@bors r+

@bors
Copy link
Contributor

bors commented Aug 18, 2020

📌 Commit 5d40e45 has been approved by eddyb

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 18, 2020
@bors
Copy link
Contributor

bors commented Aug 18, 2020

⌛ Testing commit 5d40e45 with merge b287b56...

@bors
Copy link
Contributor

bors commented Aug 18, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: eddyb
Pushing b287b56 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 18, 2020
@bors bors merged commit b287b56 into rust-lang:master Aug 18, 2020
@cuviper cuviper added this to the 1.47.0 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants