Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add queries for LocalDefId <-> HirId conversion (take 2) #75641

Closed
wants to merge 6 commits into from
Closed

Add queries for LocalDefId <-> HirId conversion (take 2) #75641

wants to merge 6 commits into from

Conversation

Aaron1011
Copy link
Member

This is a second attempt at PR #70039.
Fixes #62649

I've left the workaround code from #62649 in place, but changed it to bug! instead of bail out.

@rust-highfive
Copy link
Collaborator

r? @varkor

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 17, 2020
@Aaron1011
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion

@bors
Copy link
Contributor

bors commented Aug 17, 2020

⌛ Trying commit 7905f148d2cd3c50732d21d3f9d2ef0e78c7bc57 with merge b3756ef883e14717e30163245752aaa3cfce2f48...

@bors
Copy link
Contributor

bors commented Aug 17, 2020

☀️ Try build successful - checks-actions, checks-azure
Build commit: b3756ef883e14717e30163245752aaa3cfce2f48 (b3756ef883e14717e30163245752aaa3cfce2f48)

@rust-timer
Copy link
Collaborator

Queued b3756ef883e14717e30163245752aaa3cfce2f48 with parent e8df0b8, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (b3756ef883e14717e30163245752aaa3cfce2f48): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never

@Aaron1011 Aaron1011 force-pushed the feature/new-track-hir-id branch from 7905f14 to 6397e59 Compare August 18, 2020 19:50
@Aaron1011
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion

@bors
Copy link
Contributor

bors commented Aug 18, 2020

⌛ Trying commit 6397e59300801217175196ff8b8d8493185abb57 with merge b2d89c78f6016d72d0f92bd3b9539328f9c6797c...

@bors
Copy link
Contributor

bors commented Aug 18, 2020

☀️ Try build successful - checks-actions, checks-azure
Build commit: b2d89c78f6016d72d0f92bd3b9539328f9c6797c (b2d89c78f6016d72d0f92bd3b9539328f9c6797c)

@rust-timer
Copy link
Collaborator

Queued b2d89c78f6016d72d0f92bd3b9539328f9c6797c with parent b287b56, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (b2d89c78f6016d72d0f92bd3b9539328f9c6797c): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never

@Aaron1011
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion

@bors
Copy link
Contributor

bors commented Aug 18, 2020

⌛ Trying commit 93baa539947593b790ccf508fb9a2c85f08d8900 with merge b674bc729e74dae1904c28716af364e06848a609...

@bors
Copy link
Contributor

bors commented Aug 18, 2020

☀️ Try build successful - checks-actions, checks-azure
Build commit: b674bc729e74dae1904c28716af364e06848a609 (b674bc729e74dae1904c28716af364e06848a609)

@rust-timer
Copy link
Collaborator

Queued b674bc729e74dae1904c28716af364e06848a609 with parent be97d13, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (b674bc729e74dae1904c28716af364e06848a609): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never

@rust-highfive rust-highfive assigned eddyb and unassigned varkor Sep 12, 2020
@crlf0710
Copy link
Member

Ping from triage, there's merge conflicts now.

@crlf0710 crlf0710 added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 12, 2020
@JohnCSimon
Copy link
Member

ping from triage, this has sat idle for a few weeks.

@Dylan-DPC-zz
Copy link

Closing this due to inactivity. Thanks

@Dylan-DPC-zz Dylan-DPC-zz added S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 29, 2020
@spastorino spastorino mentioned this pull request May 13, 2021
Merged
@Aaron1011 Aaron1011 reopened this Aug 22, 2021
@Aaron1011 Aaron1011 added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. labels Aug 22, 2021
@JohnCSimon JohnCSimon added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 6, 2021
@JohnCSimon JohnCSimon added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 27, 2021
@JohnCSimon JohnCSimon added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 19, 2021
@apiraino apiraino added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Oct 21, 2021
@JohnCSimon JohnCSimon added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 8, 2021
@JohnCSimon JohnCSimon added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 5, 2021
@joelpalmer joelpalmer added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 1, 2022
@cjgillot
Copy link
Contributor

cjgillot commented Feb 1, 2022

This PR has been superseeded by #93373 and #93301.

@JohnCSimon
Copy link
Member

This PR has been superseeded by #93373 and #93301.

@Aaron1011 Maybe close this PR?

@Dylan-DPC Dylan-DPC closed this May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@eddyb eddyb

Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone