Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow reallocation to different alignment in AllocRef #75687

Merged
merged 3 commits into from
Aug 26, 2020

Conversation

TimDiekmann
Copy link
Member

The allocator-wg has decided to support reallocating to a different alignment in AllocRef. For more details please see the linked issue.

r? @Amanieu

closes rust-lang/wg-allocators#5

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 19, 2020
@Amanieu
Copy link
Member

Amanieu commented Aug 19, 2020

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion

@bors
Copy link
Contributor

bors commented Aug 19, 2020

⌛ Trying commit 438c40e with merge 0b22c8a0d3ea0197f040b0d363462264e8646d10...

@bors
Copy link
Contributor

bors commented Aug 19, 2020

☀️ Try build successful - checks-actions, checks-azure
Build commit: 0b22c8a0d3ea0197f040b0d363462264e8646d10 (0b22c8a0d3ea0197f040b0d363462264e8646d10)

@rust-timer
Copy link
Collaborator

Queued 0b22c8a0d3ea0197f040b0d363462264e8646d10 with parent e7f6ed1, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (0b22c8a0d3ea0197f040b0d363462264e8646d10): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never

@TimDiekmann
Copy link
Member Author

TimDiekmann commented Aug 19, 2020

That's an interesting report. The regression mainly occured in doc-runs (1.2% to 0.7%). Then almost only check-, doc-, and debug-runs betwee 0.5% and 0.1%). opt-runs are not affected. Mainly the regression will come from optimizing out the third match arm in grow and shrink as this case does not occure in std. I think this is mainly as the regression almost only occure in non-incremental full build starting with empty cache.

I think the stats are looking fine 🙂

@Amanieu
Copy link
Member

Amanieu commented Aug 20, 2020

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion

@bors
Copy link
Contributor

bors commented Aug 20, 2020

⌛ Trying commit 46b547c with merge e99efcbbc9cdf3dccd23122582a09ab2bd98d1ca...

@bors
Copy link
Contributor

bors commented Aug 20, 2020

☀️ Try build successful - checks-actions, checks-azure
Build commit: e99efcbbc9cdf3dccd23122582a09ab2bd98d1ca (e99efcbbc9cdf3dccd23122582a09ab2bd98d1ca)

@rust-timer
Copy link
Collaborator

Queued e99efcbbc9cdf3dccd23122582a09ab2bd98d1ca with parent 1a22a0f, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (e99efcbbc9cdf3dccd23122582a09ab2bd98d1ca): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never

@TimDiekmann
Copy link
Member Author

Wow, didn't expected that! Nice observation.

@Amanieu
Copy link
Member

Amanieu commented Aug 20, 2020

@bors r+

@bors
Copy link
Contributor

bors commented Aug 20, 2020

📌 Commit 46b547c has been approved by Amanieu

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 20, 2020
@bors
Copy link
Contributor

bors commented Aug 20, 2020

⌛ Testing commit 46b547c with merge 79e6f4f5d592f9c34349ef841f802b473060eb84...

@bors
Copy link
Contributor

bors commented Aug 20, 2020

💔 Test failed - checks-actions

@bors bors removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Aug 20, 2020
@bors bors added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 20, 2020
@TimDiekmann
Copy link
Member Author

We just entered the beta week.

@TimDiekmann
Copy link
Member Author

TimDiekmann commented Aug 26, 2020

No Breakage Week is over, let's merge this. 🙂

@Amanieu
Copy link
Member

Amanieu commented Aug 26, 2020

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 26, 2020
@bors
Copy link
Contributor

bors commented Aug 26, 2020

⌛ Testing commit 46b547c with merge ffd59bf...

@bors
Copy link
Contributor

bors commented Aug 26, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: Amanieu
Pushing ffd59bf to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 26, 2020
@bors bors merged commit ffd59bf into rust-lang:master Aug 26, 2020
@rust-log-analyzer
Copy link
Collaborator

Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

@TimDiekmann TimDiekmann deleted the realloc-align branch August 26, 2020 13:18
@RalfJung
Copy link
Member

@rust-lang/infra something odd happened here... this is the PR that broke Miri, but for some reason CI only noticed this when the next PR (#75966) landed?

@RalfJung
Copy link
Member

A bunch of recent PRs have a "Your PR failed" message after landing -- not just this one, also e.g. #75912.

@RalfJung
Copy link
Member

See Zulip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support reallocating to a different alignment?
8 participants